[PATCH 1/7] drivers: clk: unexport clk_register_gpio_gate()

[PATCH 1/7] drivers: clk: unexport clk_register_gpio_gate()

[Enrico Weigelt, metux IT consult]

The function clk_register_gpio_gate() doesn't seem to have any users
outside clk-gpio.c, thus unexport and make it static.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 drivers/clk/clk-gpio.c       | 3 +--
 include/linux/clk-provider.h | 3 ---
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
index 9d930edd6516..f9f81a31984a 100644
--- a/drivers/clk/clk-gpio.c
+++ b/drivers/clk/clk-gpio.c
@@ -186,7 +186,7 @@ struct clk_hw *clk_hw_register_gpio_gate(struct device *dev, const char *name,
 }
 EXPORT_SYMBOL_GPL(clk_hw_register_gpio_gate);
 
-struct clk *clk_register_gpio_gate(struct device *dev, const char *name,
+static struct clk *clk_register_gpio_gate(struct device *dev, const char *name,
 		const char *parent_name, struct gpio_desc *gpiod,
 		unsigned long flags)
 {
@@ -197,7 +197,6 @@ struct clk *clk_register_gpio_gate(struct device *dev, const char *name,
 		return ERR_CAST(hw);
 	return hw->clk;
 }
-EXPORT_SYMBOL_GPL(clk_register_gpio_gate);
 
 /**
  * clk_hw_register_gpio_mux - register a gpio clock mux with the clock framework
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 2fdfe8061363..d283f9896e86 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -773,9 +773,6 @@ struct clk_gpio {
 #define to_clk_gpio(_hw) container_of(_hw, struct clk_gpio, hw)
 
 extern const struct clk_ops clk_gpio_gate_ops;
-struct clk *clk_register_gpio_gate(struct device *dev, const char *name,
-		const char *parent_name, struct gpio_desc *gpiod,
-		unsigned long flags);
 struct clk_hw *clk_hw_register_gpio_gate(struct device *dev, const char *name,
 		const char *parent_name, struct gpio_desc *gpiod,
 		unsigned long flags);
-- 
2.11.0

[PATCH 2/7] drivers: clk: unexport clk_hw_register_gpio_gate()

[Enrico Weigelt, metux IT consult]

The function clk_hw_register_gpio_gate() doesn't seem to have any
users outside clk-gpio.c, thus unexport and make it static.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 drivers/clk/clk-gpio.c       | 3 +--
 include/linux/clk-provider.h | 3 ---
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
index f9f81a31984a..f457b30e4900 100644
--- a/drivers/clk/clk-gpio.c
+++ b/drivers/clk/clk-gpio.c
@@ -169,7 +169,7 @@ static struct clk_hw *clk_register_gpio(struct device *dev, const char *name,
  * @gpiod: gpio descriptor to gate this clock
  * @flags: clock flags
  */
-struct clk_hw *clk_hw_register_gpio_gate(struct device *dev, const char *name,
+static struct clk_hw *clk_hw_register_gpio_gate(struct device *dev, const char *name,
 		const char *parent_name, struct gpio_desc *gpiod,
 		unsigned long flags)
 {
@@ -184,7 +184,6 @@ struct clk_hw *clk_hw_register_gpio_gate(struct device *dev, const char *name,
 			(parent_name ? &parent_name : NULL),
 			(parent_name ? 1 : 0), gpiod, flags, ops);
 }
-EXPORT_SYMBOL_GPL(clk_hw_register_gpio_gate);
 
 static struct clk *clk_register_gpio_gate(struct device *dev, const char *name,
 		const char *parent_name, struct gpio_desc *gpiod,
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index d283f9896e86..b4338b26aed7 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -773,9 +773,6 @@ struct clk_gpio {
 #define to_clk_gpio(_hw) container_of(_hw, struct clk_gpio, hw)
 
 extern const struct clk_ops clk_gpio_gate_ops;
-struct clk_hw *clk_hw_register_gpio_gate(struct device *dev, const char *name,
-		const char *parent_name, struct gpio_desc *gpiod,
-		unsigned long flags);
 void clk_hw_unregister_gpio_gate(struct clk_hw *hw);
 
 extern const struct clk_ops clk_gpio_mux_ops;
-- 
2.11.0

[PATCH 3/7] include: linux: clk-provider: remove obsolete clk_hw_unregister_gpio_gate()

[Enrico Weigelt, metux IT consult]

There's a prototype for clk_hw_unregister_gpio_gate(), but no actual
implementation. Seems to be an old leftover, thus remove it.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 include/linux/clk-provider.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index b4338b26aed7..4ac2ee6655f9 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -773,7 +773,6 @@ struct clk_gpio {
 #define to_clk_gpio(_hw) container_of(_hw, struct clk_gpio, hw)
 
 extern const struct clk_ops clk_gpio_gate_ops;
-void clk_hw_unregister_gpio_gate(struct clk_hw *hw);
 
 extern const struct clk_ops clk_gpio_mux_ops;
 struct clk *clk_register_gpio_mux(struct device *dev, const char *name,
-- 
2.11.0

[PATCH 4/7] drivers: clk: unexport clk_register_gpio_mux()

[Enrico Weigelt, metux IT consult]

The function clk_register_gpio_mux() doesn't seem to have any
users outside clk-gpio.c, thus unexport and make it static.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 drivers/clk/clk-gpio.c       | 3 +--
 include/linux/clk-provider.h | 3 ---
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
index f457b30e4900..5aa9ffe394ef 100644
--- a/drivers/clk/clk-gpio.c
+++ b/drivers/clk/clk-gpio.c
@@ -220,7 +220,7 @@ struct clk_hw *clk_hw_register_gpio_mux(struct device *dev, const char *name,
 }
 EXPORT_SYMBOL_GPL(clk_hw_register_gpio_mux);
 
-struct clk *clk_register_gpio_mux(struct device *dev, const char *name,
+static struct clk *clk_register_gpio_mux(struct device *dev, const char *name,
 		const char * const *parent_names, u8 num_parents, struct gpio_desc *gpiod,
 		unsigned long flags)
 {
@@ -232,7 +232,6 @@ struct clk *clk_register_gpio_mux(struct device *dev, const char *name,
 		return ERR_CAST(hw);
 	return hw->clk;
 }
-EXPORT_SYMBOL_GPL(clk_register_gpio_mux);
 
 static int gpio_clk_driver_probe(struct platform_device *pdev)
 {
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 4ac2ee6655f9..054e3c128ac5 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -775,9 +775,6 @@ struct clk_gpio {
 extern const struct clk_ops clk_gpio_gate_ops;
 
 extern const struct clk_ops clk_gpio_mux_ops;
-struct clk *clk_register_gpio_mux(struct device *dev, const char *name,
-		const char * const *parent_names, u8 num_parents, struct gpio_desc *gpiod,
-		unsigned long flags);
 struct clk_hw *clk_hw_register_gpio_mux(struct device *dev, const char *name,
 		const char * const *parent_names, u8 num_parents, struct gpio_desc *gpiod,
 		unsigned long flags);
-- 
2.11.0

[PATCH 5/7] drivers: clk: unexport clk_gpio_mux_ops field

[Enrico Weigelt, metux IT consult]

The clk_gpio_mux_ops field doesn't seem to have any users
outside clk-gpio.c, thus unexport and make it static.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 drivers/clk/clk-gpio.c       | 3 +--
 include/linux/clk-provider.h | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
index 5aa9ffe394ef..005e311c1822 100644
--- a/drivers/clk/clk-gpio.c
+++ b/drivers/clk/clk-gpio.c
@@ -111,12 +111,11 @@ static int clk_gpio_mux_set_parent(struct clk_hw *hw, u8 index)
 	return 0;
 }
 
-const struct clk_ops clk_gpio_mux_ops = {
+static const struct clk_ops clk_gpio_mux_ops = {
 	.get_parent = clk_gpio_mux_get_parent,
 	.set_parent = clk_gpio_mux_set_parent,
 	.determine_rate = __clk_mux_determine_rate,
 };
-EXPORT_SYMBOL_GPL(clk_gpio_mux_ops);
 
 static struct clk_hw *clk_register_gpio(struct device *dev, const char *name,
 		const char * const *parent_names, u8 num_parents, struct gpio_desc *gpiod,
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 054e3c128ac5..b00adc1909a1 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -774,7 +774,6 @@ struct clk_gpio {
 
 extern const struct clk_ops clk_gpio_gate_ops;
 
-extern const struct clk_ops clk_gpio_mux_ops;
 struct clk_hw *clk_hw_register_gpio_mux(struct device *dev, const char *name,
 		const char * const *parent_names, u8 num_parents, struct gpio_desc *gpiod,
 		unsigned long flags);
-- 
2.11.0

[PATCH 6/7] drivers: clk: unexport clk_gpio_gate_ops field

[Enrico Weigelt, metux IT consult]

The clk_gpio_gate_ops field doesn't seem to have any
users outside clk-gpio.c, thus unexport and make it static.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 drivers/clk/clk-gpio.c       | 3 +--
 include/linux/clk-provider.h | 2 --
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
index 005e311c1822..a7e75a038728 100644
--- a/drivers/clk/clk-gpio.c
+++ b/drivers/clk/clk-gpio.c
@@ -51,12 +51,11 @@ static int clk_gpio_gate_is_enabled(struct clk_hw *hw)
 	return gpiod_get_value(clk->gpiod);
 }
 
-const struct clk_ops clk_gpio_gate_ops = {
+static const struct clk_ops clk_gpio_gate_ops = {
 	.enable = clk_gpio_gate_enable,
 	.disable = clk_gpio_gate_disable,
 	.is_enabled = clk_gpio_gate_is_enabled,
 };
-EXPORT_SYMBOL_GPL(clk_gpio_gate_ops);
 
 static int clk_sleeping_gpio_gate_prepare(struct clk_hw *hw)
 {
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index b00adc1909a1..59a7f273a182 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -772,8 +772,6 @@ struct clk_gpio {
 
 #define to_clk_gpio(_hw) container_of(_hw, struct clk_gpio, hw)
 
-extern const struct clk_ops clk_gpio_gate_ops;
-
 struct clk_hw *clk_hw_register_gpio_mux(struct device *dev, const char *name,
 		const char * const *parent_names, u8 num_parents, struct gpio_desc *gpiod,
 		unsigned long flags);
-- 
2.11.0

[PATCH 7/7] drivers: clk: unexport clk_hw_register_gpio_mux()

[Enrico Weigelt, metux IT consult]

The function clk_hw_register_gpio_mux() doesn't seem to have any
users outside clk-gpio.c, thus unexport and make it static.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 drivers/clk/clk-gpio.c       | 3 +--
 include/linux/clk-provider.h | 3 ---
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
index a7e75a038728..70381bf75d02 100644
--- a/drivers/clk/clk-gpio.c
+++ b/drivers/clk/clk-gpio.c
@@ -204,7 +204,7 @@ static struct clk *clk_register_gpio_gate(struct device *dev, const char *name,
  * @gpiod: gpio descriptor to gate this clock
  * @flags: clock flags
  */
-struct clk_hw *clk_hw_register_gpio_mux(struct device *dev, const char *name,
+static struct clk_hw *clk_hw_register_gpio_mux(struct device *dev, const char *name,
 		const char * const *parent_names, u8 num_parents, struct gpio_desc *gpiod,
 		unsigned long flags)
 {
@@ -216,7 +216,6 @@ struct clk_hw *clk_hw_register_gpio_mux(struct device *dev, const char *name,
 	return clk_register_gpio(dev, name, parent_names, num_parents,
 			gpiod, flags, &clk_gpio_mux_ops);
 }
-EXPORT_SYMBOL_GPL(clk_hw_register_gpio_mux);
 
 static struct clk *clk_register_gpio_mux(struct device *dev, const char *name,
 		const char * const *parent_names, u8 num_parents, struct gpio_desc *gpiod,
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 59a7f273a182..961c1048a9ca 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -772,9 +772,6 @@ struct clk_gpio {
 
 #define to_clk_gpio(_hw) container_of(_hw, struct clk_gpio, hw)
 
-struct clk_hw *clk_hw_register_gpio_mux(struct device *dev, const char *name,
-		const char * const *parent_names, u8 num_parents, struct gpio_desc *gpiod,
-		unsigned long flags);
 void clk_hw_unregister_gpio_mux(struct clk_hw *hw);
 
 struct clk *clk_register(struct device *dev, struct clk_hw *hw);
-- 
2.11.0

Re: [PATCH 1/7] drivers: clk: unexport clk_register_gpio_gate()

[Stephen Boyd]

Quoting Enrico Weigelt, metux IT consult (2019-11-28 06:44:44)
> The function clk_register_gpio_gate() doesn't seem to have any users
> outside clk-gpio.c, thus unexport and make it static.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---

Is any of this patch series relevant when [1] is applied? I think I will
just apply that patch instead.

[1] https://lkml.kernel.org/r/20190830150923.259497-2-sboyd@kernel.org