From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AFC3C43603 for ; Wed, 4 Dec 2019 08:38:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDBB8206DF for ; Wed, 4 Dec 2019 08:38:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I7KtYnye" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726166AbfLDIid (ORCPT ); Wed, 4 Dec 2019 03:38:33 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37761 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726856AbfLDIid (ORCPT ); Wed, 4 Dec 2019 03:38:33 -0500 Received: by mail-wm1-f68.google.com with SMTP id f129so6864812wmf.2 for ; Wed, 04 Dec 2019 00:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ParemWJI/n3SRaHe2+emu1Uz8fq8wC/gKNUHTDS5UZA=; b=I7KtYnyek5P0gcpiPIk3bBEEuE4asY8oupB3ktcj4a+Zlqh3iJEq00gSYseHDHFA1k npRaWnG1YQdVAzGC705aKfaffcpFxVFg3EIW5eB08uRvsTwXLJrdA/rKOQODQaaSYp9G Bl4wOYG7N75IxhMZvVe/qTQ3Dybq1QU+R/Iq15cm1Wb/SO2XaLWfyRmzPzWY4qTBtvjE P9UL817iJzoubCEecetvcYIo9Q5MT+iK6+QI+Gs4DR+nIq7wLkAJTd7Lg7+qwSiBRwG3 XGxJWSSqTOkTo0xnO5fH8TrN0exJvvhERHsi18OX6rWz6STVCITNp16EkSXl2AgG5IRm YlZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ParemWJI/n3SRaHe2+emu1Uz8fq8wC/gKNUHTDS5UZA=; b=h+fJnk/7GbNFxstwojAFggWe6Ap53H9zyanTD9QxlCGKtRtY4y7hVyn4ODdCD+az3i 84yVp3p+MKtuVOauMxL8Re78lCG0s9IjEbUDrgBHFh8Sj33vKRKZnSA96IB596eYAnVK 8AMl6n2R6OWn51JKCxNIAMAO4RAcdGrIPGS0yTDI85uz6OrEDTKq5uw9fr49WV/iG9qb Kjyt1OFw03ktEdnSttv7QpufnWv3vfqGTNq/AGYYsSdViIIW5xz2cLcq4H1os8EwWTiF SpoDGTp96dh1kRBtlygpY7QXB/m4/b+5A3938nxONgjKsnSuMSDG1dm6HwduGDUfFutz XG4A== X-Gm-Message-State: APjAAAU9ymtvGNLXmF5Ly7nM4DLIUKeGbtxcRXPpz4gzFTDEfmd5/wnt Rr55fDam2bVwtvNvl3hZTi7RWw== X-Google-Smtp-Source: APXvYqxJaxqhbIwl3EXEj5JJcorn8bsz0Y2qMyfYC0/6j9OurqtOKq56dRGJl4zjgTb+4IE9o3KbUA== X-Received: by 2002:a1c:7e0e:: with SMTP id z14mr40884745wmc.52.1575448711046; Wed, 04 Dec 2019 00:38:31 -0800 (PST) Received: from dell ([2.27.167.28]) by smtp.gmail.com with ESMTPSA id n30sm5805552wmd.3.2019.12.04.00.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 00:38:30 -0800 (PST) Date: Wed, 4 Dec 2019 08:38:21 +0000 From: Lee Jones To: Geert Uytterhoeven Cc: Chris Brandt , Mark Brown , Rob Herring , Mark Rutland , Michael Turquette , Stephen Boyd , linux-spi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , linux-clk , Mason Yang , Sergei Shtylyov Subject: Re: [PATCH 2/6] ARM: dts: r7s72100: Add SPIBSC clocks Message-ID: <20191204083821.GA3468@dell> References: <20191203034519.5640-1-chris.brandt@renesas.com> <20191203034519.5640-3-chris.brandt@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, 03 Dec 2019, Geert Uytterhoeven wrote: > Hi Chris, > > CC Lee (for clock-critical) > > On Tue, Dec 3, 2019 at 7:58 PM Chris Brandt wrote: > > On Tue, Dec 3, 2019, Geert Uytterhoeven wrote: > > > > + reg = <0x3fefa000 0x100>, <0x18000000 > > > > + 0x4000000>; > > > > > > The second region conflicts with the XIP flash@18000000 in > > > arch/arm/boot/dts/r7s72100-gr-peach.dts. > > > Yes, I know it is the same device ;-) > > > > Is that just an FYI?? Or do you have some suggestion?? > > Can the flash subnode be compatible with "mtd-rom", even if the parent node > is kept disabled? > > > > > + clock-critical = <4>; /* spibsc0 */ > > > > > > Iff we go this clock-critical route, I think this should be specified in the > > > board-specific .dts instead of in the SoC-specific .dtsi. > > > > OK, that's fine. It makes more sense to be in the .dts because it's a board > > design decision. I will remove it from the patch. > > > > The one 'tricky' thing is that the <4> is the index into the number of clocks. > > > > So in the Renesas BSP where it includes the VDC5 LCD controllers, > > > > clock-output-names = "i2c0", "i2c1", "i2c2", "i2c3", "vdc50", "vdc51", "spibsc0", "spibsc1"; > > > > the <4> needs to become a <6>. > > Unless you pass "clkidx" instead of "i" to of_clk_detect_critical() in [1], > and use "clock-critical = " in DT? > > Unfortunately the exact semantics of clock-critical were never documented. > Lee? /** * of_clk_detect_critical() - set CLK_IS_CRITICAL flag from Device Tree * @np: Device node pointer associated with clock provider * @index: clock index * @flags: pointer to top-level framework flags * * Detects if the clock-critical property exists and, if so, sets the * corresponding CLK_IS_CRITICAL flag. * * Do not use this function. It exists only for legacy Device Tree * bindings, such as the one-clock-per-node style that are outdated. * Those bindings typically put all clock data into .dts and the Linux * driver has no clock data, thus making it impossible to set this flag * correctly from the driver. Only those drivers may call * of_clk_detect_critical from their setup functions. * * Return: error code or zero on success */ If this meets the criteria, the API is pretty simple/self explanatory. What are you having trouble with? > Thanks! > > [1] "[PATCH 1/6] clk: renesas: mstp: Add critical clock from device > tree support" > https://lore.kernel.org/linux-renesas-soc/20191203034519.5640-2-chris.brandt@renesas.com/ > > > Gr{oetje,eeting}s, > > Geert > -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog