From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Paolo Pisati <p.pisati@gmail.com>
Subject: [PATCH 0/2] clk: qcom: gcc-msm8996: Fix CLKREF parenting
Date: Sat, 7 Dec 2019 12:36:01 -0800 [thread overview]
Message-ID: <20191207203603.2314424-1-bjorn.andersson@linaro.org> (raw)
We've always seen intermittent resets of msm8996 during boot, seemingly related
to PCIe somehow. The likely cause of these errors are the fact that the CLKREF
of all PHYs are parented by LN_BB, which while being on during boot is disabled
by the UFS host driver if it fails to find its PHY.
As such, depending on the timeing (and success) of the UFS initialization PCIe
might loose its clocking.
These two patches ensures that LN_BB, connected to the CXO2 pad on the SoC, is
described as parent for all the CLKREF clocks. So that they all vote for this
clock appropriately.
Bjorn Andersson (2):
clk: qcom: gcc-msm8996: Fix parent for CLKREF clocks
arm64: dts: qcom: msm8996: Define parent clocks for gcc
.../devicetree/bindings/clock/qcom,gcc.yaml | 6 ++--
arch/arm64/boot/dts/qcom/msm8996.dtsi | 3 ++
drivers/clk/qcom/gcc-msm8996.c | 35 +++++++++++++++----
3 files changed, 35 insertions(+), 9 deletions(-)
--
2.24.0
next reply other threads:[~2019-12-07 20:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 20:36 Bjorn Andersson [this message]
2019-12-07 20:36 ` [PATCH 1/2] clk: qcom: gcc-msm8996: Fix parent for CLKREF clocks Bjorn Andersson
2019-12-18 23:43 ` Rob Herring
2019-12-19 6:37 ` Stephen Boyd
2019-12-20 2:34 ` Bjorn Andersson
2019-12-24 2:20 ` Stephen Boyd
2019-12-26 22:41 ` Bjorn Andersson
2019-12-27 1:35 ` Stephen Boyd
2019-12-24 2:48 ` Stephen Boyd
2019-12-26 22:23 ` Bjorn Andersson
2019-12-26 22:34 ` Stephen Boyd
2019-12-07 20:36 ` [PATCH 2/2] arm64: dts: qcom: msm8996: Define parent clocks for gcc Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191207203603.2314424-1-bjorn.andersson@linaro.org \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=p.pisati@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).