From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9DD1C43603 for ; Fri, 13 Dec 2019 02:54:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 715E52253D for ; Fri, 13 Dec 2019 02:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576205676; bh=YT/KrD9drCHzLQDLApnDQvgJZf+lw9T1tg7LKWdDM3o=; h=In-Reply-To:References:Subject:To:From:Cc:Date:List-ID:From; b=Uzx+XkIJcoekiG+X2em0W4LhKgjOoS03gXUa4M43NOvRf/8yFOSygCbzNO/BCgqNf sfY7jVLttz6l+uwSHT5N/UHXe3thnQiG1eBypiJOC0ZADSGupXNSTMsAlw+tMrxnk8 5h/MFwx5xJizdi6unFPwf0jhRp1nYRghVYH1zC14= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727569AbfLMCyg (ORCPT ); Thu, 12 Dec 2019 21:54:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:37264 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727202AbfLMCyg (ORCPT ); Thu, 12 Dec 2019 21:54:36 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F2092073D; Fri, 13 Dec 2019 02:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576205675; bh=YT/KrD9drCHzLQDLApnDQvgJZf+lw9T1tg7LKWdDM3o=; h=In-Reply-To:References:Subject:To:From:Cc:Date:From; b=wkds8U+kIoe9X5Ddcs6WPLIemyEHzHszzlZazYRFJfH53LIXrFStXArA/bF2uGVGP w3TaFhXyF0me4QoAXI05m/PxmFmbDrIUu6vYpaLycLNF3niGHtaUpT35BH+Z/RhCzu hjVVxVEUoD0y0+FMo1/GtqL5DzyN6XU+7dFyyETQ= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20191203080805.104628-1-jbrunet@baylibre.com> References: <20191203080805.104628-1-jbrunet@baylibre.com> Subject: Re: [PATCH v2] clk: walk orphan list on clock provider registration To: Jerome Brunet , Michael Turquette From: Stephen Boyd Cc: Jerome Brunet , Kevin Hilman , linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Jian Hu User-Agent: alot/0.8.1 Date: Thu, 12 Dec 2019 18:54:34 -0800 Message-Id: <20191213025435.7F2092073D@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Jerome Brunet (2019-12-03 00:08:05) > So far, we walked the orphan list every time a new clock was registered > in CCF. This was fine since the clocks were only referenced by name. >=20 > Now that the clock can be referenced through DT, it is not enough: > * Controller A register first a reference clocks from controller B > through DT. > * Controller B register all its clocks then register the provider. >=20 > Each time controller B registers a new clock, the orphan list is walked > but it can't match since the provider is registered yet. When the > provider is finally registered, the orphan list is not walked unless > another clock is registered afterward. >=20 > This can lead to situation where some clocks remain orphaned even if > the parent is available. >=20 > Walking the orphan list on provider registration solves the problem. >=20 > Reported-by: Jian Hu > Fixes: fc0c209c147f ("clk: Allow parents to be specified without string n= ames") > Signed-off-by: Jerome Brunet > --- Applied to clk-fixes