linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Olof Johansson <olof@lixom.net>
Cc: Michael Turquette <mturquette@baylibre.com>,
	linux-clk <linux-clk@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] clk: declare clk_core_reparent_orphans() inline
Date: Tue, 17 Dec 2019 11:46:32 -0800	[thread overview]
Message-ID: <20191217194632.DE6FC2146E@mail.kernel.org> (raw)
In-Reply-To: <CAOesGMj2qRM3YhTWQubRqmjP2TgMgXVyLxHs5D=bWfd4sKnNrw@mail.gmail.com>

Quoting Olof Johansson (2019-12-17 10:01:15)
> On Tue, Dec 17, 2019 at 12:25 AM Stephen Boyd <sboyd@kernel.org> wrote:
> >
> > Quoting Olof Johansson (2019-12-16 20:46:35)
> > > A recent addition exposed a helper that is only used for
> > > CONFIG_OF. Instead of figuring out best place to have it in the order
> > > of various functions, just declare it as explicitly inline, and the
> > > compiler will happily handle it without warning.
> > >
> > > (Also fixup of a single stray empty line while I was looking at the code)
> > >
> > > Fixes: 66d9506440bb ("clk: walk orphan list on clock provider registration")
> > > Signed-off-by: Olof Johansson <olof@lixom.net>
> > > ---
> > >
> > > v3: ACTUALLY amend this time. Sigh. Time to go home.
> > >
> >
> > Isn't it simple enough to just move the function down to CONFIG_OF in
> > drivers/clk/clk.c?
> 
> "Simple" in a 5000 line file is maybe not the right word to use, but
> yeah, sure, do with it what you want.
> 
> Seems like clk.c could do with some refactoring? :)
> 

Ok.


      reply	other threads:[~2019-12-17 19:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17  4:41 [PATCH] clk: declare clk_core_reparent_orphans() inline Olof Johansson
2019-12-17  4:45 ` [PATCH v2] " Olof Johansson
2019-12-17  4:46 ` [PATCH v3] " Olof Johansson
2019-12-17  8:25   ` Stephen Boyd
2019-12-17 18:01     ` Olof Johansson
2019-12-17 19:46       ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217194632.DE6FC2146E@mail.kernel.org \
    --to=sboyd@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).