From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB9CDC2D0D5 for ; Sat, 21 Dec 2019 19:48:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0AC620700 for ; Sat, 21 Dec 2019 19:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726940AbfLUTsG (ORCPT ); Sat, 21 Dec 2019 14:48:06 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:45404 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726736AbfLUTsG (ORCPT ); Sat, 21 Dec 2019 14:48:06 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id A7AD51C24A9; Sat, 21 Dec 2019 20:48:03 +0100 (CET) Date: Sat, 21 Dec 2019 20:48:02 +0100 From: Pavel Machek To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Jacek Anaszewski , Dan Murphy , Rob Herring , Mark Rutland , Lee Jones , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Liam Girdwood , Mark Brown , Alessandro Zummo , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v7 12/12] led: bd71828: Support LED outputs on ROHM BD71828 PMIC Message-ID: <20191221194802.GK32732@amd> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="++alDQ2ROsODg1x+" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org --++alDQ2ROsODg1x+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > ROHM BD71828 power management IC has two LED outputs for charge status > and button pressing indications. The LED outputs can also be forced > by SW so add driver allowing to use these LEDs for other indications > as well. >=20 > Leds are controlled by SW using 'Force ON' bits. Please note the > constrains mentioned in data-sheet: > 1. If one LED is forced ON - then also the other LED is forced. > =3D> You can't use SW control to force ON one LED and allow HW > to control the other. > 2. You can't force both LEDs OFF. If the FORCE bit for both LED's is > zero, then LEDs are controlled by HW and indicate button/charger > states as explained in data-sheet. That's really quite sad, is it? All the effort and all we got is ... one working LED. Because hardware does not allow you to control both LEDs... =2E..and we don't even have support selecting if the LED should be sw or hw controlled in the mainline, yet... Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --++alDQ2ROsODg1x+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl3+dvIACgkQMOfwapXb+vIg1wCfYtYi6MN/BEF+ztr/KeVKSAJq ufgAoL9RYqOIuswW/TX+njSk7v8JSMf0 =GjUc -----END PGP SIGNATURE----- --++alDQ2ROsODg1x+--