From: Rob Herring <robh@kernel.org>
To: Chunyan Zhang <zhang.lyra@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang7@gmail.com>,
Chunyan Zhang <chunyan.zhang@unisoc.com>
Subject: Re: [PATCH V2 3/6] dt-bindings: clk: sprd: add bindings for sc9863a clock controller
Date: Thu, 26 Dec 2019 11:56:23 -0700 [thread overview]
Message-ID: <20191226185623.GA4463@bogus> (raw)
In-Reply-To: <20191216121932.22967-4-zhang.lyra@gmail.com>
On Mon, Dec 16, 2019 at 08:19:29PM +0800, Chunyan Zhang wrote:
> From: Chunyan Zhang <chunyan.zhang@unisoc.com>
>
> add a new bindings to describe sc9863a clock compatible string.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> ---
> .../bindings/clock/sprd,sc9863a-clk.yaml | 77 +++++++++++++++++++
> 1 file changed, 77 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.yaml b/Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.yaml
> new file mode 100644
> index 000000000000..881f0a0287e5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2019 Unisoc Inc.
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/clock/sprd,sc9863a-clk.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: SC9863A Clock Control Unit Device Tree Bindings
> +
> +maintainers:
> + - Orson Zhai <orsonzhai@gmail.com>
> + - Baolin Wang <baolin.wang7@gmail.com>
> + - Chunyan Zhang <zhang.lyra@gmail.com>
> +
> +properties:
> + "#clock-cells":
> + const: 1
> +
> + compatible :
> + enum:
> + - sprd,sc9863a-ap-clk
> + - sprd,sc9863a-pmu-gate
> + - sprd,sc9863a-pll
> + - sprd,sc9863a-mpll
> + - sprd,sc9863a-rpll
> + - sprd,sc9863a-dpll
> + - sprd,sc9863a-aon-clk
> + - sprd,sc9863a-apahb-gate
> + - sprd,sc9863a-aonapb-gate
> + - sprd,sc9863a-mm-gate
> + - sprd,sc9863a-mm-clk
> + - sprd,sc9863a-vspahb-gate
> + - sprd,sc9863a-apapb-gate
These will probably need to be split to separate schemas for the reasons
below...
> +
> + clocks:
> + description: |
> + The input parent clock(s) phandle for this clock, only list fixed
> + clocks which are decleared in devicetree.
typo.
You need to define how many clocks.
> +
> + clock-names:
> + description: |
> + Clock name strings used for driver to reference.
You need to list out the names.
> +
> + reg:
> + description: |
> + Contain the registers base address and length. It must be configured
> + only if no 'sprd,syscon' under the node.
> +
> + sprd,syscon:
> + $ref: '/schemas/types.yaml#/definitions/phandle'
> + description: |
> + The phandle to the syscon which is in the same address area with
> + the clock, and so we can get regmap for the clocks from the
> + syscon device.
It is preferred to make the clock node a child of the syscon and then
you don't need this property.
> +
> +required:
> + - compatible
> + - '#clock-cells'
> +
> +examples:
> + - |
> + ap_clk: clock-controller@21500000 {
> + compatible = "sprd,sc9863a-ap-clk";
> + reg = <0 0x21500000 0 0x1000>;
> + clocks = <&ext_32k>, <&ext_26m>;
> + clock-names = "ext-32k", "ext-26m";
> + #clock-cells = <1>;
> + };
> +
> + - |
> + apahb_gate: apahb-gate {
> + compatible = "sprd,sc9863a-apahb-gate";
> + sprd,syscon = <&ap_ahb_regs>;
> + #clock-cells = <1>;
> + };
> +
> +...
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-12-26 18:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 12:19 [PATCH V2 0/6] Add clocks for Unisoc's SC9863A Chunyan Zhang
2019-12-16 12:19 ` [PATCH V2 1/6] clk: sprd: add gate for pll clocks Chunyan Zhang
2019-12-16 12:19 ` [PATCH V2 2/6] dt-bindings: clk: sprd: rename the common file name sprd.txt to SoC specific Chunyan Zhang
2019-12-16 12:19 ` [PATCH V2 3/6] dt-bindings: clk: sprd: add bindings for sc9863a clock controller Chunyan Zhang
2019-12-26 18:56 ` Rob Herring [this message]
2019-12-31 3:06 ` Chunyan Zhang
2020-01-02 22:42 ` Rob Herring
2019-12-16 12:19 ` [PATCH V2 4/6] clk: sprd: Add dt-bindings include file for SC9863A Chunyan Zhang
2019-12-26 18:57 ` Rob Herring
2019-12-16 12:19 ` [PATCH V2 5/6] clk: sprd: Add macros for referencing parents without strings Chunyan Zhang
2019-12-16 12:19 ` [PATCH V2 6/6] clk: sprd: add clocks support for SC9863A Chunyan Zhang
2020-01-05 7:20 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226185623.GA4463@bogus \
--to=robh@kernel.org \
--cc=baolin.wang7@gmail.com \
--cc=chunyan.zhang@unisoc.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=orsonzhai@gmail.com \
--cc=sboyd@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).