linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Niklas Cassel <nks@flawful.org>, Andy Gross <agross@kernel.org>,
	Niklas Cassel <niklas.cassel@linaro.org>,
	linux-arm-msm@vger.kernel.org, amit.kucheria@linaro.org,
	Michael Turquette <mturquette@baylibre.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 7/7] clk: qcom: apcs-msm8916: use clk_parent_data to specify the parent
Date: Mon, 30 Dec 2019 10:04:42 -0800	[thread overview]
Message-ID: <20191230180443.9E700206CB@mail.kernel.org> (raw)
In-Reply-To: <20191227022652.GH1908628@ripper>

Quoting Bjorn Andersson (2019-12-26 18:26:52)
> On Mon 23 Dec 18:16 PST 2019, Stephen Boyd wrote:
> 
> > Quoting Niklas Cassel (2019-12-20 09:56:16)
> > > On Wed, Dec 18, 2019 at 10:23:39PM -0800, Stephen Boyd wrote:
> > > > This is odd. The clks could be registered with of_clk_hw_register() but
> > > > then we lose the device provider information. Maybe we should search up
> > > > one level to the parent node and if that has a DT node but the
> > > > clk controller device doesn't we should use that instead?
> > > 
> > > Hello Stephen,
> > > 
> > > Having this in the clk core is totally fine with me,
> > > since it solves my problem.
> > > 
> > > Will you cook up a patch, or do you want me to do it?
> > > 
> > 
> > Can you try the patch I appended to my previous mail? I can write
> > something up more proper later this week.
> > 
> 
> Unfortunately we have clocks with no dev, so this fail as below. Adding
> a second check for dev != NULL to your oneliner works fine though.
> 
> I.e. this ugly hack works fine:
>   core->of_node = np ? : (dev ? dev_of_node(dev->parent) : NULL);
> 

Ok, thanks for testing!


  reply	other threads:[~2019-12-30 18:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 13:59 [PATCH v3 0/7] Clock changes to support cpufreq on QCS404 Niklas Cassel
2019-11-25 13:59 ` [PATCH v3 2/7] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency Niklas Cassel
2019-12-19  6:24   ` Stephen Boyd
2019-11-25 13:59 ` [PATCH v3 3/7] clk: qcom: hfpll: register as clock provider Niklas Cassel
2019-12-19  6:24   ` Stephen Boyd
2019-11-25 13:59 ` [PATCH v3 4/7] clk: qcom: hfpll: CLK_IGNORE_UNUSED Niklas Cassel
2019-12-19  6:25   ` Stephen Boyd
2019-11-25 13:59 ` [PATCH v3 5/7] clk: qcom: hfpll: use clk_parent_data to specify the parent Niklas Cassel
2019-12-19  6:25   ` Stephen Boyd
2019-11-25 13:59 ` [PATCH v3 6/7] clk: qcom: apcs-msm8916: silently error out on EPROBE_DEFER Niklas Cassel
2019-12-19  6:25   ` Stephen Boyd
2019-11-25 13:59 ` [PATCH v3 7/7] clk: qcom: apcs-msm8916: use clk_parent_data to specify the parent Niklas Cassel
2019-12-19  6:23   ` Stephen Boyd
2019-12-20 17:22     ` Bjorn Andersson
2019-12-20 17:56     ` Niklas Cassel
2019-12-24  2:16       ` Stephen Boyd
2019-12-27  2:26         ` Bjorn Andersson
2019-12-30 18:04           ` Stephen Boyd [this message]
2020-01-03  7:47   ` Bjorn Andersson
2019-12-18 12:16 ` [PATCH v3 0/7] Clock changes to support cpufreq on QCS404 Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191230180443.9E700206CB@mail.kernel.org \
    --to=sboyd@kernel.org \
    --cc=agross@kernel.org \
    --cc=amit.kucheria@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=niklas.cassel@linaro.org \
    --cc=nks@flawful.org \
    --subject='Re: [PATCH v3 7/7] clk: qcom: apcs-msm8916: use clk_parent_data to specify the parent' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).