From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D3F8C2D0DE for ; Thu, 2 Jan 2020 00:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CB8B20842 for ; Thu, 2 Jan 2020 00:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577926505; bh=02ddkc4IuEFd4qv72kki08C8Gcv7p2IILwkeVV46LsE=; h=From:To:Cc:Subject:Date:List-ID:From; b=C6nFnMyso16o4jUUepVdztoWrApEZ9xfbLOEOTIxzSiHo2HYnrf1q+Bw56KmjfEof T++OHpW3wvCot7Ek0Z4iabAD8SW2b2fPtQvAGxAYbNI5lTxe03H2LJfgQuOZ8SgHHj TtG1O4+bqA5weoYIXjF8mrl1nyTeMNTNONY27pWk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727487AbgABAzE (ORCPT ); Wed, 1 Jan 2020 19:55:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:48268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbgABAzE (ORCPT ); Wed, 1 Jan 2020 19:55:04 -0500 Received: from mail.kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C823520672; Thu, 2 Jan 2020 00:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577926504; bh=02ddkc4IuEFd4qv72kki08C8Gcv7p2IILwkeVV46LsE=; h=From:To:Cc:Subject:Date:From; b=nHQzcjMQQC39TSD7OPgfPBTs3oMg7Zrkg9UsB6Qw+1P1Fp3OlC3ZfDWS+7mrNJefg H6Fy+IhS4DTnEETy5gxA/Bke33bbNr4Ha1NsEqlUR7VxHB/46kj4natL01NEHtKNwi H/L9N5zhMJjkOEkhCToIEmPMtlUCZ6oEoUUCOy9E= From: Stephen Boyd To: Michael Turquette , Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Jerome Brunet , Guenter Roeck Subject: [PATCH v2] clk: Warn about critical clks that fail to enable Date: Wed, 1 Jan 2020 16:55:03 -0800 Message-Id: <20200102005503.71923-1-sboyd@kernel.org> X-Mailer: git-send-email 2.24.1.735.g03f4e72817-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org If we don't warn here users of the CLK_IS_CRITICAL flag may not know that their clk isn't actually enabled because it silently fails to enable. Let's print a warning in that case so developers find these problems faster. Suggested-by: Jerome Brunet Cc: Guenter Roeck Signed-off-by: Stephen Boyd --- Changes from v1: * Switched to pr_warn and indicated clk name drivers/clk/clk.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 772258de2d1f..b03c2be4014b 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -3427,13 +3427,18 @@ static int __clk_core_init(struct clk_core *core) unsigned long flags; ret = clk_core_prepare(core); - if (ret) + if (ret) { + pr_warn("%s: critical clk '%s' failed to prepare\n", + __func__, core->name); goto out; + } flags = clk_enable_lock(); ret = clk_core_enable(core); clk_enable_unlock(flags); if (ret) { + pr_warn("%s: critical clk '%s' failed to enable\n", + __func__, core->name); clk_core_unprepare(core); goto out; } base-commit: 12ead77432f2ce32dea797742316d15c5800cb32 -- Sent by a computer, using git, on the internet