From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A737C00523 for ; Sun, 5 Jan 2020 07:22:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F82A218AC for ; Sun, 5 Jan 2020 07:22:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578208933; bh=36YMIfds6bcjOeZrdHkRP5guH3R8Wyde9Xa7tDKb8pI=; h=In-Reply-To:References:Cc:Subject:To:From:Date:List-ID:From; b=efCSqPzofvjeVeGNzDudFt0Oua7A7kuCIj7GHQT0V9D73G1b9NeR3MUtGnc7bQuAJ ODE7hHjdzYIdfs90Vb2y0gDiCYXtJY2+lbH/hU+iKyp/zzDkhPxLMLSgJ4lwDCZBiK UhWzpm0e74XpBIR+a9fVpa459LWNiZ2eeQ2otCfs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726260AbgAEHWI (ORCPT ); Sun, 5 Jan 2020 02:22:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:43618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbgAEHWI (ORCPT ); Sun, 5 Jan 2020 02:22:08 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B5A4217F4; Sun, 5 Jan 2020 07:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578208928; bh=36YMIfds6bcjOeZrdHkRP5guH3R8Wyde9Xa7tDKb8pI=; h=In-Reply-To:References:Cc:Subject:To:From:Date:From; b=Y5pNq0reydLkdp82SHfKPQEDwJd7XZHJbQ4N8+70XSxR5RX0nrt+g1d7r2CQH5LSo F9xVK8on6mx2cKZ8ys9ezNjDWKdtJZ0TjUIaAK9bmB2nsPAl/J1u9hsSuiJ5URoooC 9E4xYTSsfY6DWyMHj9u5D2js3Z2qHFmt6TTmrtmY= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200102005503.71923-1-sboyd@kernel.org> References: <20200102005503.71923-1-sboyd@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Jerome Brunet , Guenter Roeck Subject: Re: [PATCH v2] clk: Warn about critical clks that fail to enable To: Michael Turquette , Stephen Boyd From: Stephen Boyd User-Agent: alot/0.8.1 Date: Sat, 04 Jan 2020 23:22:07 -0800 Message-Id: <20200105072208.0B5A4217F4@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Stephen Boyd (2020-01-01 16:55:03) > If we don't warn here users of the CLK_IS_CRITICAL flag may not know > that their clk isn't actually enabled because it silently fails to > enable. Let's print a warning in that case so developers find these > problems faster. >=20 > Suggested-by: Jerome Brunet > Cc: Guenter Roeck > Signed-off-by: Stephen Boyd > --- Applied to clk-next