From: Stephen Boyd <sboyd@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH] clk: Don't cache errors from clk_ops::get_phase()
Date: Sat, 04 Jan 2020 23:55:55 -0800 [thread overview]
Message-ID: <20200105075556.60E1A20848@mail.kernel.org> (raw)
In-Reply-To: <20200105075050.1B93E20866@mail.kernel.org>
Quoting Stephen Boyd (2020-01-04 23:50:49)
>
> Quoting Jerome Brunet (2019-10-02 01:31:46)
> > >
> > > + clk_core_get_phase(core);
> >
> > Should the error be checked here as well ?
>
> What error?
>
Ah the error when clk_ops::get_phase() returns an error? I guess we
should just silently ignore it to maintain the previous behavior? Or we
can bail out of clk registration. Seems low risk to do that in another
patch.
next prev parent reply other threads:[~2020-01-05 7:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 17:44 [PATCH] clk: Don't cache errors from clk_ops::get_phase() Stephen Boyd
2019-10-01 21:20 ` Doug Anderson
2020-01-05 7:53 ` Stephen Boyd
2019-10-02 8:31 ` Jerome Brunet
2020-01-05 7:50 ` Stephen Boyd
2020-01-05 7:55 ` Stephen Boyd [this message]
2020-01-07 9:44 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200105075556.60E1A20848@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).