Linux-Clk Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] clk: Add support for setting clk_rate via debugfs
@ 2019-08-28 13:23 Geert Uytterhoeven
  2020-01-06  3:13 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-08-28 13:23 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd
  Cc: Raman Banka, linux-clk, linux-kernel, Geert Uytterhoeven

For testing, it is useful to be able to specify a clock rate manually.
As this is a dangerous feature, it is not enabled by default.
Users need to modify the source directly and #define
CLOCK_ALLOW_WRITE_DEBUGFS.

This follows the spirit of commit 09c6ecd394105c48 ("regmap: Add support
for writing to regmap registers via debugfs").

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Stephen: you suggested this approach in
https://lore.kernel.org/linux-clk/153029668040.143105.2059491089047180792@swboyd.mtv.corp.google.com/

v2:
  - Rebased.
---
 drivers/clk/clk.c | 38 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 2ba52b8dafcc1cc5..5b3c915b9507634c 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2990,6 +2990,41 @@ static int clk_dump_show(struct seq_file *s, void *data)
 }
 DEFINE_SHOW_ATTRIBUTE(clk_dump);
 
+#undef CLOCK_ALLOW_WRITE_DEBUGFS
+#ifdef CLOCK_ALLOW_WRITE_DEBUGFS
+/*
+ * This can be dangerous, therefore don't provide any real compile time
+ * configuration option for this feature.
+ * People who want to use this will need to modify the source code directly.
+ */
+static int clk_rate_set(void *data, u64 val)
+{
+	struct clk_core *core = data;
+	int ret;
+
+	clk_prepare_lock();
+	ret = clk_core_set_rate_nolock(core, val);
+	clk_prepare_unlock();
+
+	return ret;
+}
+
+#define clk_rate_mode	0644
+#else
+#define clk_rate_set	NULL
+#define clk_rate_mode	0444
+#endif
+
+static int clk_rate_get(void *data, u64 *val)
+{
+	struct clk_core *core = data;
+
+	*val = core->rate;
+	return 0;
+}
+
+DEFINE_DEBUGFS_ATTRIBUTE(clk_rate_fops, clk_rate_get, clk_rate_set, "%llu\n");
+
 static const struct {
 	unsigned long flag;
 	const char *name;
@@ -3139,7 +3174,8 @@ static void clk_debug_create_one(struct clk_core *core, struct dentry *pdentry)
 	root = debugfs_create_dir(core->name, pdentry);
 	core->dentry = root;
 
-	debugfs_create_ulong("clk_rate", 0444, root, &core->rate);
+	debugfs_create_file("clk_rate", clk_rate_mode, root, core,
+			    &clk_rate_fops);
 	debugfs_create_file("clk_min_rate", 0444, root, core, &clk_min_rate_fops);
 	debugfs_create_file("clk_max_rate", 0444, root, core, &clk_max_rate_fops);
 	debugfs_create_ulong("clk_accuracy", 0444, root, &core->accuracy);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] clk: Add support for setting clk_rate via debugfs
  2019-08-28 13:23 [PATCH v2] clk: Add support for setting clk_rate via debugfs Geert Uytterhoeven
@ 2020-01-06  3:13 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2020-01-06  3:13 UTC (permalink / raw)
  To: Geert Uytterhoeven, Michael Turquette
  Cc: Raman Banka, linux-clk, linux-kernel, Geert Uytterhoeven

Quoting Geert Uytterhoeven (2019-08-28 06:23:06)
> For testing, it is useful to be able to specify a clock rate manually.
> As this is a dangerous feature, it is not enabled by default.
> Users need to modify the source directly and #define
> CLOCK_ALLOW_WRITE_DEBUGFS.
> 
> This follows the spirit of commit 09c6ecd394105c48 ("regmap: Add support
> for writing to regmap registers via debugfs").
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Stephen: you suggested this approach in
> https://lore.kernel.org/linux-clk/153029668040.143105.2059491089047180792@swboyd.mtv.corp.google.com/

Ok. Let's do it!

Applied to clk-next.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-28 13:23 [PATCH v2] clk: Add support for setting clk_rate via debugfs Geert Uytterhoeven
2020-01-06  3:13 ` Stephen Boyd

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org
	public-inbox-index linux-clk

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git