From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9013AC32771 for ; Thu, 9 Jan 2020 10:56:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5527720656 for ; Thu, 9 Jan 2020 10:56:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="S0UUkW5E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729743AbgAIK4C (ORCPT ); Thu, 9 Jan 2020 05:56:02 -0500 Received: from mail-vi1eur05on2085.outbound.protection.outlook.com ([40.107.21.85]:6177 "EHLO EUR05-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729609AbgAIK4C (ORCPT ); Thu, 9 Jan 2020 05:56:02 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FKABXYGq4OjVd9qQ8DeAgvyTkH/chQmH7wuusZ4kKdNyAoDTI1WZS6cnq0+JLPKoi0lp18HmUJOcNFbWgeqHdxS1S/DonBQq5sNBUMvIBpgcgcuOfjIL8UpXHCb5+2w/cnU3BxppRsnnVGpoI0CHnScr84IIoWDVAJTcFBKvBQhYNAVfMDeoVWledYLdAVtt+n7ohndYHWHJcu0a6cvn6C8TT6LIaaiuzQ7/CU/SU3urBE5ZaFsk0h2IMcKK565If1gJ7+3Ffhu3iRgggCkETMOsEKoDp7PPOURzeDr/ZdheLediwAu8B6GkEp9fotyciXBd3OEqI+yhgDVp443LXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CgYlhc7Gk3rUevxUCFgtT1heqpCnClB+4mXI9JUawW0=; b=iqhQ9LAURgRI9v7ImsXJLZn45opy810tl2zzqqft4FdMwhPZ3+JVqG7XF/q8ZyNvGAd0RGq9KxYVNpel+oBYZm4FIgGMZvlKniopR8q2+k3c1MOWVG9UkTHasOHBP+A4sSUfO/GofRbPI+D11yHOLsWfOYycydzPnzoeMo2xAjBgEU2w4xl7CEaAM5Xb9CxacChp6wYh8UKU3uUjrw1t+VTygl6uBoaeCMtcYptk04V2YXj7o/ILIe+tOb51XJNbSlLY3nFGcxQnr1zC1W7aE1GwIyyK+IncElb039z9vbNUXshpgN7myUT+Ua1B8TYK8q28HxsDu1ot+maplD6nkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CgYlhc7Gk3rUevxUCFgtT1heqpCnClB+4mXI9JUawW0=; b=S0UUkW5EmXiQO9e2OK5vURpmvHil6g7uy32+btK8WFmZQSfUwgwB22CdE6nyvePmbxfhivKXWVm3dz1tXlYp8c614nM3eHUoFNuwKSbAmwhzBgv4YFkfQPw3sNc4FpBc2EyGnaqfjADb9+Ey7Sg0p/GUve72s9tNzyEnCbdzWEo= Received: from AM0PR04MB5779.eurprd04.prod.outlook.com (20.178.202.151) by AM0PR04MB6324.eurprd04.prod.outlook.com (20.179.34.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Thu, 9 Jan 2020 10:55:59 +0000 Received: from AM0PR04MB5779.eurprd04.prod.outlook.com ([fe80::6d52:5678:e02f:95f4]) by AM0PR04MB5779.eurprd04.prod.outlook.com ([fe80::6d52:5678:e02f:95f4%3]) with mapi id 15.20.2623.008; Thu, 9 Jan 2020 10:55:58 +0000 Received: from localhost (89.37.124.34) by AM6P193CA0091.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.10 via Frontend Transport; Thu, 9 Jan 2020 10:55:58 +0000 From: Abel Vesa To: Peng Fan CC: "sboyd@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , Leonard Crestez , "kernel@pengutronix.de" , dl-linux-imx , Aisheng Dong , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Anson Huang , Jacky Bai Subject: Re: [PATCH 0/4] clk: imx: imx8m: introduce imx8m_clk_hw_core_composite Thread-Topic: [PATCH 0/4] clk: imx: imx8m: introduce imx8m_clk_hw_core_composite Thread-Index: AQHVxtJpermqa5NGzEysq2aeSusjm6fiKRmA Date: Thu, 9 Jan 2020 10:55:58 +0000 Message-ID: <20200109105557.gntbgzj3efbqpjwf@fsr-ub1664-175> References: <1578563269-32710-1-git-send-email-peng.fan@nxp.com> In-Reply-To: <1578563269-32710-1-git-send-email-peng.fan@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P193CA0091.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::32) To AM0PR04MB5779.eurprd04.prod.outlook.com (2603:10a6:208:131::23) x-originating-ip: [89.37.124.34] authentication-results: spf=none (sender IP is ) smtp.mailfrom=abel.vesa@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 34a17818-7e82-4fd4-3f15-08d794f2825f x-ms-traffictypediagnostic: AM0PR04MB6324:|AM0PR04MB6324: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 02778BF158 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(376002)(39860400002)(366004)(136003)(346002)(396003)(189003)(199004)(6486002)(66476007)(66446008)(956004)(66556008)(5660300002)(66946007)(6496006)(81166006)(64756008)(53546011)(9686003)(478600001)(6862004)(4326008)(86362001)(8676002)(2906002)(186003)(16526019)(316002)(26005)(81156014)(44832011)(71200400001)(1076003)(8936002)(6636002)(33716001)(52116002)(54906003)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB6324;H:AM0PR04MB5779.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 36Hp7ZAkqORd9O5wSMZdQ7gojPvhAqgGRRyQr/uHSkUsUX1+wxqVNyPaVgrO/Dco9j/rOf1YyBZQCxMyzqTsrOy+KNZbEw17eNN2UXUHImFlShtEvrokiEna3CGFKf/UfCWwlK0TC36RuZf9rbQiPV6IjqKqP/RwaaGPLiNB2tQtijNJg0BClRBl4NznUciwyz/K79J1jRRpOMRv3Mj79bRn64DDO9v+jSK4fdIecO+iYrOyivXQq4k+t6XiFiLBakF2H1wRKkIY/WJ+BuyGa/0z2j6uBVaIxECmBreLTIIyirwo9WTJt5mClvKlWs7hjce8xooBLCwuH9DW3GyR5QL+tuKVtusCoKcHWC0ZFKxPbAa6/Bm+kfMDyOy9ZRF/ACN2X0NC29U+iZ6QQC/E5N/GRQUmN76zrpzmoeML4HsiPr/VEdEjhy5/b3Ewv7NNW1ry72yi6/0XAurUY0wIcfQp53oHx8puYYYouOl+mRGc9wGv2vdQYvn1IKBTmD6c Content-Type: text/plain; charset="us-ascii" Content-ID: <205F1779450AE149A9D3ED27732F1C2A@eurprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34a17818-7e82-4fd4-3f15-08d794f2825f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2020 10:55:58.8400 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XK9fcP4xxo3+CmZHwNgquuA8ByzqBMP6D4sqqbqBdcOlDa5CYC3Lk3AJqQIE486PBiRIiWVoCPxJYKbjgeNs+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6324 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 20-01-09 09:51:49, Peng Fan wrote: > From: Peng Fan >=20 > To i.MX8M family, there are different types of clock slices, > bus/core/ip and etc. Currently, the imx8m_clk_hw_composite > api could only handle bus and ip clock slice, it could > not handle core slice. The difference is core slice not have > pre divider and the width of post divider is 3 bits. >=20 > To simplify code and reuse imx8m_clk_hw_composite, introduce a > flag IMX_COMPOSITE_CORE to differentiate the slices. >=20 > With this new helper, we could simplify i.MX8M SoC clk drivers. >=20 I like the simplification this patchset adds, but maybe we should keep the extra flags (or clock types) at the end of the API, so=20 instead of imx8m_clk_hw_core_composite maybe we could use=20 imx8m_clk_hw_composite_core. Other than that: Reviewed-by: Abel Vesa > Peng Fan (4): > clk: imx: composite-8m: add imx8m_clk_hw_core_composite > clk: imx: imx8mq: use imx8m_clk_hw_core_composite > clk: imx: imx8mm: use imx8m_clk_hw_core_composite > clk: imx: imx8mn: use imx8m_clk_hw_core_composite >=20 > drivers/clk/imx/clk-composite-8m.c | 18 ++++++++++++++---- > drivers/clk/imx/clk-imx8mm.c | 17 +++++------------ > drivers/clk/imx/clk-imx8mn.c | 10 +++------- > drivers/clk/imx/clk-imx8mq.c | 19 +++++-------------- > drivers/clk/imx/clk.h | 12 ++++++++++-- > 5 files changed, 37 insertions(+), 39 deletions(-) >=20 > --=20 > 2.16.4 >=20