From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77AC9C2D0DB for ; Fri, 24 Jan 2020 18:10:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 523162081E for ; Fri, 24 Jan 2020 18:10:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qBvuvV0l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391321AbgAXSKO (ORCPT ); Fri, 24 Jan 2020 13:10:14 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:38122 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391313AbgAXSKO (ORCPT ); Fri, 24 Jan 2020 13:10:14 -0500 Received: by mail-pg1-f195.google.com with SMTP id a33so1517991pgm.5 for ; Fri, 24 Jan 2020 10:10:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XCBGGNYfBCH7BJ+03SsqW1OQE87yKFpYTbTUE1RoAwQ=; b=qBvuvV0l6KIYyI1A4wNqaCpgeumrMByqCRhV6J+4MdDnjpyoQ7IJLIHe6eeTK10d7T 2t4vbG7FzFfJ/+xt0hz9hxOxK2UxQU/K6/E9K7sSCLIUAwsP1niK523onHH0MXCgwwjv bPPLJPj+Gl+HOobYfJKl5vZXQ4ItmVuMG08rG70TbRuRxTSSdC/pj6NCjpDfmznCE786 cynelBzOuOv7atjjWYEOwAvk/RDjBrdUAuqR1weYJy5R1oNKU9UIY3OMHS/PaXkXNnah qJWjfGzYkEm03h5we+bE2L6CcXgrURuBZm8lw3RYTR8g+cWeR1wu1Pu4N127Jd8uAxly bXJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XCBGGNYfBCH7BJ+03SsqW1OQE87yKFpYTbTUE1RoAwQ=; b=Eh1i/wODAn79lX1nHqFhBouL8is9so7tCMivxVdqAUQsl2nY8vDM4Q/roPTH0EkKlL HxwDmja5o95rVrg9srlW+ULHlZV9rLMNX5NjOkIwQ7c8P8P8q4lvuTOJxx9XygGBj5ih IAeP6aiiF1IFvnXl5wG/hoW1gNOAnCcVa2ZDkveFnsKGR2n+B5RdjouHvQHCU5E1l9ZG dy2cz04+B1wTrylcg8X558S8EHCZwLMUiWFz2Uy9eli1kCzaLEpl1smKm+GHn+aaEjlj 67FPyB8s36/BXdhlob3DpxYnPD6B7xL2bd7w8O9JsXCLCi6ne0VV1og/803S6GPpfs9Q m0ww== X-Gm-Message-State: APjAAAXF/F54CB5XiVusa8v0tHIq/e+Or+sbKTMSDtX2IplOfOuvfNTh 21c47o9F2BmXbL9PmpALi5bcuQ== X-Google-Smtp-Source: APXvYqz4ohlIdCY5C9kjnkjMMUsZo9niHNmEV3zB/P+OU+UI93BPAv/WHs/K5fHbMO+pbfSsb+7wIQ== X-Received: by 2002:a62:4e42:: with SMTP id c63mr2158181pfb.86.1579889413402; Fri, 24 Jan 2020 10:10:13 -0800 (PST) Received: from ripper (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id m128sm7010476pfm.183.2020.01.24.10.10.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2020 10:10:12 -0800 (PST) Date: Fri, 24 Jan 2020 10:09:38 -0800 From: Bjorn Andersson To: Venkata Narendra Kumar Gutta Cc: agross@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, vinod.koul@linaro.org, psodagud@codeaurora.org, tsoni@codeaurora.org, jshriram@codeaurora.org, tdas@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] clk: qcom: rpmh: Add support for RPMH clocks on SM8250 Message-ID: <20200124180938.GQ1908628@ripper> References: <1579217994-22219-1-git-send-email-vnkgutta@codeaurora.org> <1579217994-22219-3-git-send-email-vnkgutta@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1579217994-22219-3-git-send-email-vnkgutta@codeaurora.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu 16 Jan 15:39 PST 2020, Venkata Narendra Kumar Gutta wrote: > From: Taniya Das > > Add support for RPMH clocks on SM8250. > > Signed-off-by: Taniya Das > Signed-off-by: Venkata Narendra Kumar Gutta > --- > drivers/clk/qcom/clk-rpmh.c | 25 ++++++++++++++++++++++++- > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c > index 593bfa4..0e45adf 100644 > --- a/drivers/clk/qcom/clk-rpmh.c > +++ b/drivers/clk/qcom/clk-rpmh.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved. > + * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved. > */ > > #include > @@ -404,6 +404,28 @@ static unsigned long clk_rpmh_bcm_recalc_rate(struct clk_hw *hw, > .num_clks = ARRAY_SIZE(sc7180_rpmh_clocks), > }; > > +DEFINE_CLK_RPMH_VRM(sm8250, ln_bb_clk1, ln_bb_clk1_ao, "lnbclka1", 2); > + > +static struct clk_hw *sm8250_rpmh_clocks[] = { > + [RPMH_CXO_CLK] = &sdm845_bi_tcxo.hw, > + [RPMH_CXO_CLK_A] = &sdm845_bi_tcxo_ao.hw, > + [RPMH_LN_BB_CLK1] = &sm8250_ln_bb_clk1.hw, > + [RPMH_LN_BB_CLK1_A] = &sm8250_ln_bb_clk1_ao.hw, > + [RPMH_LN_BB_CLK2] = &sdm845_ln_bb_clk2.hw, > + [RPMH_LN_BB_CLK2_A] = &sdm845_ln_bb_clk2_ao.hw, > + [RPMH_LN_BB_CLK3] = &sdm845_ln_bb_clk3.hw, > + [RPMH_LN_BB_CLK3_A] = &sdm845_ln_bb_clk3_ao.hw, > + [RPMH_RF_CLK1] = &sdm845_rf_clk1.hw, > + [RPMH_RF_CLK1_A] = &sdm845_rf_clk1_ao.hw, > + [RPMH_RF_CLK3] = &sdm845_rf_clk3.hw, > + [RPMH_RF_CLK3_A] = &sdm845_rf_clk3_ao.hw, > +}; > + > +static const struct clk_rpmh_desc clk_rpmh_sm8250 = { > + .clks = sm8250_rpmh_clocks, > + .num_clks = ARRAY_SIZE(sm8250_rpmh_clocks), > +}; > + > static struct clk_hw *of_clk_rpmh_hw_get(struct of_phandle_args *clkspec, > void *data) > { > @@ -490,6 +512,7 @@ static int clk_rpmh_probe(struct platform_device *pdev) > { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, > { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150}, > { .compatible = "qcom,sc7180-rpmh-clk", .data = &clk_rpmh_sc7180}, > + { .compatible = "qcom,sm8250-rpmh-clk", .data = &clk_rpmh_sm8250}, Double space before .data Apart from that Reviewed-by: Bjorn Andersson Regards, Bjorn > { } > }; > MODULE_DEVICE_TABLE(of, clk_rpmh_match_table); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project