From: Thierry Reding <thierry.reding@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Sowjanya Komatineni <skomatineni@nvidia.com>,
jonathanh@nvidia.com, frankc@nvidia.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1 0/5] Add Tegra driver for video capture
Date: Fri, 31 Jan 2020 18:03:51 +0100 [thread overview]
Message-ID: <20200131170351.GA3444092@ulmo> (raw)
In-Reply-To: <8654e6fd-c403-6e68-e5cf-09297b5d8b5d@xs4all.nl>
[-- Attachment #1: Type: text/plain, Size: 4740 bytes --]
On Fri, Jan 31, 2020 at 03:29:52PM +0100, Hans Verkuil wrote:
> On 1/30/20 4:42 PM, Thierry Reding wrote:
> > On Thu, Jan 30, 2020 at 03:41:50PM +0100, Hans Verkuil wrote:
> >> Hi Sowjanya,
> >>
> >> On 1/28/20 7:23 PM, Sowjanya Komatineni wrote:
> >>> This series adds Tegra210 VI and CSI driver for built-in test pattern
> >>> generator (TPG) capture.
> >>>
> >>> Tegra210 supports max 6 channels on VI and 6 ports on CSI where each
> >>> CSI port is one-to-one mapped to VI channel for video capture.
> >>>
> >>> This series has TPG support only where it creates hard media links
> >>> between CSI subdevice and VI video device without device graphs.
> >>>
> >>> v4l2-compliance results are available below the patch diff.
> >>>
> >>> [v0]: Includes,
> >>> - Adds CSI TPG clock to Tegra210 clock driver
> >>> - Host1x video driver with VI and CSI clients.
> >>> - Support for Tegra210 only.
> >>> - VI CSI TPG support with hard media links in driver.
> >>> - Video formats supported by Tegra210 VI
> >>> - CSI TPG supported video formats
> >>
> >> I'm trying to compile this patch series using the media_tree master
> >> branch (https://git.linuxtv.org//media_tree.git), but it fails:
> >>
> >> drivers/staging/media/tegra/tegra-channel.c: In function ‘tegra_channel_queue_setup’:
> >> drivers/staging/media/tegra/tegra-channel.c:71:15: warning: unused variable ‘count’ [-Wunused-variable]
> >> 71 | unsigned int count = *nbuffers;
> >> | ^~~~~
> >> drivers/staging/media/tegra/tegra-channel.c: In function ‘tegra_channel_init’:
> >> drivers/staging/media/tegra/tegra-channel.c:518:55: error: ‘struct host1x_client’ has no member named ‘host’
> >> 518 | struct tegra_camera *cam = dev_get_drvdata(vi->client.host);
> >> | ^
> >> make[4]: *** [scripts/Makefile.build:265: drivers/staging/media/tegra/tegra-channel.o] Error 1
> >> make[4]: *** Waiting for unfinished jobs....
> >> drivers/staging/media/tegra/tegra-vi.c: In function ‘tegra_vi_tpg_graph_init’:
> >> drivers/staging/media/tegra/tegra-vi.c:157:55: error: ‘struct host1x_client’ has no member named ‘host’
> >> 157 | struct tegra_camera *cam = dev_get_drvdata(vi->client.host);
> >> | ^
> >> drivers/staging/media/tegra/tegra-vi.c: In function ‘tegra_vi_init’:
> >> drivers/staging/media/tegra/tegra-csi.c: In function ‘tegra_csi_init’:
> >> drivers/staging/media/tegra/tegra-vi.c:213:51: error: ‘struct host1x_client’ has no member named ‘host’
> >> 213 | struct tegra_camera *cam = dev_get_drvdata(client->host);
> >> | ^~
> >> drivers/staging/media/tegra/tegra-csi.c:259:51: error: ‘struct host1x_client’ has no member named ‘host’
> >> 259 | struct tegra_camera *cam = dev_get_drvdata(client->host);
> >> | ^~
> >> drivers/staging/media/tegra/tegra-vi.c: In function ‘tegra_vi_exit’:
> >> drivers/staging/media/tegra/tegra-vi.c:246:51: error: ‘struct host1x_client’ has no member named ‘host’
> >> 246 | struct tegra_camera *cam = dev_get_drvdata(client->host);
> >> | ^~
> >> drivers/staging/media/tegra/tegra-csi.c: In function ‘tegra_csi_exit’:
> >> drivers/staging/media/tegra/tegra-csi.c:286:51: error: ‘struct host1x_client’ has no member named ‘host’
> >> 286 | struct tegra_camera *cam = dev_get_drvdata(client->host);
> >> | ^~
> >>
> >> And indeed, struct host1x_client as defined in include/linux/host1x.h doesn't
> >> have a 'host' field.
> >>
> >> Does this series depend on another patch that's not yet in mainline?
> >
> > Sowjanya's been working on top of linux-next, so, yes, this patch
> > depends on a change that's been merged into the DRM tree for v5.6-rc1.
> >
> > Thierry
> >
>
> Is there a specific linux-next tag that works? I tried next-20200131 but that
> failed to boot. Same problem with the mainline repo since the host1x patches
> were merged yesterday. It compiles fine, but the boot just stops. Or am I
> missing some kernel config that is now important to have?
linux-next and mainline are currently regressing on Tegra210 (and some
Tegra124) boards. I just sent out a series that fixes the regression for
me:
http://patchwork.ozlabs.org/project/linux-tegra/list/?series=156215
Please test if this works for you. If so, I'll send this to Dave as soon
as possible.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-31 17:04 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 18:23 [RFC PATCH v1 0/5] Add Tegra driver for video capture Sowjanya Komatineni
2020-01-28 18:23 ` [RFC PATCH v1 1/5] dt-bindings: clock: tegra: Add clk id for CSI TPG clock Sowjanya Komatineni
2020-02-05 19:23 ` Stephen Boyd
2020-01-28 18:23 ` [RFC PATCH v1 2/5] clk: tegra: Add Tegra210 CSI TPG clock gate Sowjanya Komatineni
2020-02-05 19:23 ` Stephen Boyd
2020-01-28 18:23 ` [RFC PATCH v1 3/5] dt-binding: tegra: Add VI and CSI bindings Sowjanya Komatineni
2020-01-28 20:32 ` Helen Koike
2020-01-28 21:04 ` Sowjanya Komatineni
2020-01-28 18:23 ` [RFC PATCH v1 4/5] media: tegra: Add Tegra Video input driver for Tegra210 Sowjanya Komatineni
[not found] ` <3cdea635-a9ca-7b9c-3c99-8f489f4d669a@collabora.com>
[not found] ` <162488d0-4e74-963a-3366-e4c1f7cf04ca@nvidia.com>
2020-01-29 0:49 ` Sowjanya Komatineni
2020-01-29 1:05 ` Helen Koike
2020-01-29 2:11 ` Sowjanya Komatineni
2020-01-29 5:59 ` Sowjanya Komatineni
2020-01-29 10:31 ` Helen Koike
2020-01-29 17:49 ` Sowjanya Komatineni
2020-01-29 18:15 ` Sowjanya Komatineni
2020-01-29 18:46 ` Helen Koike
2020-01-29 22:40 ` Sowjanya Komatineni
2020-01-29 18:29 ` Helen Koike
2020-01-29 18:46 ` Sowjanya Komatineni
2020-01-29 10:09 ` Thierry Reding
2020-01-29 16:25 ` Sowjanya Komatineni
2020-01-29 11:13 ` Thierry Reding
2020-01-29 17:23 ` Sowjanya Komatineni
2020-01-30 12:20 ` Thierry Reding
2020-01-30 17:02 ` Sowjanya Komatineni
2020-01-29 14:16 ` Hans Verkuil (hansverk)
2020-01-29 17:27 ` Sowjanya Komatineni
2020-01-30 14:45 ` Hans Verkuil
2020-02-05 19:26 ` Stephen Boyd
2020-02-05 19:54 ` Sowjanya Komatineni
2020-01-28 18:23 ` [RFC PATCH v1 5/5] arm64: tegra: Add Tegra VI CSI suppport in device tree Sowjanya Komatineni
2020-01-29 9:46 ` Thierry Reding
2020-01-29 16:22 ` Sowjanya Komatineni
2020-01-30 12:36 ` Thierry Reding
2020-01-30 17:18 ` Sowjanya Komatineni
2020-01-30 17:58 ` Thierry Reding
2020-01-30 18:58 ` Sowjanya Komatineni
2020-01-30 20:18 ` Sowjanya Komatineni
2020-01-31 2:57 ` Sowjanya Komatineni
2020-01-30 14:41 ` [RFC PATCH v1 0/5] Add Tegra driver for video capture Hans Verkuil
2020-01-30 15:42 ` Thierry Reding
2020-01-31 14:29 ` Hans Verkuil
2020-01-31 17:03 ` Thierry Reding [this message]
2020-01-31 17:37 ` Hans Verkuil
2020-01-31 20:31 ` Thierry Reding
2020-02-04 9:50 ` Hans Verkuil
2020-01-30 17:20 ` Sowjanya Komatineni
2020-02-04 12:53 ` Hans Verkuil
2020-02-04 16:42 ` Sowjanya Komatineni
2020-02-04 17:22 ` Hans Verkuil
2020-02-04 19:02 ` Sowjanya Komatineni
2020-02-05 7:57 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131170351.GA3444092@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frankc@nvidia.com \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=skomatineni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).