linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
	mark.rutland@arm.com, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	qi-ming.wu@intel.com, yixin.zhu@linux.intel.com,
	cheol.yong.kim@intel.com, rtanwar <rahul.tanwar@intel.com>
Subject: Re: [PATCH v5 2/2] clk: intel: Add CGU clock driver for a new SoC
Date: Tue, 3 Mar 2020 12:09:36 +0200	[thread overview]
Message-ID: <20200303100936.GL1224808@smile.fi.intel.com> (raw)
In-Reply-To: <12c16eb0-04aa-79cf-fa76-3f45b8972319@linux.intel.com>

On Tue, Mar 03, 2020 at 11:37:23AM +0800, Tanwar, Rahul wrote:
> On 27/2/2020 6:02 PM, Andy Shevchenko wrote:
> > On Thu, Feb 27, 2020 at 03:19:26PM +0800, Tanwar, Rahul wrote:
> >> On 19/2/2020 3:59 PM, Randy Dunlap wrote:
> >>> On 2/18/20 11:40 PM, Rahul Tanwar wrote:
> >>>
> >>>> +config CLK_LGM_CGU
> >>>> +	depends on (OF && HAS_IOMEM) || COMPILE_TEST
> >>> This "depends on" looks problematic to me. I guess we shall see when
> >>> all the build bots get to it.
> >> At the moment, i am not able to figure out possible problems in this..
> > COMPILE_TEST should be accompanied by non-generic dependency.
> > There is none.
> >
> > So, I quite agree with Randy.
> 
> I see COMPILE_TEST is mostly ORed with ARCH_xx. How about below?
> 
> depends on OF && HAS_IOMEM && (CONFIG_X86 || COMPILE_TEST)

How about to leave logical parts separately?
How is OF related to architecture?

On top of that, is this code only for x86 for sure?

> >>>> +	select OF_EARLY_FLATTREE
> >>> If OF is not set and HAS_IOMEM is not set, but COMPILE_TEST is set,
> >>> I expect that this should not be attempting to select OF_EARLY_FLATTREE.
> >>>
> >>> Have you tried such a config combination?
> >> Agree, that would be a problem. I will change it to
> >>
> >> select OF_EARLY_FLATTREE if OF
> > Nope, I think this is wrong work around.
> > See above.
> 
> With above proposed change, i can simply switch to
> select OF_EARLY_FLATTREE since all dependencies are already
> in place..

Right.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2020-03-03 10:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19  7:40 [PATCH v5 0/2] intel: Add a new driver for a new clock controller IP Rahul Tanwar
2020-02-19  7:40 ` [PATCH v5 1/2] dt-bindings: clk: intel: Add bindings document & header file for CGU Rahul Tanwar
2020-02-19  7:40 ` [PATCH v5 2/2] clk: intel: Add CGU clock driver for a new SoC Rahul Tanwar
2020-02-19  7:59   ` Randy Dunlap
2020-02-27  7:19     ` Tanwar, Rahul
2020-02-27 10:02       ` Andy Shevchenko
2020-03-03  3:37         ` Tanwar, Rahul
2020-03-03 10:09           ` Andy Shevchenko [this message]
2020-03-04  6:18             ` Tanwar, Rahul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303100936.GL1224808@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=cheol.yong.kim@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=qi-ming.wu@intel.com \
    --cc=rahul.tanwar@intel.com \
    --cc=rahul.tanwar@linux.intel.com \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=yixin.zhu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).