From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F007EC54E91 for ; Mon, 11 May 2020 22:54:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8E1C2075E for ; Mon, 11 May 2020 22:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589237685; bh=3AxgFNR3S9ZxYJWyxAj0+Wmud9QQaJnYR9wDCmPR1t8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2gJx4UmRHTVrcrM9w3qJNMkP3PT9EikxIXkERnEOg08uInyOCp7Wqo5MEaio5d+8i nm0y3qCVK3OrySb3pEoXRU9YkSSFUSqnWLuKm9mQBa8mg3ndZzrWAItSp9kRa40iMF yBh8Iq/TCJhDtqXYr290YVIVla0PS7LkSXDzZx44= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727889AbgEKWyk (ORCPT ); Mon, 11 May 2020 18:54:40 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:37181 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbgEKWyk (ORCPT ); Mon, 11 May 2020 18:54:40 -0400 Received: by mail-ot1-f66.google.com with SMTP id z17so8997517oto.4; Mon, 11 May 2020 15:54:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VizB9d53gOC/+qH9umA+7PsvczjrwT1z7CX57CjiKQc=; b=VsOLlDYlXN8nEjJmvIDWTA5+m9u2BGvjtTwJqHLYvjELUDOW2anwG5EnxilMyRC2VL KtLnNQUoVmAOa7sPmf1sva1ZsEBkY2SqHrh4DYVlf9h3XNzuor8RcIWL959iUP4zgdf1 4/VdYr4czdBIm+3TJMDwTsrH+havSVNeelKB52Ca84ugQc8OHGFnBVoFEahJC7cmM1Dc nFZumGGCnVImivsmsXSWZmnyWG56JCjZ8jzD1ur+mFZVZxmpYg1uSqh5Xz+Ihi2tWUxC CdmHVJDZX3G27WFML8EqIt6n98SKTyo69bYoX1TJD8FwMNRdI7Qb1ARQXrjqegZrOxuh Cfww== X-Gm-Message-State: AGi0Pub5Lz8RulPvj35saFb/hyjXch74GG7HbyJLDNnRO9P0NTmEf9aq ENcIzEJ4gUh+40ufyCCdgw== X-Google-Smtp-Source: APiQypKKLnsY+mi3s4XrlLCTUB04SAu7Bg8dIg/BXtQfuHvj8J8ILkc+35vvNiJCe8R8pqScwHrcDw== X-Received: by 2002:a9d:6d15:: with SMTP id o21mr14268200otp.184.1589237678420; Mon, 11 May 2020 15:54:38 -0700 (PDT) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l89sm2479578otc.32.2020.05.11.15.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 15:54:37 -0700 (PDT) Received: (nullmailer pid 2250 invoked by uid 1000); Mon, 11 May 2020 22:54:36 -0000 Date: Mon, 11 May 2020 17:54:36 -0500 From: Rob Herring To: Paul Cercueil Cc: od@zcrc.me, =?utf-8?B?5ZGo55Cw5p2w?= , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux-mtd@lists.infradead.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH 4/8] dt-bindings: memory: Convert ingenic,jz4780-nemc.txt to YAML Message-ID: <20200511225436.GB19685@bogus> References: <20200426185856.38826-1-paul@crapouillou.net> <20200426185856.38826-4-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200426185856.38826-4-paul@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Sun, Apr 26, 2020 at 08:58:52PM +0200, Paul Cercueil wrote: > Convert the ingenic,jz4780-nemc.txt doc file to ingenic,nemc.yaml. > > The ingenic,jz4725b-nemc compatible string was added in the process, > with a fallback to ingenic,jz4740-nemc. > > Signed-off-by: Paul Cercueil > --- > .../ingenic,jz4780-nemc.txt | 76 --------------- > .../ingenic,nemc-client.yaml | 45 +++++++++ > .../memory-controllers/ingenic,nemc.yaml | 95 +++++++++++++++++++ > 3 files changed, 140 insertions(+), 76 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/ingenic,jz4780-nemc.txt > create mode 100644 Documentation/devicetree/bindings/memory-controllers/ingenic,nemc-client.yaml > create mode 100644 Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml > > diff --git a/Documentation/devicetree/bindings/memory-controllers/ingenic,jz4780-nemc.txt b/Documentation/devicetree/bindings/memory-controllers/ingenic,jz4780-nemc.txt > deleted file mode 100644 > index 59b8dcc118ee..000000000000 > --- a/Documentation/devicetree/bindings/memory-controllers/ingenic,jz4780-nemc.txt > +++ /dev/null > @@ -1,76 +0,0 @@ > -* Ingenic JZ4780 NAND/external memory controller (NEMC) > - > -This file documents the device tree bindings for the NEMC external memory > -controller in Ingenic JZ4780 > - > -Required properties: > -- compatible: Should be set to one of: > - "ingenic,jz4740-nemc" (JZ4740) > - "ingenic,jz4780-nemc" (JZ4780) > -- reg: Should specify the NEMC controller registers location and length. > -- clocks: Clock for the NEMC controller. > -- #address-cells: Must be set to 2. > -- #size-cells: Must be set to 1. > -- ranges: A set of ranges for each bank describing the physical memory layout. > - Each should specify the following 4 integer values: > - > - 0 > - > -Each child of the NEMC node describes a device connected to the NEMC. > - > -Required child node properties: > -- reg: Should contain at least one register specifier, given in the following > - format: > - > - > - > - Multiple registers can be specified across multiple banks. This is needed, > - for example, for packaged NAND devices with multiple dies. Such devices > - should be grouped into a single node. > - > -Optional child node properties: > -- ingenic,nemc-bus-width: Specifies the bus width in bits. Defaults to 8 bits. > -- ingenic,nemc-tAS: Address setup time in nanoseconds. > -- ingenic,nemc-tAH: Address hold time in nanoseconds. > -- ingenic,nemc-tBP: Burst pitch time in nanoseconds. > -- ingenic,nemc-tAW: Access wait time in nanoseconds. > -- ingenic,nemc-tSTRV: Static memory recovery time in nanoseconds. > - > -If a child node references multiple banks in its "reg" property, the same value > -for all optional parameters will be configured for all banks. If any optional > -parameters are omitted, they will be left unchanged from whatever they are > -configured to when the NEMC device is probed (which may be the reset value as > -given in the hardware reference manual, or a value configured by the boot > -loader). > - > -Example (NEMC node with a NAND child device attached at CS1): > - > -nemc: nemc@13410000 { > - compatible = "ingenic,jz4780-nemc"; > - reg = <0x13410000 0x10000>; > - > - #address-cells = <2>; > - #size-cells = <1>; > - > - ranges = <1 0 0x1b000000 0x1000000 > - 2 0 0x1a000000 0x1000000 > - 3 0 0x19000000 0x1000000 > - 4 0 0x18000000 0x1000000 > - 5 0 0x17000000 0x1000000 > - 6 0 0x16000000 0x1000000>; > - > - clocks = <&cgu JZ4780_CLK_NEMC>; > - > - nand: nand@1 { > - compatible = "ingenic,jz4780-nand"; > - reg = <1 0 0x1000000>; > - > - ingenic,nemc-tAS = <10>; > - ingenic,nemc-tAH = <5>; > - ingenic,nemc-tBP = <10>; > - ingenic,nemc-tAW = <15>; > - ingenic,nemc-tSTRV = <100>; > - > - ... > - }; > -}; > diff --git a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc-client.yaml b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc-client.yaml > new file mode 100644 > index 000000000000..682e6f7e74fa > --- /dev/null > +++ b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc-client.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/memory-controllers/ingenic,nemc-client.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: > + Ingenic SoCs NAND / External Memory Controller (NEMC) > + client-specific properties > + > +maintainers: > + - Paul Cercueil > + > +description: > + This document lists the various properties that child nodes of the NEMC node > + can use. > + > +properties: What about 'reg'? That should be required. > + ingenic,nemc-bus-width: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - enum: [8, 16] > + description: Specifies the bus width in bits. > + > + ingenic,nemc-tAS: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Address setup time in nanoseconds. > + > + ingenic,nemc-tAH: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Address hold time in nanoseconds. > + > + ingenic,nemc-tBP: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Burst pitch time in nanoseconds. > + > + ingenic,nemc-tAW: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Address wait time in nanoseconds. > + > + ingenic,nemc-tSTRV: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Static memory recovery time in nanoseconds. I think I'd just combine this into 1 file. > + > +... > diff --git a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml > new file mode 100644 > index 000000000000..c7fd28462fd8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml > @@ -0,0 +1,95 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/memory-controllers/ingenic,nemc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ingenic SoCs NAND / External Memory Controller (NEMC) devicetree bindings > + > +maintainers: > + - Paul Cercueil > + > +properties: > + $nodename: > + pattern: "^memory-controller@[0-9a-f]+$" > + > + compatible: > + oneOf: > + - enum: > + - ingenic,jz4740-nemc > + - ingenic,jz4780-nemc > + - items: > + - const: ingenic,jz4725b-nemc > + - const: ingenic,jz4740-nemc > + > + "#address-cells": > + const: 2 > + > + "#size-cells": > + const: 1 > + > + ranges: true > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +patternProperties: > + "^(nand-controller|ethernet)@[0-9]+$": Presumably you could have other types of child nodes? > + type: object > + allOf: > + - $ref: ingenic,nemc-client.yaml# > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + - ranges > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + nemc: memory-controller@13410000 { > + compatible = "ingenic,jz4780-nemc"; > + reg = <0x13410000 0x10000>; > + #address-cells = <2>; > + #size-cells = <1>; > + ranges = <1 0 0x1b000000 0x1000000>, > + <2 0 0x1a000000 0x1000000>, > + <3 0 0x19000000 0x1000000>, > + <4 0 0x18000000 0x1000000>, > + <5 0 0x17000000 0x1000000>, > + <6 0 0x16000000 0x1000000>; > + > + clocks = <&cgu JZ4780_CLK_NEMC>; > + > + ethernet@6 { > + compatible = "davicom,dm9000"; > + davicom,no-eeprom; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pins_nemc_cs6>; > + > + reg = <6 0 1>, /* addr */ > + <6 2 1>; /* data */ > + > + ingenic,nemc-tAS = <15>; > + ingenic,nemc-tAH = <10>; > + ingenic,nemc-tBP = <20>; > + ingenic,nemc-tAW = <50>; > + ingenic,nemc-tSTRV = <100>; > + > + reset-gpios = <&gpf 12 GPIO_ACTIVE_HIGH>; > + vcc-supply = <ð0_power>; > + > + interrupt-parent = <&gpe>; > + interrupts = <19 4>; > + }; > + }; > -- > 2.26.2 >