Hi Tiezhu, Thank you for the patch! Yet something to improve: [auto build test ERROR on clk/clk-next] [also build test ERROR on v5.7-rc7 next-20200526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Tiezhu-Yang/clk-hisilicon-Use-correct-return-value-about-hisi_reset_init/20200525-113342 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: i386-tinyconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>, old ones prefixed by <<): ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_fixed_rate': >> clk.c:(.text+0x9e): undefined reference to `clk_register_fixed_rate' >> ld: clk.c:(.text+0xdf): undefined reference to `clk_unregister_fixed_rate' ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_fixed_factor': >> clk.c:(.text+0x117): undefined reference to `clk_register_fixed_factor' >> ld: clk.c:(.text+0x158): undefined reference to `clk_unregister_fixed_factor' ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_mux': >> clk.c:(.text+0x1cb): undefined reference to `clk_register_mux_table' >> ld: clk.c:(.text+0x1f2): undefined reference to `clk_register_clkdev' >> ld: clk.c:(.text+0x21a): undefined reference to `clk_unregister_mux' ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_divider': >> clk.c:(.text+0x2c9): undefined reference to `clk_register_divider_table' ld: clk.c:(.text+0x2e3): undefined reference to `clk_register_clkdev' >> ld: clk.c:(.text+0x311): undefined reference to `clk_unregister_divider' ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_gate': >> clk.c:(.text+0x36c): undefined reference to `clk_register_gate' ld: clk.c:(.text+0x393): undefined reference to `clk_register_clkdev' >> ld: clk.c:(.text+0x3bb): undefined reference to `clk_unregister_gate' ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_gate_sep': >> clk.c:(.text+0x425): undefined reference to `clk_register_clkdev' ld: drivers/clk/hisilicon/clk.o: in function `hi6220_clk_register_divider': >> clk.c:(.init.text+0x5d): undefined reference to `clk_register_clkdev' ld: drivers/clk/hisilicon/clkgate-separated.o: in function `hisi_register_clkgate_sep': >> clkgate-separated.c:(.text+0xf0): undefined reference to `clk_register' ld: drivers/clk/hisilicon/clkdivider-hi6220.o: in function `hi6220_clkdiv_set_rate': >> clkdivider-hi6220.c:(.text+0x16): undefined reference to `divider_get_val' ld: drivers/clk/hisilicon/clkdivider-hi6220.o: in function `hi6220_clkdiv_recalc_rate': >> clkdivider-hi6220.c:(.text+0x8a): undefined reference to `divider_recalc_rate' ld: drivers/clk/hisilicon/clkdivider-hi6220.o: in function `hi6220_clkdiv_round_rate': >> clkdivider-hi6220.c:(.text+0xa9): undefined reference to `clk_hw_get_parent' >> ld: clkdivider-hi6220.c:(.text+0xbd): undefined reference to `divider_round_rate_parent' ld: drivers/clk/hisilicon/clkdivider-hi6220.o: in function `hi6220_register_clkdiv': >> clkdivider-hi6220.c:(.text+0x1c5): undefined reference to `clk_register' ld: drivers/clk/hisilicon/clk-hisi-phase.o: in function `clk_register_hisi_phase': >> clk-hisi-phase.c:(.text+0x121): undefined reference to `devm_clk_register' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org