* Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding
2020-06-26 11:54 [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding Maxime Ripard
@ 2020-06-26 16:03 ` Florian Fainelli
2020-07-15 20:06 ` Rob Herring
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Florian Fainelli @ 2020-06-26 16:03 UTC (permalink / raw)
To: Maxime Ripard, Nicolas Saenz Julienne, Mike Turquette, Stephen Boyd
Cc: linux-rpi-kernel, bcm-kernel-feedback-list, linux-clk,
Mark Rutland, Rob Herring, Frank Rowand, devicetree
On 6/26/2020 4:54 AM, Maxime Ripard wrote:
> The RaspberryPi firmware binding uses two compatible, include simple-bus.
> The select statement generated by default will thus select any node that
> has simple-bus, not all of them being the raspberrypi firmware node.
>
> This results in warnings being wrongfully reported. Let's add a custom
> select statement to fix that.
>
> Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks Maxime!
--
Florian
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding
2020-06-26 11:54 [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding Maxime Ripard
2020-06-26 16:03 ` Florian Fainelli
@ 2020-07-15 20:06 ` Rob Herring
2020-07-23 15:44 ` Maxime Ripard
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2020-07-15 20:06 UTC (permalink / raw)
To: Maxime Ripard
Cc: Nicolas Saenz Julienne, Mike Turquette, Stephen Boyd,
linux-rpi-kernel, bcm-kernel-feedback-list, linux-clk,
Mark Rutland, Frank Rowand, devicetree, Florian Fainelli
On Fri, Jun 26, 2020 at 01:54:33PM +0200, Maxime Ripard wrote:
> The RaspberryPi firmware binding uses two compatible, include simple-bus.
> The select statement generated by default will thus select any node that
> has simple-bus, not all of them being the raspberrypi firmware node.
>
> This results in warnings being wrongfully reported. Let's add a custom
> select statement to fix that.
>
> Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> ---
>
> The original binding has been merged through the clock tree, so it should
> be merged there.
>
> Even though the original binding (and the DT) are using the simple-bus
> compatible, this creates some DTC warnings since the firmware really isn't
> a bus, so the node name doesn't match what a bus should have, none of the
> children have a reg property, #address-cells and #size-cells are missing,
> etc.
>
> I can only guess that simple-bus was used to make the sub-devices probe,
> but maybe simple-mfd would be more appropriate here?
As these are not mmio devices, I think simple-mfd is better.
> ---
> .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> index b48ed875eb8e..17e4f20c8d39 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> @@ -10,6 +10,15 @@ maintainers:
> - Eric Anholt <eric@anholt.net>
> - Stefan Wahren <wahrenst@gmx.net>
>
> +select:
> + properties:
> + compatible:
> + contains:
> + const: raspberrypi,bcm2835-firmware
> +
> + required:
> + - compatible
> +
> properties:
> compatible:
> items:
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding
2020-06-26 11:54 [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding Maxime Ripard
2020-06-26 16:03 ` Florian Fainelli
2020-07-15 20:06 ` Rob Herring
@ 2020-07-23 15:44 ` Maxime Ripard
2020-07-23 20:04 ` Rob Herring
2020-07-23 22:02 ` Stephen Boyd
2020-07-23 22:33 ` Stephen Boyd
2020-07-23 22:45 ` Stephen Boyd
4 siblings, 2 replies; 10+ messages in thread
From: Maxime Ripard @ 2020-07-23 15:44 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Mike Turquette, Stephen Boyd
Cc: linux-rpi-kernel, bcm-kernel-feedback-list, linux-clk,
Mark Rutland, Rob Herring, Frank Rowand, devicetree,
Florian Fainelli
Hi Stephen, Mike,
On Fri, Jun 26, 2020 at 01:54:33PM +0200, Maxime Ripard wrote:
> The RaspberryPi firmware binding uses two compatible, include simple-bus.
> The select statement generated by default will thus select any node that
> has simple-bus, not all of them being the raspberrypi firmware node.
>
> This results in warnings being wrongfully reported. Let's add a custom
> select statement to fix that.
>
> Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> ---
>
> The original binding has been merged through the clock tree, so it should
> be merged there.
Could you apply that patch to clk-next?
Thanks!
Maxime
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding
2020-07-23 15:44 ` Maxime Ripard
@ 2020-07-23 20:04 ` Rob Herring
2020-07-23 22:02 ` Stephen Boyd
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2020-07-23 20:04 UTC (permalink / raw)
To: Maxime Ripard, Stephen Boyd
Cc: Nicolas Saenz Julienne, Mike Turquette,
moderated list:BROADCOM BCM2835 ARM ARCHITECTURE,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, linux-clk,
Mark Rutland, Frank Rowand, devicetree, Florian Fainelli
On Thu, Jul 23, 2020 at 9:44 AM Maxime Ripard <maxime@cerno.tech> wrote:
>
> Hi Stephen, Mike,
>
> On Fri, Jun 26, 2020 at 01:54:33PM +0200, Maxime Ripard wrote:
> > The RaspberryPi firmware binding uses two compatible, include simple-bus.
> > The select statement generated by default will thus select any node that
> > has simple-bus, not all of them being the raspberrypi firmware node.
> >
> > This results in warnings being wrongfully reported. Let's add a custom
> > select statement to fix that.
> >
> > Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> >
> > ---
> >
> > The original binding has been merged through the clock tree, so it should
> > be merged there.
>
> Could you apply that patch to clk-next?
While I said 'simple-mfd' would be more appropriate, that's a separate
issue I guess, so:
Acked-by: Rob Herring <robh@kernel.org>
BTW, qcom,msm8996-apcc.yaml is also breaking linux-next.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding
2020-07-23 15:44 ` Maxime Ripard
2020-07-23 20:04 ` Rob Herring
@ 2020-07-23 22:02 ` Stephen Boyd
1 sibling, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2020-07-23 22:02 UTC (permalink / raw)
To: Maxime Ripard, Mike Turquette, Nicolas Saenz Julienne
Cc: linux-rpi-kernel, bcm-kernel-feedback-list, linux-clk,
Mark Rutland, Rob Herring, Frank Rowand, devicetree,
Florian Fainelli
Quoting Maxime Ripard (2020-07-23 08:44:21)
> Hi Stephen, Mike,
>
> On Fri, Jun 26, 2020 at 01:54:33PM +0200, Maxime Ripard wrote:
> > The RaspberryPi firmware binding uses two compatible, include simple-bus.
> > The select statement generated by default will thus select any node that
> > has simple-bus, not all of them being the raspberrypi firmware node.
> >
> > This results in warnings being wrongfully reported. Let's add a custom
> > select statement to fix that.
> >
> > Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> >
> > ---
> >
> > The original binding has been merged through the clock tree, so it should
> > be merged there.
>
> Could you apply that patch to clk-next?
>
Rob has an unresolved comment on this patch.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding
2020-06-26 11:54 [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding Maxime Ripard
` (2 preceding siblings ...)
2020-07-23 15:44 ` Maxime Ripard
@ 2020-07-23 22:33 ` Stephen Boyd
2020-07-23 22:45 ` Stephen Boyd
4 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2020-07-23 22:33 UTC (permalink / raw)
To: Maxime Ripard, Mike Turquette, Nicolas Saenz Julienne
Cc: linux-rpi-kernel, bcm-kernel-feedback-list, linux-clk,
Mark Rutland, Rob Herring, Frank Rowand, devicetree,
Florian Fainelli, Maxime Ripard
Quoting Maxime Ripard (2020-06-26 04:54:33)
> The RaspberryPi firmware binding uses two compatible, include simple-bus.
> The select statement generated by default will thus select any node that
> has simple-bus, not all of them being the raspberrypi firmware node.
>
> This results in warnings being wrongfully reported. Let's add a custom
> select statement to fix that.
>
> Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> ---
Applied to clk-next but I had to fix the fixes tag.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding
2020-06-26 11:54 [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding Maxime Ripard
` (3 preceding siblings ...)
2020-07-23 22:33 ` Stephen Boyd
@ 2020-07-23 22:45 ` Stephen Boyd
2020-07-27 15:52 ` Maxime Ripard
4 siblings, 1 reply; 10+ messages in thread
From: Stephen Boyd @ 2020-07-23 22:45 UTC (permalink / raw)
To: Maxime Ripard, Mike Turquette, Nicolas Saenz Julienne
Cc: linux-rpi-kernel, bcm-kernel-feedback-list, linux-clk,
Mark Rutland, Rob Herring, Frank Rowand, devicetree,
Florian Fainelli, Maxime Ripard
Quoting Maxime Ripard (2020-06-26 04:54:33)
> The RaspberryPi firmware binding uses two compatible, include simple-bus.
> The select statement generated by default will thus select any node that
> has simple-bus, not all of them being the raspberrypi firmware node.
>
> This results in warnings being wrongfully reported. Let's add a custom
> select statement to fix that.
>
> Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> ---
>
> The original binding has been merged through the clock tree, so it should
> be merged there.
>
> Even though the original binding (and the DT) are using the simple-bus
> compatible, this creates some DTC warnings since the firmware really isn't
> a bus, so the node name doesn't match what a bus should have, none of the
> children have a reg property, #address-cells and #size-cells are missing,
> etc.
>
> I can only guess that simple-bus was used to make the sub-devices probe,
> but maybe simple-mfd would be more appropriate here?
> ---
> .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
Hmm. I'm still seeing warnings.
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dts:23.37-26.15: Warning (simple_bus_reg): /example-0/firmware/clocks: missing or emp
ty reg/ranges property
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: $nodename:0: 'firmware' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#address-cells' is a required property
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#size-cells' is a required property
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: 'ranges' is a required property
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding
2020-07-23 22:45 ` Stephen Boyd
@ 2020-07-27 15:52 ` Maxime Ripard
2020-07-27 19:39 ` Stephen Boyd
0 siblings, 1 reply; 10+ messages in thread
From: Maxime Ripard @ 2020-07-27 15:52 UTC (permalink / raw)
To: Stephen Boyd
Cc: Mike Turquette, Nicolas Saenz Julienne, linux-rpi-kernel,
bcm-kernel-feedback-list, linux-clk, Mark Rutland, Rob Herring,
Frank Rowand, devicetree, Florian Fainelli
[-- Attachment #1: Type: text/plain, Size: 2343 bytes --]
On Thu, Jul 23, 2020 at 03:45:48PM -0700, Stephen Boyd wrote:
> Quoting Maxime Ripard (2020-06-26 04:54:33)
> > The RaspberryPi firmware binding uses two compatible, include simple-bus.
> > The select statement generated by default will thus select any node that
> > has simple-bus, not all of them being the raspberrypi firmware node.
> >
> > This results in warnings being wrongfully reported. Let's add a custom
> > select statement to fix that.
> >
> > Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> >
> > ---
> >
> > The original binding has been merged through the clock tree, so it should
> > be merged there.
> >
> > Even though the original binding (and the DT) are using the simple-bus
> > compatible, this creates some DTC warnings since the firmware really isn't
> > a bus, so the node name doesn't match what a bus should have, none of the
> > children have a reg property, #address-cells and #size-cells are missing,
> > etc.
> >
> > I can only guess that simple-bus was used to make the sub-devices probe,
> > but maybe simple-mfd would be more appropriate here?
> > ---
> > .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 9 +++++++++
> > 1 file changed, 9 insertions(+)
>
> Hmm. I'm still seeing warnings.
>
> Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dts:23.37-26.15: Warning (simple_bus_reg): /example-0/firmware/clocks: missing or emp
> ty reg/ranges property
> Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: $nodename:0: 'firmware' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
> Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#address-cells' is a required property
> Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#size-cells' is a required property
> Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: 'ranges' is a required property
Yeah, those are the warnings related to the issue we were discussing
with Rob. The patch should fix an hard error.
I'll send a followup patch for the warnings.
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding
2020-07-27 15:52 ` Maxime Ripard
@ 2020-07-27 19:39 ` Stephen Boyd
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2020-07-27 19:39 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mike Turquette, Nicolas Saenz Julienne, linux-rpi-kernel,
bcm-kernel-feedback-list, linux-clk, Mark Rutland, Rob Herring,
Frank Rowand, devicetree, Florian Fainelli
Quoting Maxime Ripard (2020-07-27 08:52:32)
> On Thu, Jul 23, 2020 at 03:45:48PM -0700, Stephen Boyd wrote:
> > Quoting Maxime Ripard (2020-06-26 04:54:33)
> > > The RaspberryPi firmware binding uses two compatible, include simple-bus.
> > > The select statement generated by default will thus select any node that
> > > has simple-bus, not all of them being the raspberrypi firmware node.
> > >
> > > This results in warnings being wrongfully reported. Let's add a custom
> > > select statement to fix that.
> > >
> > > Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
> > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > >
> > > ---
> > >
> > > The original binding has been merged through the clock tree, so it should
> > > be merged there.
> > >
> > > Even though the original binding (and the DT) are using the simple-bus
> > > compatible, this creates some DTC warnings since the firmware really isn't
> > > a bus, so the node name doesn't match what a bus should have, none of the
> > > children have a reg property, #address-cells and #size-cells are missing,
> > > etc.
> > >
> > > I can only guess that simple-bus was used to make the sub-devices probe,
> > > but maybe simple-mfd would be more appropriate here?
> > > ---
> > > .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 9 +++++++++
> > > 1 file changed, 9 insertions(+)
> >
> > Hmm. I'm still seeing warnings.
> >
> > Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dts:23.37-26.15: Warning (simple_bus_reg): /example-0/firmware/clocks: missing or emp
> > ty reg/ranges property
> > Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: $nodename:0: 'firmware' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
> > Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#address-cells' is a required property
> > Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#size-cells' is a required property
> > Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: 'ranges' is a required property
>
> Yeah, those are the warnings related to the issue we were discussing
> with Rob. The patch should fix an hard error.
>
> I'll send a followup patch for the warnings.
Ah ok. Let me merge it up now.
^ permalink raw reply [flat|nested] 10+ messages in thread