From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D045CC433DF for ; Sat, 11 Jul 2020 19:49:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6F632078B for ; Sat, 11 Jul 2020 19:49:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kuzkh7Dy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbgGKTt7 (ORCPT ); Sat, 11 Jul 2020 15:49:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbgGKTt6 (ORCPT ); Sat, 11 Jul 2020 15:49:58 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7A9FC08C5DD for ; Sat, 11 Jul 2020 12:49:58 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id k4so3613433pld.12 for ; Sat, 11 Jul 2020 12:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VoSY9o0RP9wz1n1HlqTdIGycNdQ3hE09iYAJAJNhPFo=; b=kuzkh7Dyi7gvfKHgz0jDxv9ItbDA51VPP8+B5RL67FMOAvkA7sCXY4mkhOD+fGVr1r mv8MlJQnOxtcff2aUtBQEqxn4dYEW2qXEyT4uq7I40BtRfTGXnkfS6hCzl+7Hy8b1nS5 B4aP39WQ6DgfKtxK8Hs02ijiAFb6wGHnwJlyMEfxhfKcYWssU3ZkvshdRuk/2no0gAWW rVUvCjAAEOE/RxT5XeZFwnd43ey7L3prJc6BmWh8F3ZXqohoPl6dO+gMg4REiJHoT5ld 7iXIFj86iz5L67nqqOwmbrczbF1jGkG+fsiiQHkDFdBHtlNd1a7loILLtxTwGUVlSGyu 97FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VoSY9o0RP9wz1n1HlqTdIGycNdQ3hE09iYAJAJNhPFo=; b=mlV8d3Q/snngGhwc1AIh3OQRXPG0wQIV3kCDFbqE7/O2F3sJIo5mqkTOpBFDE+at71 OnK9zVdZ3JfJyxBFBxd2PcVvY1rjZS86dwsCvcJDAOQ8uIcoiB/gurajuYaqsZJ6apbE fLPLqvrnTAMC2iJKhOt9FTkD3bonmiOmGpvilu74Rb4QmJnPMRTVpI1aA6UwetYxEEne eQ1KmsMFpARJx2XMbMl8Q9q4DEnL6SWyqg2RlWnnWtRtBIb0YxJtz7aNe13AMgc65X4w NMP/jR47X5d9ZLWO9HYtykBkvqecuS0OWLFSbL5/lTrt8Na084324zBaH9jZA1d8kQK/ NXag== X-Gm-Message-State: AOAM532WgYVPW2qT35I1r+QvaMokPpE4LactxYUUYSZdiZFfiKcMoF3O pAwt1+kfsI6Bj65ZWG54UmLdyA== X-Google-Smtp-Source: ABdhPJwyVIyKI7ahlCr2xE9CjEH3oiM3zspFL3y25paZ20lnVu1lQeX2s576mVzYp98W3z0Gb3TFxg== X-Received: by 2002:a17:902:d352:: with SMTP id l18mr21833035plk.56.1594496998213; Sat, 11 Jul 2020 12:49:58 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id b4sm9665353pfo.137.2020.07.11.12.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2020 12:49:57 -0700 (PDT) Date: Sat, 11 Jul 2020 12:47:46 -0700 From: Bjorn Andersson To: Stephen Boyd Cc: Konrad Dybcio , skrzynka@konradybcio.pl, Andy Gross , Michael Turquette , Rob Herring , linux-arm-msm , linux-clk@vger.kernel.org, DTML , Linux Kernel Mailing List Subject: Re: [PATCH 1/1] clk: qcom: smd: Add support for MSM8992/4 rpm clocks Message-ID: <20200711194746.GA388985@builder.lan> References: <20200623230018.303776-1-konradybcio@gmail.com> <159303797640.62212.15039388585433005717@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159303797640.62212.15039388585433005717@swboyd.mtv.corp.google.com> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Wed 24 Jun 15:32 PDT 2020, Stephen Boyd wrote: > Quoting Konrad Dybcio (2020-06-24 08:09:18) > > I should also note that for quite some time a hack [1] > > has been needed on some platforms for the RPMCC to register. > > > > This includes 8992/94, 8956/76 and possibly many more. > > > > With that commit, RPMCC registers fine. > > > > What happens if that patch isn't applied? Does the system crash? Because > I'd rather not merge a patch in clk tree that causes the system to fail > to boot. The state machine code in the SMD implementation finds the RPM channel, but it's in a state that indicates that the remote side is still closing/cleaning up from when the bootloader had it open. The result is that we never probe the RPM driver. I merged a patch that would cause the logic here to be a little bit more aggressive/optimistic, but that had to be reverted because it prevented the modem from coming up cleanly after a crash. And I unfortunately still don't have any hardware that manifest this problem that I can debug this on myself. But I think it's fine to merge the rpmcc patch (which I see you did). Thanks, Bjorn