From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4E7BC2D0A3 for ; Tue, 10 Nov 2020 01:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E0EE2078D for ; Tue, 10 Nov 2020 01:55:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JOTX/j7j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730921AbgKJBzF (ORCPT ); Mon, 9 Nov 2020 20:55:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:35702 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729874AbgKJBzE (ORCPT ); Mon, 9 Nov 2020 20:55:04 -0500 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 30F93206B2; Tue, 10 Nov 2020 01:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604973304; bh=GCFhXse/e+ZHjphqwvgogigFqAMfjhABvI4EMREDYXU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JOTX/j7jI9fupke2UYQDX2P0QVnZO3m/2ZF0mxiFarFy7ODm9CRGTbloEWUDOs7au p4gyF/NoRIQJHh696pl8eFoHV20KdzId7NwzorXPJUdp2m2LE4kF3J2Q+pIU2IhAdh KmCiFPsn4Qh2DDObg3pwPAh4ZAZ+h2703wPc8lq8= Date: Tue, 10 Nov 2020 09:54:57 +0800 From: Shawn Guo To: Krzysztof Kozlowski Cc: Michael Turquette , Stephen Boyd , Sudeep Holla , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Geert Uytterhoeven , Peng Fan , Abel Vesa , Anson Huang , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 5/8] clk: imx8mq: drop of_match_ptr from of_device_id table Message-ID: <20201110015457.GP31601@dragon> References: <20201103162435.13689-1-krzk@kernel.org> <20201103162435.13689-5-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201103162435.13689-5-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, Nov 03, 2020 at 05:24:32PM +0100, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might be not relevant here). This > fixes compile warning (!CONFIG_OF && !CONFIG_MODULES): > > drivers/clk/imx/clk-imx8mq.c:626:34: warning: > ‘imx8mq_clk_of_match’ defined but not used [-Wunused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski Applied, thanks.