From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: PowerPC <linuxppc-dev@lists.ozlabs.org>,
Nicholas Piggin <npiggin@gmail.com>,
Daniel Axtens <dja@axtens.net>, Joel Stanley <joel@jms.id.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
<linux-renesas-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: [PATCH] powerpc: fix the allyesconfig build
Date: Sat, 28 Nov 2020 12:28:19 +1100 [thread overview]
Message-ID: <20201128122819.32187696@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 2571 bytes --]
There are 2 drivers that have arrays of packed structures that contain
pointers that end up at unaligned offsets. These produce warnings in
the PowerPC allyesconfig build like this:
WARNING: 148 bad relocations
c00000000e56510b R_PPC64_UADDR64 .rodata+0x0000000001c72378
c00000000e565126 R_PPC64_UADDR64 .rodata+0x0000000001c723c0
They are not drivers that are used on PowerPC (I assume), so mark them
to not be built on PPC64 when CONFIG_RELOCATABLE is enabled.
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Daniel Axtens <dja@axtens.net>
Cc: Joel Stanley <joel@jms.id.au>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/clk/renesas/Kconfig | 4 ++++
drivers/net/ethernet/hisilicon/Kconfig | 4 ++++
2 files changed, 8 insertions(+)
It might be easiest to put this through the PowerPC (fixes?) tree, if
people woulf just sned ACKs, please?
diff --git a/drivers/clk/renesas/Kconfig b/drivers/clk/renesas/Kconfig
index 18915d668a30..53f24a0cad7a 100644
--- a/drivers/clk/renesas/Kconfig
+++ b/drivers/clk/renesas/Kconfig
@@ -151,6 +151,10 @@ config CLK_R8A779A0
select CLK_RENESAS_CPG_MSSR
config CLK_R9A06G032
+ # PPC64 RELOCATABLE kernels cannot handle relocations to
+ # unaligned locations that are produced by the array of
+ # packed structures in this driver.
+ depends on !(PPC64 && RELOCATABLE)
bool "Renesas R9A06G032 clock driver"
help
This is a driver for R9A06G032 clocks
diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
index 44f9279cdde1..bf47e504b365 100644
--- a/drivers/net/ethernet/hisilicon/Kconfig
+++ b/drivers/net/ethernet/hisilicon/Kconfig
@@ -102,6 +102,10 @@ config HNS3_HCLGE
tristate "Hisilicon HNS3 HCLGE Acceleration Engine & Compatibility Layer Support"
default m
depends on PCI_MSI
+ # PPC64 RELOCATABLE kernels cannot handle relocations to
+ # unaligned locations that are produced by the array of
+ # packed structures in this driver.
+ depends on !(PPC64 && RELOCATABLE)
help
This selects the HNS3_HCLGE network acceleration engine & its hardware
compatibility layer. The engine would be used in Hisilicon hip08 family of
--
2.29.2
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2020-11-28 1:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 1:28 Stephen Rothwell [this message]
2020-11-28 1:56 ` [PATCH] powerpc: fix the allyesconfig build Jakub Kicinski
2020-11-28 2:36 ` Yunsheng Lin
2020-11-28 5:20 ` Stephen Rothwell
2020-11-28 19:36 ` Jakub Kicinski
2020-11-30 0:58 ` Yunsheng Lin
2020-11-30 8:58 ` Geert Uytterhoeven
2020-11-30 10:26 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201128122819.32187696@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=davem@davemloft.net \
--cc=dja@axtens.net \
--cc=geert+renesas@glider.be \
--cc=joel@jms.id.au \
--cc=kuba@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=salil.mehta@huawei.com \
--cc=sboyd@kernel.org \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).