From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91600C2B9F4 for ; Fri, 25 Jun 2021 11:29:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 772AB61494 for ; Fri, 25 Jun 2021 11:29:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230135AbhFYLbp (ORCPT ); Fri, 25 Jun 2021 07:31:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:44540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbhFYLbp (ORCPT ); Fri, 25 Jun 2021 07:31:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 40E8561477; Fri, 25 Jun 2021 11:29:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624620564; bh=s9k5ZeqzU108sQnCro+HvoR0xX4v//RfxBQgVLsYSkM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ETjtDEfdNPYaKKBE/2CFq4gwpb2T0fuUAi+rChJmt6MtSWS96v+o+jZE8dreNTVC3 00k1L0Z/7TB3bQBNsWwJDi7k6phYy4HKwwnTtwKTXO2o5kgS74223TKxCaGBlUeSg4 B4P2EfYJXXtYqNH8TDdP0unJnm+K1ojvpejcrpGqAB+r26juPUMHRH6RwKzmEXj1qE b7ocqvhTbw1r5WekpFFSzCURsB6hYyroIZ9Vf7U+08YeEXzdrJY+aUCtCpK01icbIn TroTSuMSx81RuiNBX/MH5tfPewgXYQBEC744Lkr6Kbbzm/+VIAgrXWGwUeJBFFom8s 7lf+2ygOTBtMA== Received: by pali.im (Postfix) id 2404860E; Fri, 25 Jun 2021 13:29:22 +0200 (CEST) Date: Fri, 25 Jun 2021 13:29:21 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Geert Uytterhoeven Cc: kernel test robot , Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman , kbuild-all@lists.01.org, Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , Marek =?utf-8?B?QmVow7pu?= , linux-clk Subject: Re: [PATCH 07/10] serial: mvebu-uart: implement UART clock driver for configuring UART base clock Message-ID: <20210625112921.loyw6nmj6ld67lso@pali> References: <20210624224909.6350-8-pali@kernel.org> <202106251653.IbU5dy4V-lkp@intel.com> <20210625093131.aicap7ah5odokjvf@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hello! On Friday 25 June 2021 13:05:32 Geert Uytterhoeven wrote: > Hi Pali, > > On Fri, Jun 25, 2021 at 11:31 AM Pali Rohár wrote: > > On Friday 25 June 2021 16:15:38 kernel test robot wrote: > > > I love your patch! Yet something to improve: > > > > > > [auto build test ERROR on robh/for-next] > > > [also build test ERROR on tty/tty-testing clk/clk-next linus/master v5.13-rc7 next-20210624] > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > And when submitting patch, we suggest to use '--base' as documented in > > > https://git-scm.com/docs/git-format-patch] > > > > > > url: https://github.com/0day-ci/linux/commits/Pali-Roh-r/serial-mvebu-uart-Fixes-and-new-support-for-higher-baudrates/20210625-065146 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next > > > config: m68k-allmodconfig (attached as .config) > > > compiler: m68k-linux-gcc (GCC) 9.3.0 > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://github.com/0day-ci/linux/commit/747483a6b8f2de98afe461dbf91227404a8e2e81 > > > git remote add linux-review https://github.com/0day-ci/linux > > > git fetch --no-tags linux-review Pali-Roh-r/serial-mvebu-uart-Fixes-and-new-support-for-higher-baudrates/20210625-065146 > > > git checkout 747483a6b8f2de98afe461dbf91227404a8e2e81 > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > > > > All errors (new ones prefixed by >>): > > > > > > m68k-linux-ld: drivers/tty/serial/mvebu-uart.o: in function `mvebu_uart_clock_prepare': > > > mvebu-uart.c:(.text+0x6d0): undefined reference to `__udivdi3' > > > >> m68k-linux-ld: mvebu-uart.c:(.text+0x78c): undefined reference to `__udivdi3' > > > > Hello! Could you help me how to fix this issue? I'm using macro > > DIV_ROUND_CLOSEST() with two u64 values in that function. And I really > > do not know details about m68k arch and I never touched this arch. > > > > There is missing number of line which caused this error. So if it is > > possible I have suggestion for bot to compile kernel with -g flag. In > > this case linker show exact line number (and not only hex address) which > > caused that linker error. Also in future it could help identify source > > of errors... > > This error means your driver uses a 64-bit division without using the > proper methods from include/linux/math64.h. Ok. So whenever I need 64-bit division should I always use macros from this header file and also in case my driver is only for 64-bit platform? I see that in this header file is DIV64_U64_ROUND_CLOSEST() macro which seems to be 64-bit forced variant of DIV_ROUND_CLOSEST() which I'm using. I can change driver code to use DIV64_U64_ROUND_CLOSEST() macro in next patch iteration, if it helps. > It may happen when compiling for any 32-bit architecture. I guess that m64k is 32-bit platform... > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds