From: Fabio Estevam <festevam@gmail.com>
To: shawnguo@kernel.org
Cc: hs@denx.de, abelvesa@kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>
Subject: [PATCH 3/3] clk: imx: imx6sx: Remove hardcoded LCDIF1 parent
Date: Fri, 2 Jun 2023 19:16:04 -0300 [thread overview]
Message-ID: <20230602221604.155027-3-festevam@gmail.com> (raw)
In-Reply-To: <20230602221604.155027-1-festevam@gmail.com>
From: Fabio Estevam <festevam@denx.de>
It is not a good idea to hardcode the LCDIF1 parent inside the
clock driver because some users may want to use a different clock
parent for LCDIF1. One of the reasons could be related to EMI tests.
Remove the harcoded LCDIF1 parent as this is better described via
devicetree.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
drivers/clk/imx/clk-imx6sx.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/clk/imx/clk-imx6sx.c b/drivers/clk/imx/clk-imx6sx.c
index 3f1502933e59..b110258b9036 100644
--- a/drivers/clk/imx/clk-imx6sx.c
+++ b/drivers/clk/imx/clk-imx6sx.c
@@ -498,10 +498,6 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node)
clk_set_parent(hws[IMX6SX_CLK_EIM_SLOW_SEL]->clk, hws[IMX6SX_CLK_PLL2_PFD2]->clk);
clk_set_rate(hws[IMX6SX_CLK_EIM_SLOW]->clk, 132000000);
- /* set parent clock for LCDIF1 pixel clock */
- clk_set_parent(hws[IMX6SX_CLK_LCDIF1_PRE_SEL]->clk, hws[IMX6SX_CLK_PLL5_VIDEO_DIV]->clk);
- clk_set_parent(hws[IMX6SX_CLK_LCDIF1_SEL]->clk, hws[IMX6SX_CLK_LCDIF1_PODF]->clk);
-
/* Set the parent clks of PCIe lvds1 and pcie_axi to be pcie ref, axi */
if (clk_set_parent(hws[IMX6SX_CLK_LVDS1_SEL]->clk, hws[IMX6SX_CLK_PCIE_REF_125M]->clk))
pr_err("Failed to set pcie bus parent clk.\n");
--
2.34.1
next prev parent reply other threads:[~2023-06-02 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 22:16 [PATCH 1/3] ARM: dts: imx6sx: Remove LDB endpoint Fabio Estevam
2023-06-02 22:16 ` [PATCH 2/3] ARM: dts: imx6sx: Describe the default LCDIF1 parent Fabio Estevam
2023-06-02 22:16 ` Fabio Estevam [this message]
2023-06-09 0:24 ` [PATCH 3/3] clk: imx: imx6sx: Remove hardcoded " Stephen Boyd
2023-06-09 3:17 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602221604.155027-3-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=abelvesa@kernel.org \
--cc=festevam@denx.de \
--cc=hs@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).