From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F361EB64DA for ; Wed, 28 Jun 2023 14:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231970AbjF1Ovz (ORCPT ); Wed, 28 Jun 2023 10:51:55 -0400 Received: from mx2.sberdevices.ru ([45.89.224.132]:53767 "EHLO mx1.sberdevices.ru" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231977AbjF1Ov3 (ORCPT ); Wed, 28 Jun 2023 10:51:29 -0400 Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id BA890120019; Wed, 28 Jun 2023 17:51:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru BA890120019 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1687963871; bh=ijsYqbMrBgDeL0im1rxl0SGUF7eOfc45yINo+UI8MC4=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=Oe+k4MbnYaiC6F6uZRqqnKz+SRkhwtkRZ3YJ/ekh/TdOjH2aH3gBkDFjr1gETBnGC fCP14LYp/96JhA6mgW2C3tbIQfEmtOgfa5a3azAY6seTm/rG8Asro4GxFlax56ZZnk YM/aLipf/rrquca2rutqkoZrK3dys3RcUu8/9bCnXaOS9naoAIEEjY6SnwzsyBZAG+ VTZlh3nhsq4yEKTrCRd4gW/q6O9VMSdBnZpzRbdY7vnP0ZXePcK0NoPvNUGDGn+JSg OkJ4LMJQEOm0l4RDlrE/0I/3JVL1RRhfqi2qE2Hb20LPitRPzGtjkK4JbUDuCk65Xk RHrHyYNtEPnew== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Wed, 28 Jun 2023 17:51:10 +0300 (MSK) Received: from localhost (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 28 Jun 2023 17:50:12 +0300 Date: Wed, 28 Jun 2023 17:51:10 +0300 From: Dmitry Rokosov To: CC: Martin Blumenstingl , , , , , , , , , , , , , , , , Oleg Lyovin Subject: Re: [PATCH v1 5/6] arm64: dts: meson: a1: introduce UART_AO mux definitions Message-ID: <20230628145110.a7igezu7ts2aymkd@CAB-WSD-L081021> References: <20230607201641.20982-1-ddrokosov@sberdevices.ru> <20230607201641.20982-6-ddrokosov@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20220415 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 178314 [Jun 28 2023] X-KSMG-AntiSpam-Version: 5.9.59.0 X-KSMG-AntiSpam-Envelope-From: DDRokosov@sberdevices.ru X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 517 517 b0056c19d8e10afbb16cb7aad7258dedb0179a79, {Track_E25351}, {Tracking_from_domain_doesnt_match_to}, 127.0.0.199:7.1.2;sberdevices.ru:7.1.1,5.0.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;p-i-exch-sc-m01.sberdevices.ru:7.1.1,5.0.1, FromAlignment: s, {Tracking_white_helo}, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/06/28 08:00:00 #21591748 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Neil, Martin, On Mon, Jun 26, 2023 at 03:34:38PM +0200, neil.armstrong@linaro.org wrote: > Hi, > > On 25/06/2023 23:07, Martin Blumenstingl wrote: > > On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov wrote: > > > > > > From: Oleg Lyovin > > > > > > The Amlogic A1 has a UART_AO port, which can be used, for example, for > > > BT HCI H4 connection. > > > > > > This patch adds mux definitions for it. > > In the past we've only taken the pinctrl definitions if we have a > > board that uses them. > > Neil, do we still have the same policy in place? If so this patch > > should be sent with the series that adds support for your A1 board. > > Yes and no, if the work is done I'll take it, but yeah since upstream linux > hates dead code, let's only define what's necessary. > I'll prepare the patches for ad401 reference board, and share the in the next patch series version. > > > > > Signed-off-by: Oleg Lyovin > > > Signed-off-by: Dmitry Rokosov > > > --- > > > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 16 ++++++++++++++++ > > > 1 file changed, 16 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > > > index 0efd922ca7e1..3eb6aa9c00e0 100644 > > > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > > > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > > > @@ -118,6 +118,22 @@ gpio: bank@400 { > > > gpio-ranges = <&periphs_pinctrl 0 0 62>; > > > }; > > > > > > + uart_a_pins: uart_a { > > Only our newer .dtsi (e.g. meson-g12-common.dtsi) are following the > > pattern where node names should use dashes instead of underscores. > > So please use: uart_a_pins: uart-a { ... > > The new scheme which should be use should be: > > uart_a_pins: uart-a-pins-state { > > but it wasn't enforced in the pinctrl yaml pushed by heiner, but for sure > no underscores in the node name. > Okay, got it > > > > [...] > > > + uart_a_cts_rts_pins: uart_a_cts_rts { > > similar to the comment from above: > > uart_a_cts_rts_pins: uart-a-cts-rts { ... > > > > > + mux { > > > + groups = "uart_a_cts", > > > + "uart_a_rts"; > > > + function = "uart_a"; > > > + bias-pull-down; > > Out of curiosity: is this pull down needed on all boards or just specific ones? > > It seems like all other SoCs use bias-disable for the RTS/CTS pins. > > > > > > Best regards, > > Martin > -- Thank you, Dmitry