From: Tero Kristo <t-kristo@ti.com>
To: Stephen Boyd <sboyd@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
<linux-omap@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] clk: ti: Fix error handling in ti_clk_parse_divider_data()
Date: Thu, 24 Jan 2019 21:50:33 +0200 [thread overview]
Message-ID: <2d7a3290-44b3-94ad-076e-fda869480edf@ti.com> (raw)
In-Reply-To: <154835786296.136743.12154336975596919287@swboyd.mtv.corp.google.com>
On 24/01/2019 21:24, Stephen Boyd wrote:
> Quoting Dan Carpenter (2019-01-15 11:46:25)
>> The ti_clk_parse_divider_data() function is only called from
>> _get_div_table_from_setup(). That function doesn't look at the return
>> value but instead looks at the "*table" pointer. In this case, if the
>> kcalloc() fails then *table is NULL (which means success). It should
>> instead be an error pointer.
>>
>> The ti_clk_parse_divider_data() function has two callers. One checks
>> for errors and the other doesn't. I have fixed it so now both handle
>> errors.
>>
>> Fixes: 4f6be5655dc9 ("clk: ti: divider: add driver internal API for parsing divider data")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>
> Applied to clk-fixes
>
> I'm going to add Tero's ack to this because it isn't really that
> different.
>
Yeah, thats ok. Thanks Stephen.
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
prev parent reply other threads:[~2019-01-24 19:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 14:45 [bug report] clk: ti: divider: add driver internal API for parsing divider data Dan Carpenter
2019-01-09 19:45 ` Stephen Boyd
2019-01-15 7:01 ` [PATCH] clk: ti: Fix error handling in ti_clk_parse_divider_data() Dan Carpenter
2019-01-15 8:36 ` Tero Kristo
2019-01-15 13:21 ` kbuild test robot
2019-01-15 13:42 ` Dan Carpenter
2019-01-15 13:53 ` kbuild test robot
2019-01-15 19:46 ` [PATCH v2] " Dan Carpenter
2019-01-24 19:24 ` Stephen Boyd
2019-01-24 19:50 ` Tero Kristo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d7a3290-44b3-94ad-076e-fda869480edf@ti.com \
--to=t-kristo@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).