From: Heiko Stuebner <heiko@sntech.de>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
mturquette@baylibre.com,
christoph.muellner@theobroma-systems.com,
zhangqing@rock-chips.com
Subject: Re: [PATCH] clk: rockchip: convert rk3036 pll type to use internal lock status
Date: Tue, 28 Jan 2020 11:26:37 +0100 [thread overview]
Message-ID: <3308363.gZKxoYc2QA@phil> (raw)
In-Reply-To: <20200114050518.D3C40222C3@mail.kernel.org>
Am Dienstag, 14. Januar 2020, 06:05:18 CET schrieb Stephen Boyd:
> Quoting Heiko Stuebner (2020-01-13 07:26:56)
> > diff --git a/drivers/clk/rockchip/clk-pll.c b/drivers/clk/rockchip/clk-pll.c
> > index 198417d56300..37378ded0993 100644
> > --- a/drivers/clk/rockchip/clk-pll.c
> > +++ b/drivers/clk/rockchip/clk-pll.c
> > @@ -118,12 +118,30 @@ static int rockchip_pll_wait_lock(struct rockchip_clk_pll *pll)
> > #define RK3036_PLLCON1_REFDIV_SHIFT 0
> > #define RK3036_PLLCON1_POSTDIV2_MASK 0x7
> > #define RK3036_PLLCON1_POSTDIV2_SHIFT 6
> > +#define RK3036_PLLCON1_LOCK_STATUS BIT(10)
> > #define RK3036_PLLCON1_DSMPD_MASK 0x1
> > #define RK3036_PLLCON1_DSMPD_SHIFT 12
> > +#define RK3036_PLLCON1_PWRDOWN BIT(13)
> > #define RK3036_PLLCON2_FRAC_MASK 0xffffff
> > #define RK3036_PLLCON2_FRAC_SHIFT 0
> >
> > -#define RK3036_PLLCON1_PWRDOWN (1 << 13)
> > +static int rockchip_rk3036_pll_wait_lock(struct rockchip_clk_pll *pll)
> > +{
> > + u32 pllcon;
> > + int delay = 24000000;
> > +
> > + /* poll check the lock status in rk3399 xPLLCON2 */
> > + while (delay > 0) {
> > + pllcon = readl_relaxed(pll->reg_base + RK3036_PLLCON(1));
> > + if (pllcon & RK3036_PLLCON1_LOCK_STATUS)
> > + return 0;
> > +
> > + delay--;
>
> There isn't any udelay here. So the timeout is just as fast as the CPU
> can churn through this? Why not use an actual time? Or use the
> readl_poll_timeout() APIs?
Done in
http://lore.kernel.org/r/20200128100204.1318450-3-heiko@sntech.de
and to keep things similar, I did a conversion to iopoll helpers for the
other variants too.
Heiko
prev parent reply other threads:[~2020-01-28 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 15:26 [PATCH] clk: rockchip: convert rk3036 pll type to use internal lock status Heiko Stuebner
2020-01-14 5:05 ` Stephen Boyd
2020-01-28 10:26 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3308363.gZKxoYc2QA@phil \
--to=heiko@sntech.de \
--cc=christoph.muellner@theobroma-systems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).