From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5CFAC3B187 for ; Wed, 12 Feb 2020 22:36:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86DF6217F4 for ; Wed, 12 Feb 2020 22:36:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728098AbgBLWg1 (ORCPT ); Wed, 12 Feb 2020 17:36:27 -0500 Received: from gloria.sntech.de ([185.11.138.130]:39280 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727947AbgBLWg1 (ORCPT ); Wed, 12 Feb 2020 17:36:27 -0500 Received: from p508fd8fe.dip0.t-ipconnect.de ([80.143.216.254] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1j20cF-0001ua-8B; Wed, 12 Feb 2020 23:36:19 +0100 From: Heiko Stuebner To: Justin Swartz Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: rockchip: fix incorrect configuration of rk3228 aclk_gpu* clocks Date: Wed, 12 Feb 2020 23:36:18 +0100 Message-ID: <3638560.bLjz2vc75D@phil> In-Reply-To: <20200114162503.7548-1-justin.swartz@risingedge.co.za> References: <20200114162503.7548-1-justin.swartz@risingedge.co.za> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Justin, Am Dienstag, 14. Januar 2020, 17:25:02 CET schrieb Justin Swartz: > The following changes prevent the unrecoverable freezes and rcu_sched > stall warnings experienced in each of my attempts to take advantage of > lima. > > Replace the COMPOSITE_NOGATE definition of aclk_gpu_pre with a > COMPOSITE that retains the selection of HDMIPHY as the PLL source, but > instead makes uses of the aclk_gpu PLL source gate and parent names > defined by mux_pll_src_4plls_p rather than mux_aclk_gpu_pre_p. > > Remove the now unused mux_aclk_gpu_pre_p and the four named but also > unused definitions (cpll_gpu, gpll_gpu, hdmiphy_gpu and usb480m_gpu) > of the aclk_gpu PLL source gate. > > Use the correct gate offset for aclk_gpu and aclk_gpu_noc. > > Signed-off-by: Justin Swartz thanks a lot for diving through the clock controller and fixing the issues. I've checked against the TRM as well and the previous state was quite wrong and your changes match the hardware manual. I've applied it as fix for 5.6 now. Thanks Heiko