From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH 1/2] clk: hisilicon: Use correct return value about hisi_reset_init()
Date: Wed, 27 May 2020 10:49:14 +0800 [thread overview]
Message-ID: <3cf9f657-8471-43e2-0bf2-0cf86d85e284@loongson.cn> (raw)
In-Reply-To: <159053414719.88029.3577704206897582789@swboyd.mtv.corp.google.com>
On 05/27/2020 07:02 AM, Stephen Boyd wrote:
> Quoting Tiezhu Yang (2020-05-24 20:31:55)
>> The return value about hisi_reset_init() is not correct, fix it.
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>> drivers/clk/hisilicon/clk-hi3519.c | 4 ++--
>> drivers/clk/hisilicon/crg-hi3516cv300.c | 4 ++--
>> drivers/clk/hisilicon/crg-hi3798cv200.c | 4 ++--
>> drivers/clk/hisilicon/reset.c | 4 ++--
>> 4 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/clk/hisilicon/clk-hi3519.c b/drivers/clk/hisilicon/clk-hi3519.c
>> index ad0c7f3..803fa66 100644
>> --- a/drivers/clk/hisilicon/clk-hi3519.c
>> +++ b/drivers/clk/hisilicon/clk-hi3519.c
>> @@ -149,8 +149,8 @@ static int hi3519_clk_probe(struct platform_device *pdev)
>> return -ENOMEM;
>>
>> crg->rstc = hisi_reset_init(pdev);
>> - if (!crg->rstc)
>> - return -ENOMEM;
>> + if (IS_ERR(crg->rstc))
>> + return PTR_ERR(crg->rstc);
>>
>> crg->clk_data = hi3519_clk_register(pdev);
>> if (IS_ERR(crg->clk_data)) {
> The code I see is returning NULL or a valid pointer from
> hisi_reset_init(). Can you add a "Fixes" tag to this patch so we can
> figure out which patch changed the behavior and where this patch needs
> to be backported to?
OK, I will check the git log to add a Fixes tag and then send v2.
Thanks,
Tiezhu Yang
prev parent reply other threads:[~2020-05-27 2:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 3:31 [PATCH 1/2] clk: hisilicon: Use correct return value about hisi_reset_init() Tiezhu Yang
2020-05-25 3:31 ` [PATCH 2/2] clk: Remove CONFIG_ARCH_HISI check for subdir hisilicon Tiezhu Yang
2020-05-26 18:55 ` kbuild test robot
2020-05-27 4:16 ` Tiezhu Yang
2020-05-27 4:13 ` kbuild test robot
2020-05-27 7:56 ` kbuild test robot
2020-05-26 23:02 ` [PATCH 1/2] clk: hisilicon: Use correct return value about hisi_reset_init() Stephen Boyd
2020-05-27 2:49 ` Tiezhu Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cf9f657-8471-43e2-0bf2-0cf86d85e284@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).