linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: samsung: exynos5433: Add missing slab.h header for kfree()
@ 2019-10-23 16:00 ` Krzysztof Kozlowski
  2019-10-29 11:37   ` Sylwester Nawrocki
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2019-10-23 16:00 UTC (permalink / raw)
  To: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
	Stephen Boyd, Kukjin Kim, Krzysztof Kozlowski, linux-samsung-soc,
	linux-clk, linux-arm-kernel, linux-kernel
  Cc: kbuild test robot

Usage of kfree() requires slab.h header.  Otherwise building on x86_64
with COMPILE_TEST fails with:

    drivers/clk/samsung/clk-exynos5433.c: In function ‘exynos5433_cmu_probe’:
    drivers/clk/samsung/clk-exynos5433.c:5598:4: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/clk/samsung/clk-exynos5433.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
index 0b60316331a0..4b1aa9382ad2 100644
--- a/drivers/clk/samsung/clk-exynos5433.c
+++ b/drivers/clk/samsung/clk-exynos5433.c
@@ -13,6 +13,7 @@
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
+#include <linux/slab.h>
 
 #include <dt-bindings/clock/exynos5433.h>
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: samsung: exynos5433: Add missing slab.h header for kfree()
  2019-10-23 16:00 ` [PATCH] clk: samsung: exynos5433: Add missing slab.h header for kfree() Krzysztof Kozlowski
@ 2019-10-29 11:37   ` Sylwester Nawrocki
  0 siblings, 0 replies; 2+ messages in thread
From: Sylwester Nawrocki @ 2019-10-29 11:37 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Tomasz Figa, Chanwoo Choi, Michael Turquette, Stephen Boyd,
	Kukjin Kim, linux-samsung-soc, linux-clk, linux-arm-kernel,
	linux-kernel, kbuild test robot

On 10/23/19 18:00, Krzysztof Kozlowski wrote:
> Usage of kfree() requires slab.h header.  Otherwise building on x86_64
> with COMPILE_TEST fails with:
> 
>     drivers/clk/samsung/clk-exynos5433.c: In function ‘exynos5433_cmu_probe’:
>     drivers/clk/samsung/clk-exynos5433.c:5598:4: error: implicit declaration 
> of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Thanks, I applied it and squashed with the fix patch from Marek that
introduced the above issue.

-- 
Regards,
Sylwester

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-29 11:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20191023160027epcas4p15be9c72d575fa4c3b022551c32cfc59a@epcas4p1.samsung.com>
2019-10-23 16:00 ` [PATCH] clk: samsung: exynos5433: Add missing slab.h header for kfree() Krzysztof Kozlowski
2019-10-29 11:37   ` Sylwester Nawrocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).