From: Joseph Lo <josephl@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>
Cc: <linux-tegra@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V3 5/8] memory: tegra: Add EMC scaling support code for Tegra210
Date: Tue, 14 May 2019 16:47:37 +0800 [thread overview]
Message-ID: <54203d4d-aced-543e-6ebb-6ffacb7c8a85@nvidia.com> (raw)
In-Reply-To: <dc580a9b-4d37-ae20-888d-3956b284c43b@gmail.com>
On 5/14/19 1:02 AM, Dmitry Osipenko wrote:
> 10.05.2019 11:47, Joseph Lo пишет:
>> This patch adds the required APIs and variables for the EMC scaling
>> sequence code on Tegra210.
>>
>> Based on the work of Peter De Schrijver <pdeschrijver@nvidia.com>.
>>
>> Signed-off-by: Joseph Lo <josephl@nvidia.com>
>> ---
snip.
>> +void do_clock_change(struct tegra_emc *emc, u32 clksrc)
>> +{
>> + int err;
>> +
>> + mc_readl(emc->mc, MC_EMEM_ADR_CFG);
>> + emc_readl(emc, EMC_INTSTATUS);
>> +
>> + tegra210_clk_emc_update_setting(clksrc);
>> +
>> + err = wait_for_update(emc, EMC_INTSTATUS,
>> + EMC_INTSTATUS_CLKCHANGE_COMPLETE, true, REG_EMC);
>> + if (err) {
>> + pr_err("%s: clock change completion error: %d", __func__, err);
>> + WARN_ON(1);
>> + }
>> +}
>> +
>> +struct emc_table *get_timing_from_freq(struct tegra_emc *emc,
>> + unsigned long rate)
>> +{
>> + int i;
>> +
>> + for (i = 0; i < emc->emc_table_size; i++)
>> + if (emc->emc_table[i].rate == rate)
>> + return &emc->emc_table[i];
>> +
>> + return NULL;
>> +}
>> +
>> +int wait_for_update(struct tegra_emc *emc, u32 status_reg, u32 bit_mask,
>> + bool updated_state, int chan)
>> +{
>
> This and all other global functions have very generic names. Either
> squash it all into a single source file and make all functions static,
> or change the names to something more unique.
>
Okay, will fix it.
Thanks,
Joseph
next prev parent reply other threads:[~2019-05-14 8:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 8:47 [PATCH V3 0/8] Add EMC scaling support for Tegra210 Joseph Lo
2019-05-10 8:47 ` [PATCH V3 1/8] dt-bindings: memory: tegra: Add external memory controller binding " Joseph Lo
2019-05-14 16:28 ` Dmitry Osipenko
2019-05-15 7:17 ` Joseph Lo
2019-05-15 13:50 ` Dmitry Osipenko
2019-05-16 9:01 ` Joseph Lo
2019-05-16 14:39 ` Dmitry Osipenko
2019-05-10 8:47 ` [PATCH V3 2/8] clk: tegra: Add PLLP_UD and PLLMB_UD " Joseph Lo
2019-05-10 8:47 ` [PATCH V3 3/8] clk: tegra: Export functions for EMC clock scaling Joseph Lo
2019-05-14 16:29 ` Dmitry Osipenko
2019-05-15 7:25 ` Joseph Lo
2019-05-10 8:47 ` [PATCH V3 4/8] memory: tegra: Add Tegra210 EMC clock driver Joseph Lo
2019-05-13 16:54 ` Dmitry Osipenko
2019-05-14 9:22 ` Joseph Lo
2019-05-14 17:04 ` Dmitry Osipenko
2019-05-15 8:42 ` Joseph Lo
2019-05-15 15:25 ` Dmitry Osipenko
2019-05-16 7:52 ` Joseph Lo
2019-05-16 14:29 ` Dmitry Osipenko
2019-05-10 8:47 ` [PATCH V3 5/8] memory: tegra: Add EMC scaling support code for Tegra210 Joseph Lo
2019-05-13 17:02 ` Dmitry Osipenko
2019-05-14 8:47 ` Joseph Lo [this message]
2019-05-14 16:30 ` Dmitry Osipenko
2019-05-15 14:09 ` Dmitry Osipenko
2019-05-15 15:26 ` Dmitry Osipenko
2019-05-10 8:47 ` [PATCH V3 6/8] memory: tegra: Add EMC scaling sequence " Joseph Lo
2019-05-10 8:47 ` [PATCH V3 7/8] clk: tegra: Remove the old emc_mux clock " Joseph Lo
2019-05-10 8:47 ` [PATCH V3 8/8] arm64: tegra: Add external memory controller node " Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54203d4d-aced-543e-6ebb-6ffacb7c8a85@nvidia.com \
--to=josephl@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).