From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Jagadeesh Kona <quic_jkona@quicinc.com>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Taniya Das <quic_tdas@quicinc.com>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Ajit Pandey <quic_ajipan@quicinc.com>
Subject: Re: [PATCH V2 1/6] dt-bindings: clock: qcom: Add SM8550 camera clock controller
Date: Fri, 26 May 2023 13:29:44 +0100 [thread overview]
Message-ID: <546876ba-970d-5cd5-648e-723698ca74fd@linaro.org> (raw)
In-Reply-To: <20230525172142.9039-2-quic_jkona@quicinc.com>
On 25/05/2023 18:21, Jagadeesh Kona wrote:
> Add device tree bindings for the camera clock controller on
> Qualcomm SM8550 platform.
>
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
> ---
> Changes since V1:
> - Removed new YAML file and reused SM8450 CAMCC YAML file for SM8550
>
> .../bindings/clock/qcom,sm8450-camcc.yaml | 8 +-
> include/dt-bindings/clock/qcom,sm8550-camcc.h | 187 ++++++++++++++++++
> 2 files changed, 193 insertions(+), 2 deletions(-)
> create mode 100644 include/dt-bindings/clock/qcom,sm8550-camcc.h
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> index 87ae74166807..8dbc9004202f 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
> @@ -13,11 +13,15 @@ description: |
> Qualcomm camera clock control module provides the clocks, resets and power
> domains on SM8450.
>
> - See also:: include/dt-bindings/clock/qcom,sm8450-camcc.h
> + See also::
> + include/dt-bindings/clock/qcom,sm8450-camcc.h
> + include/dt-bindings/clock/qcom,sm8550-camcc.h
>
> properties:
> compatible:
> - const: qcom,sm8450-camcc
> + enum:
> + - qcom,sm8450-camcc
> + - qcom,sm8550-camcc
Hmm,
So looking at Documentation/devicetree/bindings/clock/*camcc*.yaml we
seem to be repeating yaml over and over again with no substantial
difference between one description and another.
You've picked at the thread here by adding sm8550 into sm8450.
I think sm8250, sm8450, sm8550, sc7280 and ... probably sm6350 should
live in the one yaml description
Documentation/devicetree/bindings/clock/qcom,camcc.yaml
sm6350 looks a bit sparse/incomplete to me so perhaps leave that out.
The others sc7280, sm8250, sm8450 and sm8550 can/should all be moved
into the same yaml file with a list of compatibles.
---
bod
next prev parent reply other threads:[~2023-05-26 12:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 17:21 [PATCH V2 0/6] Add camera clock controller support for SM8550 Jagadeesh Kona
2023-05-25 17:21 ` [PATCH V2 1/6] dt-bindings: clock: qcom: Add SM8550 camera clock controller Jagadeesh Kona
2023-05-26 12:29 ` Bryan O'Donoghue [this message]
2023-05-25 17:21 ` [PATCH V2 2/6] clk: qcom: Update l value configuration for lucid ole and evo plls Jagadeesh Kona
2023-05-26 13:22 ` Bryan O'Donoghue
2023-06-01 14:20 ` Jagadeesh Kona
2023-05-25 17:21 ` [PATCH V2 3/6] clk: qcom: clk-alpha-pll: Remove explicit CAL_L configuration for EVO PLL Jagadeesh Kona
2023-05-26 9:33 ` Konrad Dybcio
2023-05-26 15:53 ` Dmitry Baryshkov
2023-06-01 14:33 ` Jagadeesh Kona
2023-06-01 14:43 ` Dmitry Baryshkov
2023-06-09 11:50 ` Jagadeesh Kona
2023-06-09 12:25 ` Dmitry Baryshkov
2023-06-14 11:53 ` Jagadeesh Kona
2023-06-14 12:26 ` Dmitry Baryshkov
2023-06-23 16:35 ` Jagadeesh Kona
2023-05-26 15:54 ` Bryan O'Donoghue
2023-05-26 15:57 ` Bryan O'Donoghue
2023-06-01 14:21 ` Jagadeesh Kona
2023-05-25 17:21 ` [PATCH V2 4/6] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550 Jagadeesh Kona
[not found] ` <0ad16ac8-deac-41d3-9c36-885eb8be3fee@linaro.org>
2023-06-01 14:34 ` Jagadeesh Kona
2023-05-25 17:21 ` [PATCH V2 5/6] clk: qcom: camcc-sm8550: Add support for qdss, sleep and xo clocks Jagadeesh Kona
2023-05-25 17:21 ` [PATCH V2 6/6] arm64: dts: qcom: sm8550: Add camera clock controller Jagadeesh Kona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546876ba-970d-5cd5-648e-723698ca74fd@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).