From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
bjorn.andersson@linaro.org, mturquette@baylibre.com
Cc: marc.w.gonzalez@free.fr, andy.gross@linaro.org,
david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 3/4] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver
Date: Tue, 5 Feb 2019 15:12:00 -0700 [thread overview]
Message-ID: <54750df0-245c-74ab-2a33-ce1588f3e38e@codeaurora.org> (raw)
In-Reply-To: <154940436246.169292.7591382350282828249@swboyd.mtv.corp.google.com>
On 2/5/2019 3:06 PM, Stephen Boyd wrote:
> Quoting Jeffrey Hugo (2019-01-30 08:36:11)
> [..]
>> +};
>> +MODULE_DEVICE_TABLE(of, mmcc_msm8998_match_table);
>> +
>> +static int mmcc_msm8998_probe(struct platform_device *pdev)
>> +{
>> + struct device *dev = &pdev->dev;
>> + int i, ret;
>> + struct regmap *regmap;
>> + struct clk *c;
>> +
>> + c = devm_clk_get(dev, "xo");
>> + if (!IS_ERR(c))
>> + dummy_xo_init.parent_names =
>> + (const char *[]){__clk_get_name(c)};
>> + else
>> + return PTR_ERR(c);
>> +
>> + c = devm_clk_get(dev, "gpll0");
>> + if (!IS_ERR(c))
>> + dummy_gpll0_init.parent_names =
>> + (const char *[]){__clk_get_name(c)};
>> + else
>> + return PTR_ERR(c);
>
> Urgh, my parent mapping series can't come be merged fast enough it
> seems!
Sorry, I'm not familiar with the context. Something I should incorporate?
>
>> +
>> + regmap = qcom_cc_map(pdev, &mmcc_msm8998_desc);
>> + if (IS_ERR(regmap))
>> + return PTR_ERR(regmap);
>> +
>> + for (i = 0; i < ARRAY_SIZE(mmcc_msm8998_hws); i++) {
>> + ret = devm_clk_hw_register(dev, mmcc_msm8998_hws[i]);
>
> I think we should make this common to the qcom_cc_desc now. Can you
> throw in an optional list of clk_hw pointers that also get registered as
> its own patch and update the existing drivers that are all doing this?
Yeah, can do.
>
>> + if (ret)
>> + return ret;
>> + }
>> +
>> + return qcom_cc_really_probe(pdev, &mmcc_msm8998_desc, regmap);
>> +}
--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-02-05 22:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 16:35 [PATCH v1 0/4] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-01-30 16:35 ` [PATCH v1 1/4] clk: qcom: smd: Add XO clock for MSM8998 Jeffrey Hugo
2019-02-05 22:01 ` Stephen Boyd
2019-02-05 22:15 ` Jeffrey Hugo
2019-02-05 22:32 ` Stephen Boyd
2019-02-05 22:37 ` Jeffrey Hugo
2019-02-06 13:55 ` Georgi Djakov
2019-02-06 17:04 ` Jeffrey Hugo
2019-01-30 16:35 ` [PATCH v1 2/4] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-02-05 22:02 ` Stephen Boyd
2019-02-05 22:08 ` Jeffrey Hugo
2019-02-05 22:16 ` Stephen Boyd
2019-02-05 22:36 ` Jeffrey Hugo
2019-01-30 16:36 ` [PATCH v1 3/4] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo
2019-02-05 22:06 ` Stephen Boyd
2019-02-05 22:12 ` Jeffrey Hugo [this message]
2019-02-05 22:16 ` Stephen Boyd
2019-01-30 16:36 ` [PATCH v1 4/4] arm64: dts: qcom: msm8998: Add mmcc node Jeffrey Hugo
2019-02-05 22:03 ` Stephen Boyd
2019-02-05 22:10 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54750df0-245c-74ab-2a33-ce1588f3e38e@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).