From: Heiko Stuebner <heiko@sntech.de>
To: "Leonidas P. Papadakos" <papadakospan@gmail.com>
Cc: itdaniher@gmail.com, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: rockchip: add clock for the watchdog pclk on rk3328
Date: Fri, 14 Jun 2019 11:50:24 +0200 [thread overview]
Message-ID: <5657669.4RvfzeBcXs@phil> (raw)
In-Reply-To: <1559821340.1384.0@gmail.com>
Hi,
Am Donnerstag, 6. Juni 2019, 13:42:20 CEST schrieb Leonidas P. Papadakos:
>
> Hi,
> >
> > Am Donnerstag, 6. Juni 2019, 01:57:13 CEST schrieb Leonidas P.
> > Papadakos:
> >> From: <itdaniher@gmail.com>
> >
> > Why is the From different from the Signed-off-by? Would also need a
> > full name.
> > If the patch is from you, please just use the same From as for the
> > Signed-off-by.
> >
>
> I mistakenly though this was the way to credit someone for a patch, but
> it seems to be different.
> I'll Cc: the author of this patch
Were you able yet to take a look at the clock-patches I Cc'ed you on
and look at reworking your patch accrodingly?
Thanks
Heiko
>
> >>
> >> Following the discussion here:
> >> https://github.com/rockchip-linux/kernel/issues/123
> >>
> >> it can be seen that these are the changes needed to enable the use
> >> of the hardware watchdog in the rk3328 SoC.
> >>
> >> This is in line with past changes for the rk3288:
> >>
> >> http://lists.infradead.org/pipermail/linux-rockchip/2015-January/002314.html
> >>
> >> Signed-off-by: Leonidas P. Papadakos <papadakospan@gmail.com>
> >> ---
> >> drivers/clk/rockchip/clk-rk3328.c | 9 +++++++++
> >> include/dt-bindings/clock/rk3328-cru.h | 1 +
> >> 2 files changed, 10 insertions(+)
> >>
> >> diff --git a/drivers/clk/rockchip/clk-rk3328.c
> >> b/drivers/clk/rockchip/clk-rk3328.c
> >> index 076b9777a..546ee0ab7 100644
> >> --- a/drivers/clk/rockchip/clk-rk3328.c
> >> +++ b/drivers/clk/rockchip/clk-rk3328.c
> >> @@ -876,6 +876,8 @@ static const char *const
> >> rk3328_critical_clocks[] __initconst = {
> >>
> >> static void __init rk3328_clk_init(struct device_node *np)
> >> {
> >> + struct clk *clk;
> >> +
> >> struct rockchip_clk_provider *ctx;
> >> void __iomem *reg_base;
> >>
> >> @@ -892,6 +894,13 @@ static void __init rk3328_clk_init(struct
> >> device_node *np)
> >> return;
> >> }
> >>
> >> + clk = clk_register_fixed_factor(NULL, "pclk_wdt", "pclk_bus", 0,
> >> 1, 1);
> >> + if (IS_ERR(clk))
> >> + pr_warn("%s: could not register clock pclk_wdt: %ld\n",
> >> + __func__, PTR_ERR(clk));
> >> + else
> >> + rockchip_clk_add_lookup(ctx, clk, PCLK_WDT);
> >> +
> >
> > I've just Cc'ed you on 2 patches adding a SGRF_GATE clock-type. Please
> > use that as base for you rk3328-wdt-clock, so that we don't introduce
> > more
> > boilderplate code.
> >
> >
> >> rockchip_clk_register_plls(ctx, rk3328_pll_clks,
> >> ARRAY_SIZE(rk3328_pll_clks),
> >> RK3328_GRF_SOC_STATUS0);
> >
> >> diff --git a/include/dt-bindings/clock/rk3328-cru.h
> >> b/include/dt-bindings/clock/rk3328-cru.h
> >> index afb811340..555b4ff66 100644
> >> --- a/include/dt-bindings/clock/rk3328-cru.h
> >> +++ b/include/dt-bindings/clock/rk3328-cru.h
> >> @@ -164,6 +164,7 @@
> >> #define PCLK_DCF 233
> >> #define PCLK_SARADC 234
> >> #define PCLK_ACODECPHY 235
> >> +#define PCLK_WDT 236
> >>
> >> /* hclk gates */
> >> #define HCLK_PERI 308
> >
> > please split the addition of the clock-id into a separate patch only
> > adding
> > said id.
> >
> >
> > Thanks
> > Heiko
> >
>
> I know less than him on this, but I want the feedback to be visible in
> the Cc:
>
>
>
next prev parent reply other threads:[~2019-06-14 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 23:57 [PATCH 1/2] clk: rockchip: add clock for the watchdog pclk on rk3328 Leonidas P. Papadakos
2019-06-05 23:57 ` [PATCH 2/2] arm64: dts: rockchip: enable rk3328 watchdog clock Leonidas P. Papadakos
2019-06-06 10:02 ` [PATCH 1/2] clk: rockchip: add clock for the watchdog pclk on rk3328 Heiko Stuebner
2019-06-06 11:42 ` Leonidas P. Papadakos
2019-06-14 9:50 ` Heiko Stuebner [this message]
2019-06-14 9:54 ` Leonidas P. Papadakos
2019-06-14 10:31 ` Heiko Stuebner
2019-06-14 19:47 ` Leonidas P. Papadakos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5657669.4RvfzeBcXs@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=itdaniher@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=papadakospan@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).