From: Dmitry Osipenko <digetx@gmail.com>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
pgaikwad@nvidia.com, pdeschrijver@nvidia.com,
mturquette@baylibre.com, sboyd@kernel.org, axboe@kernel.dk,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: tegra124-jetson-tk1: sata doesnt work since 5.2
Date: Wed, 3 Jun 2020 01:49:57 +0300 [thread overview]
Message-ID: <56700c1d-ffb0-e44e-ea8e-48a848ccf3bf@gmail.com> (raw)
In-Reply-To: <20200602081958.GA21773@Red>
02.06.2020 11:19, LABBE Corentin пишет:
...
>> Sounds like PLLE needs to be enabled for SATA, but ahci-tegra driver
>> doesn't do that.
>>
>> Could you please try this change:
>>
>> --- >8 ---
>> diff --git a/drivers/clk/tegra/clk-tegra124.c
>> b/drivers/clk/tegra/clk-tegra124.c
>> index e931319dcc9d..7dbc14652830 100644
>> --- a/drivers/clk/tegra/clk-tegra124.c
>> +++ b/drivers/clk/tegra/clk-tegra124.c
>> @@ -1330,6 +1330,7 @@ static struct tegra_clk_init_table
>> common_init_table[] __initdata = {
>> { TEGRA124_CLK_I2S3_SYNC, TEGRA124_CLK_CLK_MAX, 24576000, 0 },
>> { TEGRA124_CLK_I2S4_SYNC, TEGRA124_CLK_CLK_MAX, 24576000, 0 },
>> { TEGRA124_CLK_VIMCLK_SYNC, TEGRA124_CLK_CLK_MAX, 24576000, 0 },
>> + { TEGRA124_CLK_PLL_E, TEGRA124_CLK_CLK_MAX, 0, 1 },
>> /* must be the last entry */
>> { TEGRA124_CLK_CLK_MAX, TEGRA124_CLK_CLK_MAX, 0, 0 },
>> };
>> --- >8 ---
>
> This patch alone does not fix the issue.
I'd try to enable all the clocks and voltage regulators that are enabled
by the USB driver. Also won't hurt to check the clock rate
configurations with the enabled / disabled USB, try to replicate the
working configuration.
next prev parent reply other threads:[~2020-06-02 22:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 7:44 tegra124-jetson-tk1: sata doesnt work since 5.2 LABBE Corentin
2020-03-19 7:55 ` Nicolas Chauvet
2020-03-25 13:40 ` LABBE Corentin
2020-03-25 14:00 ` Jon Hunter
2020-03-25 14:23 ` LABBE Corentin
2020-03-25 20:15 ` Thierry Reding
2020-03-26 13:33 ` LABBE Corentin
2020-05-31 19:31 ` LABBE Corentin
2020-06-01 14:30 ` Dmitry Osipenko
2020-06-02 8:19 ` LABBE Corentin
2020-06-02 22:49 ` Dmitry Osipenko [this message]
2020-06-03 10:56 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56700c1d-ffb0-e44e-ea8e-48a848ccf3bf@gmail.com \
--to=digetx@gmail.com \
--cc=axboe@kernel.dk \
--cc=clabbe@baylibre.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).