From: Marek Vasut <marek.vasut@gmail.com>
To: Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925
Date: Sun, 9 Jul 2017 15:31:38 +0200 [thread overview]
Message-ID: <57a23b45-9514-00c0-aa92-00a54d68ad2e@gmail.com> (raw)
In-Reply-To: <1499392677-9100-1-git-send-email-vladimir.barinov@cogentembedded.com>
On 07/07/2017 03:57 AM, Vladimir Barinov wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
>
> IDT VersaClock 5 5P49V5925 has 4 clock outputs
In 1/2 you said it has 4 FODs and 5 outputs (and it does have 5 outputs,
4 from FODs and 1 I2C_OUTB).
>, 4 fractional dividers.
> Input clock source can be taken only from external reference clock.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
You might want to rebase this on top of and retest against [1], there
are 8 patches in total fixing some stuff and adding VC6 support.
[1] https://patchwork.kernel.org/patch/9831797/
> ---
> Documentation/devicetree/bindings/clock/idt,versaclock5.txt | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> index 53d7e50..a1ad9e0 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> @@ -6,19 +6,21 @@ from 3 to 12 output clocks.
> ==I2C device node==
>
> Required properties:
> -- compatible: shall be one of "idt,5p49v5923" , "idt,5p49v5933" ,
> - "idt,5p49v5935".
> +- compatible: shall be one of "idt,5p49v5923" , "idt,5p49v5925" ,
> + "idt,5p49v5933", "idt,5p49v5935".
> - reg: i2c device address, shall be 0x68 or 0x6a.
> - #clock-cells: from common clock binding; shall be set to 1.
> - clocks: from common clock binding; list of parent clock handles,
> - - 5p49v5923: (required) either or both of XTAL or CLKIN
> + - 5p49v5923 and
> + - 5p49v5925: (required) either or both of XTAL or CLKIN
> reference clock.
> - 5p49v5933 and
> - 5p49v5935: (optional) property not present (internal
> Xtal used) or CLKIN reference
> clock.
> - clock-names: from common clock binding; clock input names, can be
> - - 5p49v5923: (required) either or both of "xin", "clkin".
> + - 5p49v5923 and
> + - 5p49v5925: (required) either or both of "xin", "clkin".
> - 5p49v5933 and
> - 5p49v5935: (optional) property not present or "clkin".
>
> @@ -37,6 +39,7 @@ clock specifier, the following mapping applies:
> 1 -- OUT1
> 2 -- OUT4
>
> +5P49V5925 and
> 5P49V5935:
> 0 -- OUT0_SEL_I2CB
> 1 -- OUT1
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-07-09 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 1:57 [PATCH 0/2] clk: vc5: Add IDT VersaClock 5P49V5925 Vladimir Barinov
2017-07-07 1:57 ` [PATCH 1/2] clk: vc5: Add support for " Vladimir Barinov
2017-07-09 13:29 ` Marek Vasut
2017-07-07 1:57 ` [PATCH 2/2] dt: Add bindings " Vladimir Barinov
2017-07-09 13:31 ` Marek Vasut [this message]
2017-07-09 17:38 ` Vladimir Barinov
2017-07-09 17:42 ` Marek Vasut
2020-04-04 16:15 [PATCH 1/2] clk: vc5: Add support for IDT VersaClock 5P49V6965 Adam Ford
2020-04-04 16:15 ` [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925 Adam Ford
2020-04-14 18:15 ` Rob Herring
2020-05-29 4:05 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57a23b45-9514-00c0-aa92-00a54d68ad2e@gmail.com \
--to=marek.vasut@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).