linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>,
	andy.gross@linaro.org, david.brown@linaro.org,
	jassisinghbrar@gmail.com, mark.rutland@arm.com,
	mturquette@baylibre.com, robh+dt@kernel.org, will.deacon@arm.com
Cc: bjorn.andersson@linaro.org, vkoul@kernel.org,
	niklas.cassel@linaro.org, sibis@codeaurora.org,
	georgi.djakov@linaro.org, arnd@arndb.de,
	horms+renesas@verge.net.au, heiko@sntech.de,
	enric.balletbo@collabora.com, jagan@amarulasolutions.com,
	olof@lixom.net, amit.kucheria@linaro.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH 05/13] clk: qcom: apcs-msm8916: get parent clock names from DT
Date: Tue, 18 Dec 2018 09:37:29 +0100	[thread overview]
Message-ID: <57ef23b0-9c6b-cdd4-9a1a-41c6d5b3aa93@linaro.org> (raw)
In-Reply-To: <154508986359.19322.1555129141976726505@swboyd.mtv.corp.google.com>

On 12/18/18 00:37, Stephen Boyd wrote:
> Quoting Jorge Ramirez-Ortiz (2018-12-17 01:46:22)
>> Allow accessing the parent clock names required for the driver
>> operation by using the device tree node.
>>
>> This permits extending the driver to other platforms without having to
>> modify its source code.
>>
>> For backwards compatibility leave previous values as default.
> Why do we need to maintain backwards compatibility? Isn't is required
> that the nodes have clocks properties?
>
>

this driver -apcs clock controller- uses platform data (not DT) and 
therefore it uses the DT from the parent node (mailbox).
And for the mailbox the clock property is optional.

So the APCS clock controller requires that the parent provides at least 
one clock but the clock is not mandatory in the parent DT node.
For instance in the case of the msm8916, the parent only provides one 
clock, just the pll.

am I required to modify that platform instead of maintaining backwards 
compatibility?






  reply	other threads:[~2018-12-18  8:37 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17  9:46 [PATCH 00/13] Support CPU frequency scaling on QCS404 Jorge Ramirez-Ortiz
2018-12-17  9:46 ` [PATCH 01/13] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency Jorge Ramirez-Ortiz
2018-12-21 11:19   ` Taniya Das
2018-12-21 12:36     ` Jorge Ramirez
2018-12-21 17:58       ` Taniya Das
2018-12-21 19:28         ` Bjorn Andersson
2018-12-21 19:45           ` Jorge Ramirez
2018-12-21 21:40             ` Stephen Boyd
2018-12-21 21:45               ` Jorge Ramirez
2018-12-21 21:51                 ` Stephen Boyd
2018-12-17  9:46 ` [PATCH 02/13] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-01-17  6:25   ` Bjorn Andersson
2018-12-17  9:46 ` [PATCH 03/13] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
2019-01-17  6:25   ` Bjorn Andersson
2018-12-17  9:46 ` [PATCH 04/13] dt-bindings: mailbox: qcom: Add clock-name optional property Jorge Ramirez-Ortiz
2018-12-20 21:37   ` Rob Herring
2019-01-17  6:44   ` Bjorn Andersson
2019-01-28 16:57     ` Jorge Ramirez
2019-01-28 17:46       ` Jorge Ramirez
2018-12-17  9:46 ` [PATCH 05/13] clk: qcom: apcs-msm8916: get parent clock names from DT Jorge Ramirez-Ortiz
2018-12-17 23:37   ` Stephen Boyd
2018-12-18  8:37     ` Jorge Ramirez [this message]
2018-12-18 14:35     ` Niklas Cassel
2018-12-26  9:20       ` Jorge Ramirez
2018-12-28 22:28         ` Stephen Boyd
2018-12-31  8:42           ` Jorge Ramirez
2019-01-17  6:54             ` Bjorn Andersson
2018-12-28 22:27       ` Stephen Boyd
2018-12-17  9:46 ` [PATCH 06/13] clk: qcom: hfpll: " Jorge Ramirez-Ortiz
2019-01-17  6:27   ` Bjorn Andersson
2018-12-17  9:46 ` [PATCH 07/13] clk: qcom: hfpll: register as clock provider Jorge Ramirez-Ortiz
2019-01-17  6:28   ` Bjorn Andersson
2018-12-17  9:46 ` [PATCH 08/13] clk: qcom: hfpll: CLK_IGNORE_UNUSED Jorge Ramirez-Ortiz
2019-01-17  6:33   ` Bjorn Andersson
2019-01-17  8:38     ` Jorge Ramirez
2019-01-17 10:08       ` Viresh Kumar
2019-01-17 10:46         ` Jorge Ramirez
2019-01-22 18:47           ` Stephen Boyd
2019-01-22 19:35             ` Jorge Ramirez
2018-12-17  9:46 ` [PATCH 09/13] arm64: dts: qcom: qcs404: Add OPP table Jorge Ramirez-Ortiz
2019-01-17  6:35   ` Bjorn Andersson
2018-12-17  9:46 ` [PATCH 10/13] arm64: dts: qcom: qcs404: Add HFPLL node Jorge Ramirez-Ortiz
2018-12-17 19:39   ` Stephen Boyd
2019-01-17  6:38     ` Bjorn Andersson
2019-01-22 18:49       ` Stephen Boyd
2018-12-17  9:46 ` [PATCH 11/13] arm64: dts: qcom: qcs404: Add the clocks for APCS mux/divider Jorge Ramirez-Ortiz
2019-01-17  6:35   ` Bjorn Andersson
2018-12-17  9:46 ` [PATCH 12/13] arm64: dts: qcom: qcs404: Add cpufreq support Jorge Ramirez-Ortiz
2019-01-17  6:36   ` Bjorn Andersson
2018-12-17  9:46 ` [PATCH 13/13] arm64: defconfig: Enable HFPLL Jorge Ramirez-Ortiz
2019-01-17  6:36   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57ef23b0-9c6b-cdd4-9a1a-41c6d5b3aa93@linaro.org \
    --to=jorge.ramirez-ortiz@linaro.org \
    --cc=amit.kucheria@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=enric.balletbo@collabora.com \
    --cc=georgi.djakov@linaro.org \
    --cc=heiko@sntech.de \
    --cc=horms+renesas@verge.net.au \
    --cc=jagan@amarulasolutions.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=niklas.cassel@linaro.org \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sibis@codeaurora.org \
    --cc=vkoul@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).