From: Jian Hu <jian.hu@amlogic.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Qiufang Dai <qiufang.dai@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>,
Chandle Zou <chandle.zou@amlogic.com>,
<linux-clk@vger.kernel.org>, <linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 0/7] add Amlogic A1 clock controller driver
Date: Mon, 2 Dec 2019 14:01:47 +0800 [thread overview]
Message-ID: <63d776af-6ded-02d2-cc34-1b3733e2625b@amlogic.com> (raw)
In-Reply-To: <1jwobi7lcy.fsf@starbuckisacylon.baylibre.com>
On 2019/11/29 23:28, Jerome Brunet wrote:
>
> On Fri 29 Nov 2019 at 15:45, Jian Hu <jian.hu@amlogic.com> wrote:
>
>> add support for Amlogic A1 clock driver, the clock includes
>> three parts: peripheral clocks, pll clocks, CPU clocks.
>> sys pll and CPU clocks will be sent in next patch.
>>
>> Changes since v1 at [2]:
>
> v2 or v1 ??
It is v2 here, I will fix it in next version.
>
>> -add probe function for A1
>> -seperate the clock driver into two patch
>> -change some clock flags and ops
>> -add support for a1 PLL ops
>> -add A1 clock node
>>
>> Changes since v1 at [1]:
>> -place A1 config alphabetically
>> -add actual reason for RO ops, CLK_IS_CRITICAL, CLK_IGNORE_UNUSED
>> -separate the driver into two driver: peripheral and pll driver
>> -delete CLK_IGNORE_UNUSED flag for pwm b/c/d/e/f clock, dsp clock
>> -delete the change in Kconfig.platforms, address to Kevin alone
>> -remove the useless comments
>> -modify the meson pll driver to support A1 PLLs
>>
>> [1] https://lkml.kernel.org/r/1569411888-98116-1-git-send-email-jian.hu@amlogic.com
>> [2] https://lkml.kernel.org/r/1571382865-41978-1-git-send-email-jian.hu@amlogic.com
>>
>> Jian Hu (7):
>> dt-bindings: clock: meson: add A1 PLL clock controller bindings
>> clk: meson: add support for A1 PLL clock ops
>> clk: meson: eeclk: refactor eeclk common driver to support A1
>> clk: meson: a1: add support for Amlogic A1 PLL clock driver
>> dt-bindings: clock: meson: add A1 peripheral clock controller bindings
>> clk: meson: a1: add support for Amlogic A1 Peripheral clock driver
>> arm64: dts: meson: add A1 PLL and periphs clock controller
>
> The arm64 is for the DT maintainer. Please send it separately after this
> series is applied (if it gets applied)
>
>> Please fix the underlying issue, then you can post your series again.
>
> This was a comment on your v2. Did you fix the orphan/ordering issue ?
> If you did, you probably should mention it here.
Yes, I have fixed it in A1 periphs driver, not fixed it in CCF.
I have realised a probe function for A1 periphs driver, Not using the
common probe interface in meson-eeclk.c. Skip registering xtal_fixedpll
and xtal_hifipll clocks when register all periphs clocks. And after the
provider registration. Registering xtal_fixedpll and xtal_hifipll clock
alone.
I will add some comments here about orphan issue.
And I have noticed you have fixed it in CCF, I will update the A1
periphs driver, drop the probe function in the next vertion.
Could I send the v4 after your patch 'clk: walk orphan list on clock
provider registration' is applied? Or I can send v4 based on your patch now.
> If you did not, I'm probably not going to review this further until you do.
>
>>
>> .../bindings/clock/amlogic,a1-clkc.yaml | 70 +
>> .../bindings/clock/amlogic,a1-pll-clkc.yaml | 56 +
>> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 26 +
>> drivers/clk/meson/Kconfig | 20 +
>> drivers/clk/meson/Makefile | 2 +
>> drivers/clk/meson/a1-pll.c | 334 +++
>> drivers/clk/meson/a1-pll.h | 56 +
>> drivers/clk/meson/a1.c | 2309 +++++++++++++++++
>> drivers/clk/meson/a1.h | 120 +
>> drivers/clk/meson/clk-pll.c | 21 +
>> drivers/clk/meson/clk-pll.h | 1 +
>> drivers/clk/meson/meson-eeclk.c | 59 +-
>> drivers/clk/meson/meson-eeclk.h | 2 +
>> drivers/clk/meson/parm.h | 1 +
>> include/dt-bindings/clock/a1-clkc.h | 98 +
>> include/dt-bindings/clock/a1-pll-clkc.h | 16 +
>> 16 files changed, 3181 insertions(+), 10 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml
>> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>> create mode 100644 drivers/clk/meson/a1-pll.c
>> create mode 100644 drivers/clk/meson/a1-pll.h
>> create mode 100644 drivers/clk/meson/a1.c
>> create mode 100644 drivers/clk/meson/a1.h
>> create mode 100644 include/dt-bindings/clock/a1-clkc.h
>> create mode 100644 include/dt-bindings/clock/a1-pll-clkc.h
>
> .
>
prev parent reply other threads:[~2019-12-02 6:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 14:45 [PATCH v3 0/7] add Amlogic A1 clock controller driver Jian Hu
2019-11-29 14:45 ` [PATCH v3 1/7] dt-bindings: clock: meson: add A1 PLL clock controller bindings Jian Hu
2019-11-29 14:46 ` [PATCH v3 2/7] clk: meson: add support for A1 PLL clock ops Jian Hu
2019-11-29 14:46 ` [PATCH v3 3/7] clk: meson: eeclk: refactor eeclk common driver to support A1 Jian Hu
2019-11-29 14:46 ` [PATCH v3 4/7] clk: meson: a1: add support for Amlogic A1 PLL clock driver Jian Hu
2019-11-29 14:46 ` [PATCH v3 5/7] dt-bindings: clock: meson: add A1 peripheral clock controller bindings Jian Hu
2019-11-29 14:46 ` [PATCH v3 6/7] clk: meson: a1: add support for Amlogic A1 Peripheral clock driver Jian Hu
2019-11-29 14:46 ` [PATCH v3 7/7] arm64: dts: meson: add A1 PLL and periphs clock controller Jian Hu
2019-11-29 15:28 ` [PATCH v3 0/7] add Amlogic A1 clock controller driver Jerome Brunet
2019-12-02 6:01 ` Jian Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d776af-6ded-02d2-cc34-1b3733e2625b@amlogic.com \
--to=jian.hu@amlogic.com \
--cc=chandle.zou@amlogic.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=qiufang.dai@amlogic.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=victor.wan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).