From: Taniya Das <tdas@codeaurora.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>,
mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
marc.w.gonzalez@free.fr, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v9 1/4] dt-bindings: clock: Document external clocks for MSM8998 gcc
Date: Wed, 13 Nov 2019 16:50:55 +0530 [thread overview]
Message-ID: <63e2cdd2-919d-9ec2-9fe8-48bbe34f732c@codeaurora.org> (raw)
In-Reply-To: <1573591466-14296-1-git-send-email-jhugo@codeaurora.org>
Hi Jeffrey,
On 11/13/2019 2:14 AM, Jeffrey Hugo wrote:
> The global clock controller on MSM8998 can consume a number of external
> clocks. Document them.
>
> For 7180 and 8150, the hardware always exists, so no clocks are truly
> optional. Therefore, simplify the binding by removing the min/max
> qualifiers to clocks. Also, fixup an example so that dt_binding_check
> passes.
>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---
> .../devicetree/bindings/clock/qcom,gcc.yaml | 47 +++++++++++++++-------
> 1 file changed, 33 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> index e73a56f..2f3512b 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> @@ -40,20 +40,38 @@ properties:
> - qcom,gcc-sm8150
>
> clocks:
> - minItems: 1
> - maxItems: 3
> - items:
> - - description: Board XO source
> - - description: Board active XO source
> - - description: Sleep clock source
> + oneOf:
> + #qcom,gcc-sm8150
> + #qcom,gcc-sc7180
> + - items:
> + - description: Board XO source
> + - description: Board active XO source
> + - description: Sleep clock source
> + #qcom,gcc-msm8998
> + - items:
> + - description: Board XO source
> + - description: USB 3.0 phy pipe clock
> + - description: UFS phy rx symbol clock for pipe 0
> + - description: UFS phy rx symbol clock for pipe 1
> + - description: UFS phy tx symbol clock
> + - description: PCIE phy pipe clock
Would it be possible to add an example for MSM8998?
>
> clock-names:
> - minItems: 1
> - maxItems: 3
> - items:
> - - const: bi_tcxo
> - - const: bi_tcxo_ao
> - - const: sleep_clk
> + oneOf:
> + #qcom,gcc-sm8150
> + #qcom,gcc-sc7180
> + - items:
> + - const: bi_tcxo
> + - const: bi_tcxo_ao
> + - const: sleep_clk
Not required for SC7180.
> + #qcom,gcc-msm8998
> + - items:
> + - const: xo
> + - const: usb3_pipe
> + - const: ufs_rx_symbol0
> + - const: ufs_rx_symbol1
> + - const: ufs_tx_symbol0
> + - const: pcie0_pipe
>
> '#clock-cells':
> const: 1
> @@ -118,6 +136,7 @@ else:
> compatible:
> contains:
> enum:
> + - qcom,gcc-msm8998
> - qcom,gcc-sm8150
> - qcom,gcc-sc7180
> then:
> @@ -179,8 +198,8 @@ examples:
> clock-controller@100000 {
> compatible = "qcom,gcc-sc7180";
> reg = <0x100000 0x1f0000>;
> - clocks = <&rpmhcc 0>, <&rpmhcc 1>;
> - clock-names = "bi_tcxo", "bi_tcxo_ao";
> + clocks = <&rpmhcc 0>, <&rpmhcc 1>, <0>;
> + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk";
SC7180 does not require a sleep clock.
> #clock-cells = <1>;
> #reset-cells = <1>;
> #power-domain-cells = <1>;
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
next prev parent reply other threads:[~2019-11-13 11:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 20:43 [PATCH v9 0/4] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-11-12 20:44 ` [PATCH v9 1/4] dt-bindings: clock: Document external clocks for MSM8998 gcc Jeffrey Hugo
2019-11-13 11:20 ` Taniya Das [this message]
2019-11-13 15:02 ` Jeffrey Hugo
2019-11-14 17:58 ` Rob Herring
2019-11-12 20:44 ` [PATCH v9 2/4] dt-bindings: clock: Convert qcom,mmcc to DT schema Jeffrey Hugo
2019-11-12 20:45 ` [PATCH v9 3/4] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-11-12 20:45 ` [PATCH v9 4/4] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63e2cdd2-919d-9ec2-9fe8-48bbe34f732c@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).