From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11263C04FF3 for ; Mon, 24 May 2021 20:25:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0B886140B for ; Mon, 24 May 2021 20:25:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232829AbhEXU0k (ORCPT ); Mon, 24 May 2021 16:26:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232676AbhEXU0k (ORCPT ); Mon, 24 May 2021 16:26:40 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8848C061574; Mon, 24 May 2021 13:25:10 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id c15so35252316ljr.7; Mon, 24 May 2021 13:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=g9hgNwmOuDP5DthgeuaSKULnhUo7ubNRfZKms1Tzv8E=; b=uK3ppJAGePAn590fa0VNgjuAvFP6VPLQ4E6Zcop0dEpa33bKhMkltSH1KrnoPw2liA gzgY5alIPL4LDkf8ok2by6JZRu0bedLT7p8Gq1Im66WB3yfmDtjZ26R/zsfeVyyOQSUL o/JCpoMy58arwwyhOlPq4nU8vzCyJad12WNXBajLRRYL1Q59ZxRLi9CKbI8zfa43cwia cCm+ATVNeB0rxXMvb36poYjerFWKlBawfzoOrEDXXf3EWMNdwag92wvRYQzFwKMjSvP3 yhwfWuDuJVFaz968/q84ArWT0H72LPXY3kWvqhMEC7ocOFHXwj+Vtc5Yamkw4B+uu5KW mQYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=g9hgNwmOuDP5DthgeuaSKULnhUo7ubNRfZKms1Tzv8E=; b=OUCUPs3N6S48yohq4uHpJCez7jX6NkYIOAX6adPHTWOfXoUrXLbWmBbNTQ4eM3xsdM LstcaDB7iQiWa+AfuDzt1nrvHQnyQuVB+QCFlzYO7c5vDkYcADZM8mwP63gYGKIHyAJ2 1b7fnTYAHF7do5RFWEsm8993kKPXhmGXIsAb2rk5PNHWCrSw8cdBYNB4SqOgt7VOggh0 /4cBeqE1GJ8nIGUgsBYHA3BeDKebhZVhuY0JuDmtL5UB61pg6EnTwIv6yvOBTkOQMyW/ lcuJEg2KCIohF/Iqo4L9JZ3H2vdrdfzLnkPr6a9khQEhcPeydBzIUfJNQNswvBaW745d hAhg== X-Gm-Message-State: AOAM53072oR2Gnns+kJW7cN6NQ+Zi3CAMxvNGL9C56E6eYniH/UcX5my Fr9ALqZv7XW35jmieYtD9BQfS8SYuYs= X-Google-Smtp-Source: ABdhPJwIo76DFE3Csz9R+vPmfQuF0txDCYX+lFv5TGE4as15O/HmFYS80FS1l9HZDl3DZ5jfU1mC5Q== X-Received: by 2002:a2e:95c6:: with SMTP id y6mr18642398ljh.155.1621887909009; Mon, 24 May 2021 13:25:09 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-110.dynamic.spd-mgts.ru. [109.252.193.110]) by smtp.googlemail.com with ESMTPSA id x68sm1508832lff.92.2021.05.24.13.25.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 13:25:08 -0700 (PDT) Subject: Re: [PATCH v2 13/14] soc/tegra: pmc: Add core power domain To: Ulf Hansson Cc: Thierry Reding , Jonathan Hunter , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , =?UTF-8?Q?Nikola_Milosavljevi=c4=87?= , Peter Geis , Nicolas Chauvet , Viresh Kumar , Stephen Boyd , Matt Merhar , Paul Fertser , Mark Brown , Liam Girdwood , Krzysztof Kozlowski , Mikko Perttunen , Linux Kernel Mailing List , linux-tegra , DTML , Linux PM , Nathan Chancellor , linux-clk References: <20210523231335.8238-1-digetx@gmail.com> <20210523231335.8238-14-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <65f65cb9-a25f-9c2c-2902-7e1776d66661@gmail.com> Date: Mon, 24 May 2021 23:25:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org 24.05.2021 20:04, Ulf Hansson пишет: >> +static void tegra_pmc_sync_state(struct device *dev) >> +{ >> + int err; >> + >> + pmc->core_domain_state_synced = true; >> + >> + /* this is a no-op if core regulator isn't used */ >> + mutex_lock(&pmc->powergates_lock); >> + err = dev_pm_opp_sync_regulators(dev); >> + mutex_unlock(&pmc->powergates_lock); >> + >> + if (err) >> + dev_err(dev, "failed to sync regulators: %d\n", err); >> +} >> + > Nitpick. > > Would you mind splitting the "sync_state" thingy out into a separate > patch on top of $subject patch? > > I think it would be nice, especially since it shares a function via > include/soc/tegra/common.h - that would make it clear to what part > that belongs to. > I'll split it in v3. Thank you for the review.