Linux-Clk Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] clk: meson: fix pll settings calculation with arm32
@ 2019-02-03 10:47 Jerome Brunet
  2019-02-04  8:54 ` Neil Armstrong
  0 siblings, 1 reply; 2+ messages in thread
From: Jerome Brunet @ 2019-02-03 10:47 UTC (permalink / raw)
  To: Neil Armstrong, Stephen Boyd, Michael Turquette
  Cc: Jerome Brunet, Kevin Hilman, linux-kernel, linux-clk,
	linux-amlogic, linux-arm-kernel

fix undefined reference to `__aeabi_uldivmod' when dividing
u64 on arm32.

Fixes: 496c0462b46f ("clk: meson: pll: update driver for the g12a")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---

 Neil,

 Feel free to squash this with the offending change. If you prefer,
 I can submit a v7.

 Cheers
 Jerome

 drivers/clk/meson/clk-pll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
index 7946d21a4ff4..41e16dd7272a 100644
--- a/drivers/clk/meson/clk-pll.c
+++ b/drivers/clk/meson/clk-pll.c
@@ -151,7 +151,7 @@ static unsigned int meson_clk_get_pll_range_m(unsigned long rate,
 	if (__pll_round_closest_mult(pll))
 		return DIV_ROUND_CLOSEST_ULL(val, parent_rate);
 
-	return val / parent_rate;
+	return div_u64(val,  parent_rate);
 }
 
 static int meson_clk_get_pll_range_index(unsigned long rate,
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: meson: fix pll settings calculation with arm32
  2019-02-03 10:47 [PATCH] clk: meson: fix pll settings calculation with arm32 Jerome Brunet
@ 2019-02-04  8:54 ` Neil Armstrong
  0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2019-02-04  8:54 UTC (permalink / raw)
  To: Jerome Brunet, Stephen Boyd, Michael Turquette
  Cc: Kevin Hilman, linux-kernel, linux-clk, linux-amlogic, linux-arm-kernel

On 03/02/2019 11:47, Jerome Brunet wrote:
> fix undefined reference to `__aeabi_uldivmod' when dividing
> u64 on arm32.
> 
> Fixes: 496c0462b46f ("clk: meson: pll: update driver for the g12a")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> 
>  Neil,
> 
>  Feel free to squash this with the offending change. If you prefer,
>  I can submit a v7.
> 
>  Cheers
>  Jerome
> 
>  drivers/clk/meson/clk-pll.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
> index 7946d21a4ff4..41e16dd7272a 100644
> --- a/drivers/clk/meson/clk-pll.c
> +++ b/drivers/clk/meson/clk-pll.c
> @@ -151,7 +151,7 @@ static unsigned int meson_clk_get_pll_range_m(unsigned long rate,
>  	if (__pll_round_closest_mult(pll))
>  		return DIV_ROUND_CLOSEST_ULL(val, parent_rate);
>  
> -	return val / parent_rate;
> +	return div_u64(val,  parent_rate);
>  }
>  
>  static int meson_clk_get_pll_range_index(unsigned long rate,
> 

Thanks for the fix,

I squashed it on "clk: meson: pll: update driver for the g12a"

Neil

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-03 10:47 [PATCH] clk: meson: fix pll settings calculation with arm32 Jerome Brunet
2019-02-04  8:54 ` Neil Armstrong

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org linux-clk@archiver.kernel.org
	public-inbox-index linux-clk


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/ public-inbox