Re: [PATCH v1] clk: Add devm_clk_{prepare,enable,prepare_enable}

From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Guenter Roeck <linux@roeck-us.net>,
	Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk <linux-clk@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH v1] clk: Add devm_clk_{prepare,enable,prepare_enable}
Date: Tue, 16 Jul 2019 10:18:30 +0200	[thread overview]
Message-ID: <71456cc6-d3fb-6d90-c853-fc460a207c55@free.fr> (raw)
In-Reply-To: <ec00d8d0-6551-274c-8a8d-a9d4c5b45d7c@roeck-us.net>

On 16/07/2019 02:25, Guenter Roeck wrote:

> On 7/15/19 8:34 AM, Marc Gonzalez wrote:
> 
>> Provide devm variants for automatic resource release on device removal.
>> probe() error-handling is simpler, and remove is no longer required.
>>
>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> 
> Again ?
> 
> https://lore.kernel.org/patchwork/patch/755667/

IMHO, my proposal is very simple and (somewhat) easier to review.

I'm sure it will enthrall Stephen/Mike, thus they'll merge it in a heart-beat ^_^

> This must be at least the third time this is tried. I don't think anything changed
> since the previous submissions. I long since gave up and use devm_add_action_or_reset()
> in affected drivers instead.

"Tonight's the night we're gonna make it happen
Tonight we'll put all other things aside" ^_^

It's silly to have driver authors worry about probe() error-handling
in 2020. (What? It's not 2020 yet?!)

If I could get two or three reviews, it would help to show support
for this essential, yet still missing, API.

Regards.