linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PM / devfreq: tegra30: add COMMON_CLK dependency
@ 2019-12-13  4:47 ` Kuninori Morimoto
  2019-12-13  4:57   ` Chanwoo Choi
  0 siblings, 1 reply; 4+ messages in thread
From: Kuninori Morimoto @ 2019-12-13  4:47 UTC (permalink / raw)
  To: Arnd Bergmann, MyungJoo Ham, Kyungmin Park, Chanwoo Choi,
	Dmitry Osipenko
  Cc: linux-pm, Enrico Weigelt, metux IT consult, Michael Turquette,
	linux-clk, Stephen Boyd


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Compile-testing the new driver on platforms without CONFIG_COMMON_CLK
leads to a link error:

	drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
	tegra30-devfreq.c:(.text+0x288): undefined reference to `clk_set_min_rate'

Add a dependency on COMMON_CLK to avoid this.

Fixes: 35f8dbc727212 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/devfreq/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index defe1d4..a78191c 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -94,6 +94,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
 
 config ARM_TEGRA_DEVFREQ
 	tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
+	depends on COMMON_CLK
 	depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
 		ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
 		ARCH_TEGRA_210_SOC || \
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] PM / devfreq: tegra30: add COMMON_CLK dependency
  2019-12-13  4:47 ` [PATCH] PM / devfreq: tegra30: add COMMON_CLK dependency Kuninori Morimoto
@ 2019-12-13  4:57   ` Chanwoo Choi
  2019-12-13  5:09     ` Kuninori Morimoto
  0 siblings, 1 reply; 4+ messages in thread
From: Chanwoo Choi @ 2019-12-13  4:57 UTC (permalink / raw)
  To: Kuninori Morimoto, Arnd Bergmann, MyungJoo Ham, Kyungmin Park,
	Dmitry Osipenko
  Cc: linux-pm, Enrico Weigelt, metux IT consult, Michael Turquette,
	linux-clk, Stephen Boyd

On 12/13/19 1:47 PM, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Compile-testing the new driver on platforms without CONFIG_COMMON_CLK
> leads to a link error:
> 
> 	drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
> 	tegra30-devfreq.c:(.text+0x288): undefined reference to `clk_set_min_rate'
> 
> Add a dependency on COMMON_CLK to avoid this.
> 
> Fixes: 35f8dbc727212 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver")
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  drivers/devfreq/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index defe1d4..a78191c 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -94,6 +94,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
>  
>  config ARM_TEGRA_DEVFREQ
>  	tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
> +	depends on COMMON_CLK
>  	depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
>  		ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
>  		ARCH_TEGRA_210_SOC || \
> 

Thanks for the fixup.

But, it was merged as following:
- https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?h=devfreq-next&id=252ef98ed524612667e2e2a0ce065fe21e80ec93

Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] PM / devfreq: tegra30: add COMMON_CLK dependency
  2019-12-13  4:57   ` Chanwoo Choi
@ 2019-12-13  5:09     ` Kuninori Morimoto
  2019-12-17  5:12       ` Kuninori Morimoto
  0 siblings, 1 reply; 4+ messages in thread
From: Kuninori Morimoto @ 2019-12-13  5:09 UTC (permalink / raw)
  To: Chanwoo Choi
  Cc: Arnd Bergmann, MyungJoo Ham, Kyungmin Park, Dmitry Osipenko,
	linux-pm, Enrico Weigelt, metux IT consult, Michael Turquette,
	linux-clk, Stephen Boyd


Hi Chanwoo

> > Compile-testing the new driver on platforms without CONFIG_COMMON_CLK
> > leads to a link error:
> > 
> > 	drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
> > 	tegra30-devfreq.c:(.text+0x288): undefined reference to `clk_set_min_rate'
> > 
> > Add a dependency on COMMON_CLK to avoid this.
> > 
> > Fixes: 35f8dbc727212 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver")
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
(snip)
> Thanks for the fixup.
> 
> But, it was merged as following:
> - https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?h=devfreq-next&id=252ef98ed524612667e2e2a0ce065fe21e80ec93

Thanks, nice to know !!


Thank you for your help !!
Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] PM / devfreq: tegra30: add COMMON_CLK dependency
  2019-12-13  5:09     ` Kuninori Morimoto
@ 2019-12-17  5:12       ` Kuninori Morimoto
  0 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2019-12-17  5:12 UTC (permalink / raw)
  To: Chanwoo Choi
  Cc: Arnd Bergmann, MyungJoo Ham, Kyungmin Park, Dmitry Osipenko,
	linux-pm, Enrico Weigelt, metux IT consult, Michael Turquette,
	linux-clk, Stephen Boyd


Hi Chanwoo again

> > > Compile-testing the new driver on platforms without CONFIG_COMMON_CLK
> > > leads to a link error:
> > > 
> > > 	drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
> > > 	tegra30-devfreq.c:(.text+0x288): undefined reference to `clk_set_min_rate'
> > > 
> > > Add a dependency on COMMON_CLK to avoid this.
> > > 
> > > Fixes: 35f8dbc727212 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver")
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> (snip)
> > Thanks for the fixup.
> > 
> > But, it was merged as following:
> > - https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?h=devfreq-next&id=252ef98ed524612667e2e2a0ce065fe21e80ec93

It is for v5.6 ?
SH needs it for v5.5-rcX

Thank you for your help !!
Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-17  5:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20191213044804epcas1p34eaf8872b5688c01255931c79bfd0ef0@epcas1p3.samsung.com>
2019-12-13  4:47 ` [PATCH] PM / devfreq: tegra30: add COMMON_CLK dependency Kuninori Morimoto
2019-12-13  4:57   ` Chanwoo Choi
2019-12-13  5:09     ` Kuninori Morimoto
2019-12-17  5:12       ` Kuninori Morimoto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).