From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD29C2D0CD for ; Tue, 17 Dec 2019 05:12:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A82A524687 for ; Tue, 17 Dec 2019 05:12:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727715AbfLQFMs (ORCPT ); Tue, 17 Dec 2019 00:12:48 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:16909 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726920AbfLQFMs (ORCPT ); Tue, 17 Dec 2019 00:12:48 -0500 Date: 17 Dec 2019 14:12:46 +0900 X-IronPort-AV: E=Sophos;i="5.69,324,1571670000"; d="scan'208";a="34401499" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 17 Dec 2019 14:12:46 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 7A74B400965A; Tue, 17 Dec 2019 14:12:46 +0900 (JST) Message-ID: <87immfh6wh.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Chanwoo Choi Cc: Arnd Bergmann , MyungJoo Ham , Kyungmin Park , Dmitry Osipenko , linux-pm@vger.kernel.org, "Enrico Weigelt, metux IT consult" , Michael Turquette , linux-clk@vger.kernel.org, Stephen Boyd Subject: Re: [PATCH] PM / devfreq: tegra30: add COMMON_CLK dependency In-Reply-To: <87sglo4xr0.wl-kuninori.morimoto.gx@renesas.com> References: <87v9qk4yrk.wl-kuninori.morimoto.gx@renesas.com> <23cc9bbb-f6a4-fc1c-7678-79040d3a18aa@samsung.com> <87sglo4xr0.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Chanwoo again > > > Compile-testing the new driver on platforms without CONFIG_COMMON_CLK > > > leads to a link error: > > > > > > drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target': > > > tegra30-devfreq.c:(.text+0x288): undefined reference to `clk_set_min_rate' > > > > > > Add a dependency on COMMON_CLK to avoid this. > > > > > > Fixes: 35f8dbc727212 ("PM / devfreq: tegra: Enable COMPILE_TEST for the driver") > > > Signed-off-by: Kuninori Morimoto > > > --- > (snip) > > Thanks for the fixup. > > > > But, it was merged as following: > > - https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?h=devfreq-next&id=252ef98ed524612667e2e2a0ce065fe21e80ec93 It is for v5.6 ? SH needs it for v5.5-rcX Thank you for your help !! Best regards --- Kuninori Morimoto