From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Gregory CLEMENT To: Stephen Boyd Cc: Mike Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Nadav Haklai , Victor Gu , Romain Perier , Omri Itach , Marcin Wojtas , Wilson Ding , Shadi Ammouri Subject: Re: [PATCH 10/10] clk: mvebu: Add the peripheral clock driver for Armada 3700 References: <1465565018-14172-1-git-send-email-gregory.clement@free-electrons.com> <1465565018-14172-11-git-send-email-gregory.clement@free-electrons.com> <20160630200007.GB1521@codeaurora.org> Date: Fri, 08 Jul 2016 01:12:42 +0200 In-Reply-To: <20160630200007.GB1521@codeaurora.org> (Stephen Boyd's message of "Thu, 30 Jun 2016 13:00:07 -0700") Message-ID: <87shvlujo5.fsf@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain List-ID: Hi Stephen, On jeu., juin 30 2016, Stephen Boyd wrote: >> + >> + spin_lock_init(&driver_data->lock); >> + >> + for (i = 0; i < num_periph; i++) { >> + struct clk *clk = driver_data->clk_data.clks[i]; >> + >> + if (armada_3700_add_composite_clk(&data[i], parent_name, reg, >> + &driver_data->lock, dev, clk)) >> + dev_err(dev, "Can't register periph clock %s\n", >> + data[i].name); >> + } >> + >> + ret = of_clk_add_provider(np, of_clk_src_onecell_get, >> + &driver_data->clk_data); >> + if (ret) { >> + for (i = 0; i < num_periph; i++) >> + clk_unregister(driver_data->clk_data.clks[i]); > > It would be nice if we had devm_* registration in composite > clks > This comment is the only one I didn't take into account in the second version I've just sent. I agree it would be nice and I am willing to add it. However these last days I was very busy with the birth of my last child: I managed to find time to write this second version in time to be merged for 4.8 but not enough to add these new function. I will try to send a patch for it next week. Thanks for your review, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com