From: Matthias Brugger <matthias.bgg@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>,
matthias.bgg@kernel.org, mturquette@baylibre.com,
Kevin-CW Chen <kevin-cw.chen@mediatek.com>
Cc: jasu@njomotys.info, sean.wang@kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH v2 0/3] Mark clocks as critical for MT6797
Date: Fri, 30 Nov 2018 10:04:02 +0100 [thread overview]
Message-ID: <8e8b9c0f-7647-daa4-504b-7b86bcd45a04@gmail.com> (raw)
In-Reply-To: <154356044342.88331.13729809794593193239@swboyd.mtv.corp.google.com>
On 30/11/2018 07:47, Stephen Boyd wrote:
> Quoting matthias.bgg@kernel.org (2018-11-16 10:08:58)
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> Jasper send this series some month ago. As there was no reaction from
>> his side, I'll do a friendly take-over.
>> I tested the patches on my Helios X20 boards and they fix the issue.
>> I didn't add a Tested-by tag as I added my Signed-off-by.
>>
>> Changes since v1:
>> - add a fixes tag.
>>
>> ---
>>
>> Currently, DRAM-related clocks and the axi_sel MUX are not marked with
>> CLK_IS_CRITICAL for MT6797. This causes memory corruption when the
>> system is booted without clk_ignore_unused.
>>
>> This patchset
>>
>> 1. Makes it possible to mark outputs of MUXes as critical by introducing
>> a new macro, MUX_FLAGS,
>> 2. Makes it possible to mark gates as critical by adding flags to
>> mtk_gate, and
>> 3. Marks axi_sel, ddrphycfg_sel, infra_dramc_f26m and infra_dramc_b_f26m
>> as critical.
>>
>> The addition of flags to mtk_gate also exists in the patch series "Add
>> basic and clock support for Mediatek MT8183 SoC" [1]. The type of
>> flags is unsigned int in that series, but the real type is unsigned
>> long, so my patch differs from that patch.
>
> Will anyone from Mediatek review this? Why aren't the people who signed
> off on drivers/clk/mediatek/clk-mt6797.c included on this patch series?
> They no longer work there?
>
My fault, I'll resend 3/3 with the comments you made. Added Kevin-CW now...
next prev parent reply other threads:[~2018-11-30 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 18:08 [PATCH v2 0/3] Mark clocks as critical for MT6797 matthias.bgg
2018-11-16 18:08 ` [PATCH v2 1/3] clk: mediatek: Add MUX_FLAGS macro matthias.bgg
2018-11-16 18:09 ` [PATCH v2 2/3] clk: mediatek: Add flags to mtk_gate matthias.bgg
2018-11-30 6:50 ` Stephen Boyd
2018-11-16 18:09 ` [PATCH v2 3/3] clk: mediatek: Mark bus and DRAM related clocks as critical matthias.bgg
2018-11-30 6:48 ` Stephen Boyd
2018-11-30 6:47 ` [PATCH v2 0/3] Mark clocks as critical for MT6797 Stephen Boyd
2018-11-30 9:04 ` Matthias Brugger [this message]
2019-01-07 20:56 ` Stephen Boyd
2019-01-08 3:05 ` Mars Cheng
2019-01-08 9:55 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e8b9c0f-7647-daa4-504b-7b86bcd45a04@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=jasu@njomotys.info \
--cc=kevin-cw.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=sean.wang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).