From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE8BC4332F for ; Tue, 21 Sep 2021 07:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A99B860E76 for ; Tue, 21 Sep 2021 07:23:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230173AbhIUHY0 (ORCPT ); Tue, 21 Sep 2021 03:24:26 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:36832 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230129AbhIUHY0 (ORCPT ); Tue, 21 Sep 2021 03:24:26 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id AF94740261 for ; Tue, 21 Sep 2021 07:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632208977; bh=Cve5VR1QaxZM6zIVHTuhZn6XwrsbWxHHOPyFzizDJOw=; h=Subject:From:To:Cc:References:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=LSaX+NNYmtKaMHZc+jMNh4LhvdiDlQ/00FmmBttIsHz4Y/Ako8b9QQh4eIfUxOrlw B4fh/vPlUzc5UA4G0DVRJrFMFaU9QCoWksfkw2/h+4eOFpbgHWCEEibf79nql9343W YbbTUv+h6kKTYCc2YLD4852GuwHKUI6FvvGQ5KPbeOEwIgYNvi4hmRcej5yvPqDxx6 s+2RXlcO+NfK/QOa6+ZboKadWRppvDdB6pYxptW7Qz4iYfjdrbV+A1dzrK/zxlbP8R F+gE7NkWY3oXyYlrCI2kRxib6iyqi+mkHY+SvLj+FxPzky9BwaUPo7Nsj+OgbrHal6 vS2kBkdSsG9uw== Received: by mail-wr1-f71.google.com with SMTP id c15-20020a5d4ccf000000b0015dff622f39so8034320wrt.21 for ; Tue, 21 Sep 2021 00:22:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Cve5VR1QaxZM6zIVHTuhZn6XwrsbWxHHOPyFzizDJOw=; b=0MDwfmvf0OIEMMtuoyAKETKS8PUgfwABnE0AHFAnre731VY/DOSUuJ9Wv3mDPN7yFZ OEyhXZ0fEOG7ee9GW61qYo0UJPPTmyyhvn7+ravlBOO1ezEPUXrsHT4mtBWjOcOxmywm G0zFfoBh3vL1A/7qp7rDNgXso66oHb3GUWJR141ISIqDXuW6K+3rm+we8TOFVRT+wqfz f24gLm1oVqwciqkEQM7guf7RI2Rt1FwTf7nh3ZIiHikKMenmnSIUFly8vXxI5SOtjuy3 TBBOEBfKfN7DUa4FH+J1I+yNxEufR+jjiAfdY0l4NAmh+rzyLsox0v0befAqXCzDokdp maSw== X-Gm-Message-State: AOAM531mVYGkq0gggOgYpRhC+uNu+YnWL23IH0EjWTpnBRfm39d9kUWy 2j3iq+YI8ZJoibRhu72b6+V/LMkEJ9lfWsNYAkcLn0LG7ZabY7ZsWeoeo25a0ZmU9NNlJ5Li+u3 uPc+tTXOvbaHiF0NolQBqVdk7UkK+cfK8BMVKqA== X-Received: by 2002:adf:dcc1:: with SMTP id x1mr33377399wrm.415.1632208977225; Tue, 21 Sep 2021 00:22:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQw4dtnG2X2Nu2HkIk4oUuLyQI/VIi+qePjIbZ3WhkVu2uRQwXc5Ujx3o3WSA5Z6k2UAzRxA== X-Received: by 2002:adf:dcc1:: with SMTP id x1mr33377384wrm.415.1632208977082; Tue, 21 Sep 2021 00:22:57 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id r9sm10592653wru.2.2021.09.21.00.22.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 00:22:56 -0700 (PDT) Subject: Re: [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs From: Krzysztof Kozlowski To: Will McVicker , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Alessandro Zummo , Alexandre Belloni Cc: Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org References: <20210920190350.3860821-1-willmcvicker@google.com> <7735b09c-cf1c-5e37-a737-9a330fbacf1e@canonical.com> Message-ID: <96e7f057-c505-e5d7-d89a-345b98d44448@canonical.com> Date: Tue, 21 Sep 2021 09:22:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <7735b09c-cf1c-5e37-a737-9a330fbacf1e@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 21/09/2021 09:19, Krzysztof Kozlowski wrote: > On 20/09/2021 21:03, Will McVicker wrote: >> This patch series tries to address the issue of ARCH_EXYNOS force selecting >> a handful of drivers without allowing the vendor to override any of the >> default configs. This takes away from the flexibilty of compiling a generic >> kernel with exynos kernel modules. For example, it doesn't allow vendors to >> modularize these drivers out of the core kernel in order to share a generic >> kernel image across multiple devices that require device-specific kernel >> modules. > > You do not address the issue in these patches. The problem you describe > is that drivers are not modules and you are not changing them into modules. > >> >> To address this without impacting the existing behavior, this series >> switches the default config logic for the offending configs to use "default >> y if ARCH_EXYNOS" versus having ARCH_EXYNOS directly select them. I have >> verified that these patches do not impact the default aarch64 .config. > > Yep, this is what you did but it does not match the described problem. > You are not solving it but doing something else. > >> >> Will McVicker (4): >> clk: samsung: change COMMON_CLK_SAMSUNG default config logic >> soc: samsung: change SOC_SAMSUNG default config logic >> pinctrl: samsung: change PINCTRL_EXYNOS default config logic >> rtc: change HAVE_S3C_RTC default config logic >> > > > I received only two patches from this set. Please resend following > get_maintainers.pl script. For the record - samsung-soc list also did not get all your patches. NAK, please use get_maintainers.pl. Best regards, Krzysztof