From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A98EDC43603 for ; Mon, 9 Dec 2019 09:59:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81653206D5 for ; Mon, 9 Dec 2019 09:59:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727347AbfLIJ7c (ORCPT ); Mon, 9 Dec 2019 04:59:32 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:40674 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727307AbfLIJ7c (ORCPT ); Mon, 9 Dec 2019 04:59:32 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 1F91828BA5C Subject: Re: [resend PATCH v6 07/12] clk: mediatek: mt2712e: switch to platform device probing To: matthias.bgg@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, mturquette@baylibre.com, sboyd@kernel.org, ulrich.hecht+renesas@gmail.com, laurent.pinchart@ideasonboard.com Cc: sean.wang@mediatek.com, sean.wang@kernel.org, rdunlap@infradead.org, wens@csie.org, hsinyi@chromium.org, frank-w@public-files.de, drinkcat@chromium.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, mbrugger@suse.com References: <20191207224740.24536-1-matthias.bgg@kernel.org> <20191207224740.24536-8-matthias.bgg@kernel.org> From: Enric Balletbo i Serra Message-ID: <9f4f8481-66de-6ca5-f9e0-6c6fa6a857eb@collabora.com> Date: Mon, 9 Dec 2019 10:59:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191207224740.24536-8-matthias.bgg@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Matthias, On 7/12/19 23:47, matthias.bgg@kernel.org wrote: > From: Matthias Brugger > > Switch probing for the MMSYS to support invocation to a > plain paltform device. The driver will be probed by the DRM subsystem. > > Signed-off-by: Matthias Brugger > --- > drivers/clk/mediatek/clk-mt2712-mm.c | 39 +++++++++++++++++++--------- Same comments as previous patch. > 1 file changed, 27 insertions(+), 12 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-mt2712-mm.c b/drivers/clk/mediatek/clk-mt2712-mm.c > index 1c5948be35f3..d018db568263 100644 > --- a/drivers/clk/mediatek/clk-mt2712-mm.c > +++ b/drivers/clk/mediatek/clk-mt2712-mm.c > @@ -4,14 +4,20 @@ > * Author: Weiyi Lu > */ > > +#include > #include > #include > +#include > > #include "clk-mtk.h" > #include "clk-gate.h" > > #include > > +struct clk_mt2712_mm_priv { > + struct clk_onecell_data *clk_data; > +}; > + > static const struct mtk_gate_regs mm0_cg_regs = { > .set_ofs = 0x104, > .clr_ofs = 0x108, > @@ -128,16 +134,22 @@ static const struct mtk_gate mm_clks[] = { > > static int clk_mt2712_mm_probe(struct platform_device *pdev) > { > - struct clk_onecell_data *clk_data; > int r; > - struct device_node *node = pdev->dev.of_node; > + struct device_node *node = pdev->dev.parent->of_node; > + struct clk_mt2712_mm_priv *private; > + > + private = devm_kzalloc(&pdev->dev, sizeof(*private), GFP_KERNEL); > + if (!private) > + return -ENOMEM; > > - clk_data = mtk_alloc_clk_data(CLK_MM_NR_CLK); > + private->clk_data = mtk_alloc_clk_data(CLK_MM_NR_CLK); > + platform_set_drvdata(pdev, private); > > mtk_clk_register_gates(node, mm_clks, ARRAY_SIZE(mm_clks), > - clk_data); > + private->clk_data); > > - r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > + r = of_clk_add_provider(node, of_clk_src_onecell_get, > + private->clk_data); > > if (r != 0) > pr_err("%s(): could not register clock provider: %d\n", > @@ -146,17 +158,20 @@ static int clk_mt2712_mm_probe(struct platform_device *pdev) > return r; > } > > -static const struct of_device_id of_match_clk_mt2712_mm[] = { > - { .compatible = "mediatek,mt2712-mmsys", }, > - {} > -}; > +static int clk_mt2712_mm_remove(struct platform_device *pdev) > +{ > + struct clk_mt2712_mm_priv *private = platform_get_drvdata(pdev); > + > + kfree(private->clk_data); > + > + return 0; > +} > > static struct platform_driver clk_mt2712_mm_drv = { > .probe = clk_mt2712_mm_probe, > + .remove = clk_mt2712_mm_remove, > .driver = { > .name = "clk-mt2712-mm", > - .of_match_table = of_match_clk_mt2712_mm, > }, > }; > - > -builtin_platform_driver(clk_mt2712_mm_drv); > +module_platform_driver(clk_mt2712_mm_drv); >