From: Peng Fan <peng.fan@nxp.com>
To: Abel Vesa <abel.vesa@nxp.com>, Rob Herring <robh@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Anson Huang <anson.huang@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Jacky Bai <ping.bai@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
Abel Vesa <abel.vesa@nxp.com>
Subject: RE: [RFC 02/11] arm64: dts: imx8mp: Add AIPS 4 and 5
Date: Fri, 13 Mar 2020 07:44:43 +0000 [thread overview]
Message-ID: <AM0PR04MB44814EAE53E091499C639F3188FA0@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1583226206-19758-3-git-send-email-abel.vesa@nxp.com>
> Subject: [RFC 02/11] arm64: dts: imx8mp: Add AIPS 4 and 5
>
> There are 5 AIPS maps in total, according to the RM. Add the missing ones
> here.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 71b0c8f..a997ca7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -603,6 +603,22 @@
> };
> };
>
> + aips4: bus@32c00000 {
> + compatible = "simple-bus";
"fsl,aips-bus", "simple-bus";
> + reg = <0x32c00000 0x400000>;
Size is 64KB
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + };
> +
> + aips5: bus@30c00000 {
> + compatible = "simple-bus";
> + reg = <0x30c00000 0x400000>;
Ditto. Please correct compatible and reg.
Without this, I think there is no need to only
add bus here? It might be better to also include
subnodes under aips bus.
Regards,
Peng.
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + };
> +
> gic: interrupt-controller@38800000 {
> compatible = "arm,gic-v3";
> reg = <0x38800000 0x10000>,
> --
> 2.7.4
next prev parent reply other threads:[~2020-03-13 7:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 9:03 [RFC 00/11] Add generic MFD i.MX mix and audiomix support Abel Vesa
2020-03-03 9:03 ` [RFC 01/11] mfd: Add i.MX generic mix support Abel Vesa
2020-03-26 11:03 ` Lee Jones
2020-03-26 12:30 ` Abel Vesa
2020-03-03 9:03 ` [RFC 02/11] arm64: dts: imx8mp: Add AIPS 4 and 5 Abel Vesa
2020-03-13 7:44 ` Peng Fan [this message]
2020-03-23 10:48 ` Abel Vesa
2020-03-03 9:03 ` [RFC 03/11] arm64: dts: imx8mp: Add audiomix node Abel Vesa
2020-03-03 9:03 ` [RFC 04/11] clk: imx: Add gate shared for i.MX8MP audiomix Abel Vesa
2020-03-13 7:47 ` Peng Fan
2020-03-03 9:03 ` [RFC 05/11] clk: imx: pll14xx: Add the device as argument when registering Abel Vesa
2020-03-13 7:50 ` Peng Fan
2020-03-21 0:46 ` Stephen Boyd
2020-03-03 9:03 ` [RFC 06/11] clk: imx: Add helpers for passing the device as argument Abel Vesa
2020-03-13 7:58 ` Peng Fan
2020-03-21 0:46 ` Stephen Boyd
2020-03-03 9:03 ` [RFC 07/11] dt-bindings: clocks: imx8mp: Add ids for audiomix clocks Abel Vesa
2020-03-10 20:17 ` Rob Herring
2020-03-21 0:51 ` Stephen Boyd
2020-03-03 9:03 ` [RFC 08/11] clk: imx: Add audiomix clock controller support Abel Vesa
2020-03-21 0:51 ` Stephen Boyd
2020-03-03 9:03 ` [RFC 09/11] arm64: dts: imx8mp: Add audiomix clock controller node Abel Vesa
2020-03-03 9:03 ` [RFC 10/11] reset: imx: Add audiomix reset controller support Abel Vesa
2020-03-04 11:41 ` Philipp Zabel
2020-03-13 14:16 ` Abel Vesa
2020-03-13 15:55 ` Philipp Zabel
2020-03-18 11:08 ` Abel Vesa
2020-03-10 20:19 ` Rob Herring
2020-03-03 9:03 ` [RFC 11/11] arm64: dts: imx8mp: Add audiomix reset controller node Abel Vesa
2020-04-16 11:06 ` [RFC 00/11] Add generic MFD i.MX mix and audiomix support Arnd Bergmann
2020-04-16 11:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB44814EAE53E091499C639F3188FA0@AM0PR04MB4481.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).