From: Aisheng Dong <aisheng.dong@nxp.com>
To: Dong Aisheng <dongas86@gmail.com>, Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk <linux-clk@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Michael Turquette <mturquette@baylibre.com>,
Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>
Subject: RE: [PATCH v7 00/11] clk: imx8: add new clock binding for better pm support
Date: Sun, 27 Sep 2020 04:13:44 +0000 [thread overview]
Message-ID: <AM6PR04MB4966AC7FCFB47A51A97D5C2980340@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAA+hA=Qj5NV65N4pWJTCREkuxyw6GKKmSF8X4UXvr=Mmq9WpBA@mail.gmail.com>
Gently ping again...
@Stephen Boyd
Could you kindly provide some feedback how we can proceed this?
Regards
Aisheng
> From: Dong Aisheng <dongas86@gmail.com>
> Sent: Wednesday, September 2, 2020 2:36 PM
>
> Hi Stephen,
>
> Would you help look at this?
> Now only one patch left that still does not have a R-b tag and needs your review.
> [PATCH v7 03/11] clk: imx: scu: add two cells binding support All other patches
> already get R-b tags.
>
> Regards
> Aisheng
>
> On Mon, Aug 17, 2020 at 3:42 PM Dong Aisheng <dongas86@gmail.com>
> wrote:
> >
> > Gently ping...
> >
> > On Wed, Jul 29, 2020 at 4:04 PM Dong Aisheng <dongas86@gmail.com>
> wrote:
> > >
> > > Hi Stephen,
> > >
> > > This patchset addressed all your new comments.
> > > Right now only Patch 2/3 still haven't got any R-b or A-b tags. So
> > > still need your help to review.
> > > All other patches already got the R-b tags.
> > >
> > > BTW, for [PATCH v7 02/11] dt-bindings: clock: imx-lpcg: add support
> > > to parse clocks from device tree.
> > > It was reviewed by Rob/Shawn and you before, however, due to the
> > > legacy binding file has been removed and changed to json format.
> > > So this patch also updated to json format accordingly based on the
> > > former reviewed patch and need a re-review.
> > >
> > > Regards
> > > Aisheng
> > >
> > > On Wed, Jul 29, 2020 at 4:04 PM Dong Aisheng <aisheng.dong@nxp.com>
> wrote:
> > > >
> > > > This patch series is a preparation for the MX8 Architecture improvement.
> > > > As for IMX SCU based platforms like MX8QM and MX8QXP, they are
> > > > comprised of a couple of SS(Subsystems) while most of them within
> > > > the same SS can be shared. e.g. Clocks, Devices and etc.
> > > >
> > > > However, current clock binding is using SW IDs for device tree to
> > > > use which can cause troubles in writing the common
> > > > <soc>-ss-xx.dtsi file for different SoCs.
> > > >
> > > > This patch series aims to introduce a new binding which is more
> > > > close to hardware and platform independent and can makes us write
> > > > a more general drivers for different SCU based SoCs.
> > > >
> > > > Another important thing is that on MX8, each Clock resource is
> > > > associated with a power domain. So we have to attach that clock
> > > > device to the power domain in order to make it work properly.
> > > > Further more, the clock state will be lost when its power domain
> > > > is completely off during suspend/resume, so we also introduce the clock
> state save&restore mechanism.
> > > >
> > > > It's based on latest shanw/for-next branch.
> > > >
> > > > The top commit is:
> > > > 3c1a41dab7b8 Merge branch 'imx/defconfig' into for-next
> > > >
> > > > ChangeLog:
> > > > v6->v7:
> > > > * addressed all comments from Stephen
> > > > * rebased to latest shawn/for-next
> > > > v5->v6:
> > > > * add scu clk unregister if add provider failed
> > > > v4->v5:
> > > > * Address all comments from Stephen
> > > > v3->v4:
> > > > * use clk-indices for LPCG to fetch each clks offset from dt
> > > > v2->v3:
> > > > * change scu clk into two cells binding
> > > > * add clk pm patches to ease the understand of the changes
> > > > v1->v2:
> > > > * SCU clock changed to one cell clock binding inspired by arm,scpi.txt
> > > > Documentation/devicetree/bindings/arm/arm,scpi.txt
> > > > * Add required power domain property
> > > > * Dropped PATCH 3&4 first, will send the updated version accordingly
> > > > after the binding is finally determined,
> > > >
> > > > Dong Aisheng (11):
> > > > dt-bindings: firmware: imx-scu: new binding to parse clocks from
> > > > device tree
> > > > dt-bindings: clock: imx-lpcg: add support to parse clocks from device
> > > > tree
> > > > clk: imx: scu: add two cells binding support
> > > > clk: imx: scu: bypass cpu power domains
> > > > clk: imx: scu: allow scu clk to take device pointer
> > > > clk: imx: scu: add runtime pm support
> > > > clk: imx: scu: add suspend/resume support
> > > > clk: imx: imx8qxp-lpcg: add parsing clocks from device tree
> > > > clk: imx: lpcg: allow lpcg clk to take device pointer
> > > > clk: imx: clk-imx8qxp-lpcg: add runtime pm support
> > > > clk: imx: lpcg: add suspend/resume support
> > > >
> > > > .../bindings/arm/freescale/fsl,scu.txt | 12 +-
> > > > .../bindings/clock/imx8qxp-lpcg.yaml | 79 ++++--
> > > > drivers/clk/imx/clk-imx8qxp-lpcg.c | 139 +++++++++++
> > > > drivers/clk/imx/clk-imx8qxp.c | 136 +++++-----
> > > > drivers/clk/imx/clk-lpcg-scu.c | 53 +++-
> > > > drivers/clk/imx/clk-scu.c | 234
> +++++++++++++++++-
> > > > drivers/clk/imx/clk-scu.h | 56 ++++-
> > > > include/dt-bindings/clock/imx8-lpcg.h | 14 ++
> > > > 8 files changed, 620 insertions(+), 103 deletions(-) create mode
> > > > 100644 include/dt-bindings/clock/imx8-lpcg.h
> > > >
> > > > --
> > > > 2.23.0
> > > >
next prev parent reply other threads:[~2020-09-27 4:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 8:00 [PATCH v7 00/11] clk: imx8: add new clock binding for better pm support Dong Aisheng
2020-07-29 8:00 ` [PATCH v7 01/11] dt-bindings: firmware: imx-scu: new binding to parse clocks from device tree Dong Aisheng
2020-07-29 8:00 ` [PATCH v7 02/11] dt-bindings: clock: imx-lpcg: add support " Dong Aisheng
2020-07-29 8:06 ` Dong Aisheng
2020-07-31 21:28 ` Rob Herring
2020-10-14 0:41 ` Stephen Boyd
2020-07-29 8:00 ` [PATCH v7 03/11] clk: imx: scu: add two cells binding support Dong Aisheng
2020-10-14 0:40 ` Stephen Boyd
2020-10-30 1:06 ` Nathan Chancellor
2020-10-30 3:22 ` Aisheng Dong
2020-10-30 15:58 ` Aisheng Dong
2020-07-29 8:00 ` [PATCH v7 04/11] clk: imx: scu: bypass cpu power domains Dong Aisheng
2020-07-29 8:00 ` [PATCH v7 05/11] clk: imx: scu: allow scu clk to take device pointer Dong Aisheng
2020-07-29 8:00 ` [PATCH v7 06/11] clk: imx: scu: add runtime pm support Dong Aisheng
2020-07-29 8:00 ` [PATCH v7 07/11] clk: imx: scu: add suspend/resume support Dong Aisheng
2020-07-29 8:00 ` [PATCH v7 08/11] clk: imx: imx8qxp-lpcg: add parsing clocks from device tree Dong Aisheng
2020-07-29 8:00 ` [PATCH v7 09/11] clk: imx: lpcg: allow lpcg clk to take device pointer Dong Aisheng
2020-07-29 8:00 ` [PATCH v7 10/11] clk: imx: clk-imx8qxp-lpcg: add runtime pm support Dong Aisheng
2020-07-29 8:00 ` [PATCH v7 11/11] clk: imx: lpcg: add suspend/resume support Dong Aisheng
2020-07-29 8:04 ` [PATCH v7 00/11] clk: imx8: add new clock binding for better pm support Dong Aisheng
2020-08-17 7:42 ` Dong Aisheng
2020-09-02 6:35 ` Dong Aisheng
2020-09-27 4:13 ` Aisheng Dong [this message]
2020-10-12 19:28 ` Stephen Boyd
2020-10-13 9:27 ` Dong Aisheng
2020-10-14 0:41 ` Stephen Boyd
2020-10-15 6:51 ` Dong Aisheng
2020-10-26 2:55 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB4966AC7FCFB47A51A97D5C2980340@AM6PR04MB4966.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=dongas86@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).